From patchwork Mon Jun 29 09:47:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pragnesh Patel X-Patchwork-Id: 1318801 X-Patchwork-Delegate: van.freenix@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=selector1 header.b=jols8U3u; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49wN3p1YdQz9sQx for ; Mon, 29 Jun 2020 19:48:54 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0E56681FB1; Mon, 29 Jun 2020 11:48:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.b="jols8U3u"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C37CB81FAB; Mon, 29 Jun 2020 11:48:15 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20617.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5b::617]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BD5A881F75 for ; Mon, 29 Jun 2020 11:48:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pragnesh.patel@sifive.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hmHmgktNTqTQURWpSDGcwF2n3IggpX1eIzkLbdG4PIbnKbIXMOBhvGRrsqDY3FR4WzO7Ua3BH/4mfOVs+kCpP6wGVusm5ySZu9ZcRkLHThFaiCr9yL0Putd7+Iv99RsULO0TXBMAZQnx8DDIFUb16INRwyynSdjgeRR6S6u7mbxOsNQijhKxNDA+iR1xrvJgshgA3efOHFYWrQyFD0UWNxaBqWX1lXprmB/CBNIJr3Q6v6HtDAbnidQKuFJcPcOZjaP9IuwxWrWRgvU+Sme2DcSw/aX5r40EaEaSZSWCxh5diU9zx3rzjLTaCb/7o84eHjq4oYHVuvg63fShs0iydw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FIzeiJyyM+jVaXA8HcXstcohPr6gb7ElRm0wNU5eXdI=; b=c5rSXT3fSDQi+VwaIO/W1I5feWEARL4Lp30MRbi/12PwAtlysVFbFQBFCoiqQtxYNz1mWh/ISAaZAn1VrNrWUiRQGU6P17HTkEw1WdOMboe6zUdezsOuUlLvSYz/2EpNQhhZB5+vip+KOnw5MMNDCXA1jCWaeBaUd5BVj+xpByMTnTDHalAc9HTgBQxN9rrmZs9MmlylCCUl3sSKIOIX8OhqNjXcbcY9f/cUFjeC0nJbeUcwNEC4P+jSTC73JIiQG3d2+nn7Hc3htMtc+m08Xe7qa+2FzuYalHT9Z2W3jOJBOabAWgJDrH7E+7eyIJ39JLGsDsim1lM0sZkKpIgAUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sifive.com; dmarc=pass action=none header.from=sifive.com; dkim=pass header.d=sifive.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FIzeiJyyM+jVaXA8HcXstcohPr6gb7ElRm0wNU5eXdI=; b=jols8U3udT+jJkNEi35K9Im5mHZYO5o+FP14f1A6ZT0hQPuE/+/cMX1PYI6nOsLhvQGf4Nr61A7roI/yc/ws2uL4n6GzG4aEC8e3sLEnhsZwcq3RiPvUkEmQ9+5XkUrFifgcqSi8RtQz25hhdZ27fY4Ly7u9wmFlETmNeE/wO9k= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=sifive.com; Received: from MN2PR13MB2797.namprd13.prod.outlook.com (2603:10b6:208:f2::30) by MN2PR13MB2944.namprd13.prod.outlook.com (2603:10b6:208:13f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.13; Mon, 29 Jun 2020 09:48:02 +0000 Received: from MN2PR13MB2797.namprd13.prod.outlook.com ([fe80::7d39:44e8:5e4f:b8a2]) by MN2PR13MB2797.namprd13.prod.outlook.com ([fe80::7d39:44e8:5e4f:b8a2%6]) with mapi id 15.20.3153.018; Mon, 29 Jun 2020 09:48:02 +0000 From: Pragnesh Patel To: peng.fan@nxp.com Cc: bmeng.cn@gmail.com, paul.walmsley@sifive.com, jagan@amarulasolutions.com, sagar.kadam@sifive.com, u-boot@lists.denx.de, Pragnesh Patel Subject: [PATCH 1/6] mmc: mmc_spi: correct the while condition Date: Mon, 29 Jun 2020 15:17:24 +0530 Message-Id: <20200629094730.10051-2-pragnesh.patel@sifive.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200629094730.10051-1-pragnesh.patel@sifive.com> References: <20200629094730.10051-1-pragnesh.patel@sifive.com> X-ClientProxiedBy: LO2P265CA0437.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::17) To MN2PR13MB2797.namprd13.prod.outlook.com (2603:10b6:208:f2::30) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sachinj2-OptiPlex-7010.open-silicon.com (114.143.65.226) by LO2P265CA0437.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20 via Frontend Transport; Mon, 29 Jun 2020 09:47:59 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [114.143.65.226] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 846fc52e-02c4-492e-adba-08d81c118367 X-MS-TrafficTypeDiagnostic: MN2PR13MB2944: X-LD-Processed: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:576; X-Forefront-PRVS: 044968D9E1 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Uuu+4gTfKw/bdPMPsC+4rjyg4WumzVTqzS1aL6aCRkmUHL/uHmMdSKeoqB0/a2saCc6H76dhibgkKX/OptYBPEXUVByvWLMy+8ZeiH3Pz1Ruzu/yhQZkLnCW3rvmwCnYCVexVRHD/lFxIDz/ZT9HG7lOD1eUNuVmlkNBoJ/QbEKhAONUNnLif6nydCAV4t+E5c49FeN7o1IgJixBNY4/vcSiClfNnB463a0uUELUxe+VgiwPdl+Z4/gvY8qKYA/ELfkSPJBETqS1ug8Y4YtOlJMIcPubJIa8t42KzN7YkNRzKi1KNRcd8EE0vSGS+qBajkH2hVi6JZb1a6szmZvfsg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR13MB2797.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(376002)(346002)(136003)(396003)(39840400004)(8676002)(478600001)(6916009)(66556008)(66476007)(66946007)(83380400001)(107886003)(956004)(6506007)(8936002)(44832011)(52116002)(2616005)(6486002)(6512007)(186003)(16526019)(1006002)(4326008)(6666004)(2906002)(26005)(1076003)(316002)(86362001)(5660300002)(4744005)(36756003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 6IeKfWIh1rMAwkTVvw/EgbRlqkIUCjZ3TfetMqWBzVjXSyD3XkhLcdDnPcdyHr7KbdiC0OS8108W+BYASzjvSlSl0Oa6PvXe8GXRyVk+XHZT+4ZX19z9w//Bz6baK/vbx7ekWmZgXUUSIjwqL+hJR2hoPYohfg3gWpobzu1E2ye02gqgZUGR6xdJPabJqw13k5y0obnqCgUArOCBYmep9NQSjI++u3aq/a9RyxkY8ta+yjSKYqweGdAZbY8P+j/xKm+G6l0qVumJpkC3R06g/Hl2qyKVvJ6al8ZlWn+ndgYXgW99HZCykvGCt72NcqHVvl26qtI4PKl5uGqZK+ZEEGnADzrbzSzIqifHlkBrIklsnKDs2qay1W22wXO1rxhHkgYrA+11a36cxeUGPSCnuIaFhmFF5JtGUeB6p5wwQY0FAJpOUhjVqM5Oq1fCf0XP5YfItydEPqW3MbSnLD+pTxidF6UC5rlEOXqFwc028jh0xIk5Ph8hbPcdn/+TdTlr X-OriginatorOrg: sifive.com X-MS-Exchange-CrossTenant-Network-Message-Id: 846fc52e-02c4-492e-adba-08d81c118367 X-MS-Exchange-CrossTenant-AuthSource: MN2PR13MB2797.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2020 09:48:02.0895 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KHKZareujiyajfgo+Y6fMH+3JfypGCNSOFZMMmAdemyDYsl4iNxUcJmJJoOlbPSDvd42CQoxkm9QXq8AuVQubBGq2yu3gV/Inhlznd2taLM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB2944 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean When variable i will become 0, while(i--) loop breaks but variable i will again decrement to -1 because of i-- and that's why below condition "if (!i && (r != resp_match_value)" will never execute, So doing "i--" inside of while() loop solves this problem. Signed-off-by: Pragnesh Patel Reviewed-by: Bin Meng Tested-by: Bin Meng --- drivers/mmc/mmc_spi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/mmc_spi.c b/drivers/mmc/mmc_spi.c index e76ab54838..86cc932151 100644 --- a/drivers/mmc/mmc_spi.c +++ b/drivers/mmc/mmc_spi.c @@ -105,12 +105,14 @@ static int mmc_spi_sendcmd(struct udevice *dev, if (resp_match) { r = ~resp_match_value; i = CMD_TIMEOUT; - while (i--) { + while (i) { ret = dm_spi_xfer(dev, 1 * 8, NULL, &r, 0); if (ret) return ret; debug(" resp%d=0x%x", rpos, r); rpos++; + i--; + if (r == resp_match_value) break; }