| Message ID | 20200606213103.26605-1-daniel.schwierzeck@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | patman: use new --u-boot option with checkpath.pl | expand |
Hi Daniel, On Sat, 6 Jun 2020 at 15:31, Daniel Schwierzeck <daniel.schwierzeck@gmail.com> wrote: > > checkpatch.pl now supports a --u-boot option for U-Boot specific > checks. Use that in patman to check the patch series. > > Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com> > > --- > > tools/patman/checkpatch.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/patman/checkpatch.py b/tools/patman/checkpatch.py > index 795b519314..7f507154b8 100644 > --- a/tools/patman/checkpatch.py > +++ b/tools/patman/checkpatch.py > @@ -64,7 +64,7 @@ def CheckPatch(fname, verbose=False): > result.problems = [] > chk = FindCheckPatch() > item = {} > - result.stdout = command.Output(chk, '--no-tree', fname, > + result.stdout = command.Output(chk, '--no-tree', '--u-boot', fname, > raise_on_error=False) Can we make this conditional on something? Maybe detecting a U-Boot tree? Patman is used for linux and Zephyr, for example. > #pipe = subprocess.Popen(cmd, stdout=subprocess.PIPE) > #stdout, stderr = pipe.communicate() > -- > 2.27.0 > Regards, Simon
Hi Daniel, On Sat, 6 Jun 2020 at 20:02, Simon Glass <sjg@chromium.org> wrote: > > Hi Daniel, > > On Sat, 6 Jun 2020 at 15:31, Daniel Schwierzeck > <daniel.schwierzeck@gmail.com> wrote: > > > > checkpatch.pl now supports a --u-boot option for U-Boot specific > > checks. Use that in patman to check the patch series. > > > > Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com> > > > > --- > > > > tools/patman/checkpatch.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/patman/checkpatch.py b/tools/patman/checkpatch.py > > index 795b519314..7f507154b8 100644 > > --- a/tools/patman/checkpatch.py > > +++ b/tools/patman/checkpatch.py > > @@ -64,7 +64,7 @@ def CheckPatch(fname, verbose=False): > > result.problems = [] > > chk = FindCheckPatch() > > item = {} > > - result.stdout = command.Output(chk, '--no-tree', fname, > > + result.stdout = command.Output(chk, '--no-tree', '--u-boot', fname, > > raise_on_error=False) > > Can we make this conditional on something? Maybe detecting a U-Boot > tree? Patman is used for linux and Zephyr, for example. Actually I just remembered that I was hoping we could just adjust the .checkpatch.conf file in the U-Boot directory to add the option. Would that work? > > > #pipe = subprocess.Popen(cmd, stdout=subprocess.PIPE) > > #stdout, stderr = pipe.communicate() > > -- > > 2.27.0 > > Regards, Simon
Am 07.06.20 um 05:44 schrieb Simon Glass: > Hi Daniel, > > On Sat, 6 Jun 2020 at 20:02, Simon Glass <sjg@chromium.org> wrote: >> >> Hi Daniel, >> >> On Sat, 6 Jun 2020 at 15:31, Daniel Schwierzeck >> <daniel.schwierzeck@gmail.com> wrote: >>> >>> checkpatch.pl now supports a --u-boot option for U-Boot specific >>> checks. Use that in patman to check the patch series. >>> >>> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com> >>> >>> --- >>> >>> tools/patman/checkpatch.py | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/tools/patman/checkpatch.py b/tools/patman/checkpatch.py >>> index 795b519314..7f507154b8 100644 >>> --- a/tools/patman/checkpatch.py >>> +++ b/tools/patman/checkpatch.py >>> @@ -64,7 +64,7 @@ def CheckPatch(fname, verbose=False): >>> result.problems = [] >>> chk = FindCheckPatch() >>> item = {} >>> - result.stdout = command.Output(chk, '--no-tree', fname, >>> + result.stdout = command.Output(chk, '--no-tree', '--u-boot', fname, >>> raise_on_error=False) >> >> Can we make this conditional on something? Maybe detecting a U-Boot >> tree? Patman is used for linux and Zephyr, for example. > > Actually I just remembered that I was hoping we could just adjust the > .checkpatch.conf file in the U-Boot directory to add the option. Would > that work? > hm, missed that earlier but you already added that with commit b77df5980c3e24e34e0db3a52c5bce396a81c430. Then you can ignore this patch ;)
Hi Daniel, On Sun, 7 Jun 2020 at 08:15, Daniel Schwierzeck <daniel.schwierzeck@gmail.com> wrote: > > > > Am 07.06.20 um 05:44 schrieb Simon Glass: > > Hi Daniel, > > > > On Sat, 6 Jun 2020 at 20:02, Simon Glass <sjg@chromium.org> wrote: > >> > >> Hi Daniel, > >> > >> On Sat, 6 Jun 2020 at 15:31, Daniel Schwierzeck > >> <daniel.schwierzeck@gmail.com> wrote: > >>> > >>> checkpatch.pl now supports a --u-boot option for U-Boot specific > >>> checks. Use that in patman to check the patch series. > >>> > >>> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com> > >>> > >>> --- > >>> > >>> tools/patman/checkpatch.py | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/tools/patman/checkpatch.py b/tools/patman/checkpatch.py > >>> index 795b519314..7f507154b8 100644 > >>> --- a/tools/patman/checkpatch.py > >>> +++ b/tools/patman/checkpatch.py > >>> @@ -64,7 +64,7 @@ def CheckPatch(fname, verbose=False): > >>> result.problems = [] > >>> chk = FindCheckPatch() > >>> item = {} > >>> - result.stdout = command.Output(chk, '--no-tree', fname, > >>> + result.stdout = command.Output(chk, '--no-tree', '--u-boot', fname, > >>> raise_on_error=False) > >> > >> Can we make this conditional on something? Maybe detecting a U-Boot > >> tree? Patman is used for linux and Zephyr, for example. > > > > Actually I just remembered that I was hoping we could just adjust the > > .checkpatch.conf file in the U-Boot directory to add the option. Would > > that work? > > > > hm, missed that earlier but you already added that with commit > b77df5980c3e24e34e0db3a52c5bce396a81c430. Then you can ignore this patch ;) Ah OK. Does it work correctly for you? Regards, Simon
diff --git a/tools/patman/checkpatch.py b/tools/patman/checkpatch.py index 795b519314..7f507154b8 100644 --- a/tools/patman/checkpatch.py +++ b/tools/patman/checkpatch.py @@ -64,7 +64,7 @@ def CheckPatch(fname, verbose=False): result.problems = [] chk = FindCheckPatch() item = {} - result.stdout = command.Output(chk, '--no-tree', fname, + result.stdout = command.Output(chk, '--no-tree', '--u-boot', fname, raise_on_error=False) #pipe = subprocess.Popen(cmd, stdout=subprocess.PIPE) #stdout, stderr = pipe.communicate()
checkpatch.pl now supports a --u-boot option for U-Boot specific checks. Use that in patman to check the patch series. Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com> --- tools/patman/checkpatch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)