| Message ID | 20200530032425.10670-5-GNUtoo@cyberdimension.org |
|---|---|
| State | Rejected |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [PATCHv5,1/7] board: tbs2910: disable loadb and loads commands | expand |
On 30.05.20 05:24, Denis 'GNUtoo' Carikli wrote: > As that the resulting image is already very close to the > size limit, and that CONFIG_DHCP is not strictly required, > removing it shouldn't hurt. You removed CONFIG_CMD_DHCP. This is used to check the ethernet connection of the board. And since we enable NFS boot in defconfig, we also want DHCP. Please keep this command and drop this patch. > > With arm-linux-gnueabi-gcc 9.3.0-1 from the Parabola > GNU/Linux distribution, we have the following size > differences: > - text: -1708 bytes > - data: -28 bytes > - bss: -20 bytes > - total: -1756 bytes > > Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> > --- > Changelog since v4: > ------------------- > - I was requested to remove DHCP in the v3 review > but I forgot about it in v4. This fixes it. I asked to "remove DHCP and PXE boot targets" in BOOT_TARGET_DEVICES for distroboot. This already was correctly done in v4 of this series. Please drop this patch. Thanks, Soeren > --- > configs/tbs2910_defconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/configs/tbs2910_defconfig b/configs/tbs2910_defconfig > index fc9095c859..9b25dcff5e 100644 > --- a/configs/tbs2910_defconfig > +++ b/configs/tbs2910_defconfig > @@ -39,7 +39,6 @@ CONFIG_CMD_PCI=y > CONFIG_CMD_SATA=y > CONFIG_CMD_USB=y > CONFIG_CMD_USB_MASS_STORAGE=y > -CONFIG_CMD_DHCP=y > CONFIG_CMD_MII=y > CONFIG_CMD_PING=y > CONFIG_CMD_CACHE=y
diff --git a/configs/tbs2910_defconfig b/configs/tbs2910_defconfig index fc9095c859..9b25dcff5e 100644 --- a/configs/tbs2910_defconfig +++ b/configs/tbs2910_defconfig @@ -39,7 +39,6 @@ CONFIG_CMD_PCI=y CONFIG_CMD_SATA=y CONFIG_CMD_USB=y CONFIG_CMD_USB_MASS_STORAGE=y -CONFIG_CMD_DHCP=y CONFIG_CMD_MII=y CONFIG_CMD_PING=y CONFIG_CMD_CACHE=y
As that the resulting image is already very close to the size limit, and that CONFIG_DHCP is not strictly required, removing it shouldn't hurt. With arm-linux-gnueabi-gcc 9.3.0-1 from the Parabola GNU/Linux distribution, we have the following size differences: - text: -1708 bytes - data: -28 bytes - bss: -20 bytes - total: -1756 bytes Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> --- Changelog since v4: ------------------- - I was requested to remove DHCP in the v3 review but I forgot about it in v4. This fixes it. --- configs/tbs2910_defconfig | 1 - 1 file changed, 1 deletion(-)