diff mbox series

[PATCHv5,1/7] board: tbs2910: disable loadb and loads commands

Message ID 20200530032425.10670-1-GNUtoo@cyberdimension.org
State Awaiting Upstream
Delegated to: Tom Rini
Headers show
Series [PATCHv5,1/7] board: tbs2910: disable loadb and loads commands | expand

Commit Message

Denis 'GNUtoo' Carikli May 30, 2020, 3:24 a.m. UTC
The loadb and loads commands are not needed for booting.

There are also more reliable and faster alternatives to
loadb and loads that can be used with the current configuration.

As that the resulting image is already very close to the
size limit, removing the loadb and loads commands shouldn't
hurt.

With arm-linux-gnueabi-gcc 9.2.0-1 from the Parabola
GNU/Linux distribution we have the following size
reduction:
- text: 6733 bytes
- data: 116 bytes
- bss: 1172 bytes
- total: 8021 bytes

Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
Acked-by: Soeren Moch <smoch@web.de>
---
Changelog since v4:
-------------------
- Fixed Acked-by location in the commit message as requested by
  Soeren Moch.
---
 configs/tbs2910_defconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Tom Rini June 12, 2020, 9:17 p.m. UTC | #1
On Sat, May 30, 2020 at 05:24:19AM +0200, Denis 'GNUtoo' Carikli wrote:

> The loadb and loads commands are not needed for booting.
> 
> There are also more reliable and faster alternatives to
> loadb and loads that can be used with the current configuration.
> 
> As that the resulting image is already very close to the
> size limit, removing the loadb and loads commands shouldn't
> hurt.
> 
> With arm-linux-gnueabi-gcc 9.2.0-1 from the Parabola
> GNU/Linux distribution we have the following size
> reduction:
> - text: 6733 bytes
> - data: 116 bytes
> - bss: 1172 bytes
> - total: 8021 bytes
> 
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
> Acked-by: Soeren Moch <smoch@web.de>

Applied to u-boot/next, thanks!
diff mbox series

Patch

diff --git a/configs/tbs2910_defconfig b/configs/tbs2910_defconfig
index 2ff0e160f7..2623eb73cd 100644
--- a/configs/tbs2910_defconfig
+++ b/configs/tbs2910_defconfig
@@ -28,6 +28,8 @@  CONFIG_SYS_MEMTEST_START=0x10000000
 CONFIG_SYS_MEMTEST_END=0x2f400000
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_I2C=y
+# CONFIG_CMD_LOADB is not set
+# CONFIG_CMD_LOADS is not set
 CONFIG_CMD_MMC=y
 CONFIG_CMD_PART=y
 CONFIG_CMD_PCI=y