diff mbox series

Remove CROSS_COMPILE default from arch/*/config.mk

Message ID 20200519143233.14230-1-trini@konsulko.com
State Accepted
Commit faf002c0ab8bf013f891ec8ae09e3c0cc2bfcb6f
Delegated to: Tom Rini
Headers show
Series Remove CROSS_COMPILE default from arch/*/config.mk | expand

Commit Message

Tom Rini May 19, 2020, 2:32 p.m. UTC
In order to support the compiler providing information used within
Kconfig itself we cannot have the compiler be determined by
arch/*/config.mk as we will not be able to evaluate that yet.  Given
that most documentation tells people to specify CROSS_COMPILE, remove
these references.

Cc: Huan Wang <alison.wang@nxp.com>
Cc: Angelo Dureghello <angelo@sysam.it>
Cc: Michal Simek <monstr@monstr.eu>
Cc: Rick Chen <rick@andestech.com>
Cc: Thomas Chou <thomas@wytron.com.tw>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Cc: Simon Glass <sjg@chromium.org>
Cc: Bin Meng <bmeng.cn@gmail.com>
Cc: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: Tom Rini <trini@konsulko.com>
---
 arch/m68k/config.mk       | 4 ----
 arch/microblaze/config.mk | 4 ----
 arch/nds32/config.mk      | 4 ----
 arch/nios2/config.mk      | 4 ----
 arch/powerpc/config.mk    | 4 ----
 arch/sh/config.mk         | 4 ----
 arch/x86/cpu/config.mk    | 2 --
 arch/xtensa/config.mk     | 1 -
 8 files changed, 27 deletions(-)

Comments

Simon Glass May 19, 2020, 4:47 p.m. UTC | #1
On Tue, 19 May 2020 at 08:32, Tom Rini <trini@konsulko.com> wrote:
>
> In order to support the compiler providing information used within
> Kconfig itself we cannot have the compiler be determined by
> arch/*/config.mk as we will not be able to evaluate that yet.  Given
> that most documentation tells people to specify CROSS_COMPILE, remove
> these references.
>
> Cc: Huan Wang <alison.wang@nxp.com>
> Cc: Angelo Dureghello <angelo@sysam.it>
> Cc: Michal Simek <monstr@monstr.eu>
> Cc: Rick Chen <rick@andestech.com>
> Cc: Thomas Chou <thomas@wytron.com.tw>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> Cc: Max Filippov <jcmvbkbc@gmail.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
>  arch/m68k/config.mk       | 4 ----
>  arch/microblaze/config.mk | 4 ----
>  arch/nds32/config.mk      | 4 ----
>  arch/nios2/config.mk      | 4 ----
>  arch/powerpc/config.mk    | 4 ----
>  arch/sh/config.mk         | 4 ----
>  arch/x86/cpu/config.mk    | 2 --
>  arch/xtensa/config.mk     | 1 -
>  8 files changed, 27 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Michal Simek May 20, 2020, 8:19 a.m. UTC | #2
On 19. 05. 20 16:32, Tom Rini wrote:
> In order to support the compiler providing information used within
> Kconfig itself we cannot have the compiler be determined by
> arch/*/config.mk as we will not be able to evaluate that yet.  Given
> that most documentation tells people to specify CROSS_COMPILE, remove
> these references.
> 
> Cc: Huan Wang <alison.wang@nxp.com>
> Cc: Angelo Dureghello <angelo@sysam.it>
> Cc: Michal Simek <monstr@monstr.eu>
> Cc: Rick Chen <rick@andestech.com>
> Cc: Thomas Chou <thomas@wytron.com.tw>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> Cc: Max Filippov <jcmvbkbc@gmail.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
>  arch/m68k/config.mk       | 4 ----
>  arch/microblaze/config.mk | 4 ----

none is really using it anyway.

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal
Tom Rini July 5, 2020, 10:09 p.m. UTC | #3
On Tue, May 19, 2020 at 10:32:33AM -0400, Tom Rini wrote:

> In order to support the compiler providing information used within
> Kconfig itself we cannot have the compiler be determined by
> arch/*/config.mk as we will not be able to evaluate that yet.  Given
> that most documentation tells people to specify CROSS_COMPILE, remove
> these references.
> 
> Cc: Huan Wang <alison.wang@nxp.com>
> Cc: Angelo Dureghello <angelo@sysam.it>
> Cc: Michal Simek <monstr@monstr.eu>
> Cc: Rick Chen <rick@andestech.com>
> Cc: Thomas Chou <thomas@wytron.com.tw>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> Cc: Max Filippov <jcmvbkbc@gmail.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Acked-by: Michal Simek <michal.simek@xilinx.com>

Applied to u-boot/next, thanks!
diff mbox series

Patch

diff --git a/arch/m68k/config.mk b/arch/m68k/config.mk
index 88b1a409f260..ed592334af2e 100644
--- a/arch/m68k/config.mk
+++ b/arch/m68k/config.mk
@@ -3,10 +3,6 @@ 
 # (C) Copyright 2000-2002
 # Wolfgang Denk, DENX Software Engineering, wd@denx.de.
 
-ifeq ($(CROSS_COMPILE),)
-CROSS_COMPILE := m68k-elf-
-endif
-
 CONFIG_STANDALONE_LOAD_ADDR ?= 0x20000
 
 PLATFORM_CPPFLAGS += -D__M68K__
diff --git a/arch/microblaze/config.mk b/arch/microblaze/config.mk
index 3c5866a29528..96c39b1278b1 100644
--- a/arch/microblaze/config.mk
+++ b/arch/microblaze/config.mk
@@ -6,10 +6,6 @@ 
 # (C) Copyright 2004 Atmark Techno, Inc.
 # Yasushi SHOJI <yashi@atmark-techno.com>
 
-ifeq ($(CROSS_COMPILE),)
-CROSS_COMPILE := mb-
-endif
-
 CONFIG_STANDALONE_LOAD_ADDR ?= 0x80F00000
 
 PLATFORM_CPPFLAGS += -ffixed-r31 -D__microblaze__
diff --git a/arch/nds32/config.mk b/arch/nds32/config.mk
index a1c3371ddcfd..c82dd69c6c30 100644
--- a/arch/nds32/config.mk
+++ b/arch/nds32/config.mk
@@ -8,10 +8,6 @@ 
 # Macpaul Lin, Andes Technology Corporation <macpaul@andestech.com>
 #
 
-ifeq ($(CROSS_COMPILE),)
-CROSS_COMPILE := nds32le-linux-
-endif
-
 CONFIG_STANDALONE_LOAD_ADDR = 0x300000
 LDFLAGS_STANDALONE	+= -T $(srctree)/examples/standalone/nds32.lds
 
diff --git a/arch/nios2/config.mk b/arch/nios2/config.mk
index c63d170eaee6..44260b1431cb 100644
--- a/arch/nios2/config.mk
+++ b/arch/nios2/config.mk
@@ -4,10 +4,6 @@ 
 # Psyent Corporation <www.psyent.com>
 # Scott McNutt <smcnutt@psyent.com>
 
-ifeq ($(CROSS_COMPILE),)
-CROSS_COMPILE := nios2-elf-
-endif
-
 CONFIG_STANDALONE_LOAD_ADDR ?= 0x02000000
 
 PLATFORM_CPPFLAGS += -D__NIOS2__
diff --git a/arch/powerpc/config.mk b/arch/powerpc/config.mk
index 88e2c58cb44a..307ca65745c8 100644
--- a/arch/powerpc/config.mk
+++ b/arch/powerpc/config.mk
@@ -3,10 +3,6 @@ 
 # (C) Copyright 2000-2010
 # Wolfgang Denk, DENX Software Engineering, wd@denx.de.
 
-ifeq ($(CROSS_COMPILE),)
-CROSS_COMPILE := ppc_8xx-
-endif
-
 CONFIG_STANDALONE_LOAD_ADDR ?= 0x40000
 LDFLAGS_FINAL += --gc-sections
 LDFLAGS_FINAL += --bss-plt
diff --git a/arch/sh/config.mk b/arch/sh/config.mk
index 6ef44638abd0..4cdde807245f 100644
--- a/arch/sh/config.mk
+++ b/arch/sh/config.mk
@@ -3,10 +3,6 @@ 
 # (C) Copyright 2000-2002
 # Wolfgang Denk, DENX Software Engineering, wd@denx.de.
 
-ifeq ($(CROSS_COMPILE),)
-CROSS_COMPILE := sh4-linux-
-endif
-
 CONFIG_STANDALONE_LOAD_ADDR ?= 0x8C000000
 ifeq ($(CPU),sh2)
 LDFLAGS_STANDALONE += -EB
diff --git a/arch/x86/cpu/config.mk b/arch/x86/cpu/config.mk
index 8f9814c0ae7d..d3033b416034 100644
--- a/arch/x86/cpu/config.mk
+++ b/arch/x86/cpu/config.mk
@@ -3,8 +3,6 @@ 
 # (C) Copyright 2002
 # Daniel Engström, Omicron Ceti AB, daniel@omicron.se.
 
-CROSS_COMPILE ?= i386-linux-
-
 # DO NOT MODIFY THE FOLLOWING UNLESS YOU REALLY KNOW WHAT YOU ARE DOING!
 LDPPFLAGS += -DRESET_SEG_START=$(CONFIG_RESET_SEG_START)
 LDPPFLAGS += -DRESET_VEC_LOC=$(CONFIG_RESET_VEC_LOC)
diff --git a/arch/xtensa/config.mk b/arch/xtensa/config.mk
index ec3710786290..b0809999e403 100644
--- a/arch/xtensa/config.mk
+++ b/arch/xtensa/config.mk
@@ -3,7 +3,6 @@ 
 # (C) Copyright 2007 - 2013 Tensilica, Inc.
 # (C) Copyright 2014 - 2016 Cadence Design Systems Inc.
 
-CROSS_COMPILE ?= xtensa-linux-
 PLATFORM_CPPFLAGS += -D__XTENSA__ -mlongcalls -mforce-no-pic \
 		     -ffunction-sections -fdata-sections