From patchwork Sun May 3 14:19:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 1281978 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=oAr5fj9z; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49FSJP2P79z9sRY for ; Sun, 3 May 2020 23:58:45 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 77EFD81F06; Sun, 3 May 2020 15:57:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="oAr5fj9z"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D7F8F81ED5; Sun, 3 May 2020 15:57:19 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on062c.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1e::62c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A878181EC9 for ; Sun, 3 May 2020 15:57:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=peng.fan@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iqKxjTA6mfOWVdIQOgHczLjaLR5yzSOTsCNcQq77+/GUlaCCu5hOh5ZbvVL5hAJcBWipityI85uwJhw8KaSBNm2NO6XdcAoW5tN4uKy6kYwa56eocNU5DF/tq/pynPrIG7tk0bkpfKaiuiJS1ZoSjKC5InhBEawKQzduigHbM/HO0WgPtYAImb2xFQkheGfp2a7IGvZDnmtF8yRLXyxYc3rOrlVGy/+xmwdnlx7CknOt8cEyINGacPDg4wMeegrZURdxKUXIjAi60e/YpPF+YuvbznhvmD1YbB5XssT9qX3EqleZt6LKRVVeaxfJ+RdYV3XtU2LXNl5mg4waeRgyvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AOiL/hFZTi8uH6FjjwdCnJo4XD9PgLXU2+2XAgPkWvo=; b=UjuF96tQQUq0FB/bmbgdNrQUnZiLHb3W38S/jh+TCfyhgvJC6f0TLRnEQT/mFZnbsQvgF2ST66iW6RxMj8B2Dw1AfM9g+OiXf7iwcQXqPfRINa6RQeGb4EIH2arfItH5Fxu/fnW8SdDdHLlEV31yauB5VEdI+Q2usjJP1sj7wAATY5rNNpdKvbv7tR3szhBWE4ozWh+UXCYgKeE4rrwCTboJ3XV4BEZrQFbqzjRDE0h1+UyPRViF36AAXx3Kf/K5WGku73dIPl32xeWYAB6W0iHqkoa2Ti/fR3X5YEXZD0cu9W98ZiJJz9npBbhM6RYsmH6zo/xwpasVyMdzDK5y6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AOiL/hFZTi8uH6FjjwdCnJo4XD9PgLXU2+2XAgPkWvo=; b=oAr5fj9zibWLzYu79os7SxX3Qj2DOlGV0QUtNN2wRDIX/ozcCyAnBoAIsyt0pznm74uonANfzxfy12sdZHLEVqzC/9Gi7e2Rn2aaCKK1E/7BRfRyCqI8QGppwEbT/JtHgprBgTC6hkcQEObo0Al5avKgpx6+raJfcIeumYq+AxE= Authentication-Results: denx.de; dkim=none (message not signed) header.d=none;denx.de; dmarc=none action=none header.from=nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB6PR0402MB2808.eurprd04.prod.outlook.com (2603:10a6:4:95::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.20; Sun, 3 May 2020 13:57:15 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::d17b:d767:19c3:b871]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::d17b:d767:19c3:b871%6]) with mapi id 15.20.2958.029; Sun, 3 May 2020 13:57:15 +0000 From: Peng Fan To: sbabic@denx.de, festevam@gmail.com Cc: uboot-imx@nxp.com, u-boot@lists.denx.de, Peng Fan , Ye Li Subject: [PATCH 06/13] thermal: imx_tmu: Check the TEMP range for iMX8MM Date: Sun, 3 May 2020 22:19:50 +0800 Message-Id: <20200503141957.14635-7-peng.fan@nxp.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20200503141957.14635-1-peng.fan@nxp.com> References: <20200503141957.14635-1-peng.fan@nxp.com> X-ClientProxiedBy: SG2PR01CA0107.apcprd01.prod.exchangelabs.com (2603:1096:3:15::33) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux-1xn6.ap.freescale.net (119.31.174.71) by SG2PR01CA0107.apcprd01.prod.exchangelabs.com (2603:1096:3:15::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.19 via Frontend Transport; Sun, 3 May 2020 13:57:13 +0000 X-Mailer: git-send-email 2.16.4 X-Originating-IP: [119.31.174.71] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 1966e869-30ff-4b33-52c2-08d7ef69e2e7 X-MS-TrafficTypeDiagnostic: DB6PR0402MB2808:|DB6PR0402MB2808: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-Forefront-PRVS: 0392679D18 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4b2fUlzKPF+DLVqm6gE2ExcJ/fwp41B8MSkOlq8EkIkNadmG+KBEay+6j5DtdEtIwiOGp/dmvkhBj7oqG+pbdhA7YL1ShW0hc3lUPjwUMMDC7BCLApfPP/I9mvhk/SWID7m8ivtBksAod3MbiawPtb3ohOM61b/Tsh8m5ja4EUVbDK6oNr6uVO8lodWSzhuw0HBW6KDeM/JCZk0yMPUBwUf0BARxtE0K+I1bZkdIU8IGHVjiDEWIpZIFPCiMZt0BYc/9FmTVQLhdYM1ntnNidxhx7JZuHuFXIr4isA7mys3sADeWXvcz4WdEOlZw0qywyz0bJFix8j5OEZwAFtN2p6st1O5I0p5z1AO0Emk6KzkH7Pzx+VO3T7+E+A1pLaAPMp/Spnl4Bxzx8JIqQbjTWbE1QBL6j3RvPdNHbNvwPtCgjuR6GrvCrfvJZm5I+kVRAVGG4PDlDTvTd3+kX8fQ6OUx2Zbcz10ZDEn1iyKaaiZAgIj/fhhqPyrIIyxuO1ur X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(366004)(376002)(136003)(396003)(39860400002)(956004)(2616005)(6666004)(8936002)(44832011)(8676002)(26005)(6512007)(6486002)(478600001)(66946007)(52116002)(6506007)(36756003)(2906002)(16526019)(186003)(66556008)(66476007)(316002)(54906003)(5660300002)(86362001)(4326008)(1076003)(32563001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: VYx0E2sLrfVKFMZUWGdeNCXbE6leAvSGESJ7+bctg2YuNbytpghAVDV6Om22wFGtnXK0mYc8xCOCzjup+DLvK+XAUN1OFqQlFMRTERoJjIDsqBIMl/AIYfmy6aHObnH2hTgFCJK/hkU6BrZoj4ByrgOAdP/myCqiGAYeZl5wUP/eSakCr8+9jq1lE/f+GiFFGbBXHLzTiuvvcujfcVM9St5DqPeSUIVBx4iAyts9v95qjG245f7qkvsR2OPNFD8+nfo0Td9S1dAT1P2spEdelFvefJWg4pQDU1ntYN7KQWmIq5vkUc95rzq//6Jua/jNugMVqWzMaRSTNi/4FzZdhsy7vazHNfhGU6dKOSdxovjv807sliE4OrHxZ8LS9HQMhuKfUn7DoIoYBq0F9qB8WTTplBJpaeIeXKIv2fjPIVltcZJ+/v+bN4LsQjgmTGLPm3XyI7SdynZj9ASbnKNzBY5ruwNzF/2LbCWKeovbtxTAT87QeZ0U/kNWU+559NKm6z25ixuVJSZSaxUmqZ6UxO/k2BBONKk0bQqm3LqjZYk75w87WXJqlaS+jAv4J0OrHfTj7pbilXjFFOJ9FsM/jW0Bu/k+djS04AEVXfRJKmZE4Sk/ufUwdxfIue7CDrVOmJLbhYWWyPTTYHSG57hSRwTOy3mE/J0h2D80RuYM0EZ9m/O8WOVbyJ2p2XIbgCHxcP2nxQ03uhTsYge71KYGylrVu9yU5MdPnHXwn0Q+2P7ERuAln/RJtHIEUkR8Loq7EqjIe669wSnJsKE2xv15z83jyp/Sh9X7pChKujZSbdE= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1966e869-30ff-4b33-52c2-08d7ef69e2e7 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2020 13:57:15.6048 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H7wTjrZlMhn+Qc/gWnGg1/UZD9BIeZZZB/5pdu4I2D1VN0RK03Y3sfjDY7kj3T7LYS28W6727AJxJktulQeu1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2808 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean On iMX8MM, the V flag in TRISTR register only reflect the state of SNSR value, not the calibrated TEMP value. So checking this flag is not reliable. Per IC suggestion, change to read the TEMP/AVG_TEMP directly and check whether it in valid range 10-125C. Signed-off-by: Ye Li Signed-off-by: Peng Fan --- drivers/thermal/imx_tmu.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/imx_tmu.c b/drivers/thermal/imx_tmu.c index 2a08d5085c..c577b0bd6c 100644 --- a/drivers/thermal/imx_tmu.c +++ b/drivers/thermal/imx_tmu.c @@ -106,16 +106,24 @@ static int read_temperature(struct udevice *dev, int *temp) ulong drv_data = dev_get_driver_data(dev); u32 val; u32 retry = 10; + u32 valid = 0; do { mdelay(100); retry--; - if (drv_data & FLAGS_VER2) + if (drv_data & FLAGS_VER2) { val = readl(&pdata->regs->regs_v2.tritsr); - else + /* + * Check if TEMP is in valid range, the V bit in TRITSR + * only reflects the RAW uncalibrated data + */ + valid = ((val & 0xff) < 10 || (val & 0xff) > 125) ? 0 : 1; + } else { val = readl(&pdata->regs->regs_v1.site[pdata->id].tritsr); - } while (!(val & 0x80000000) && retry > 0); + valid = val & 0x80000000; + } + } while (!valid && retry > 0); if (retry > 0) *temp = (val & 0xff) * 1000;