diff mbox series

[v2,04/19] clk: imx: clk-imxrt1050: add set_parent() callback

Message ID 20200322224435.114512-5-giulio.benetti@benettiengineering.com
State Superseded
Delegated to: Stefano Babic
Headers show
Series i.MXRT1050 add LCDIF support | expand

Commit Message

Giulio Benetti March 22, 2020, 10:44 p.m. UTC 
Need to add set_parent() callback to allow dts assigned-clock-parents to
work so let's add it accordingly.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* introduce patch to allow clock's parent setting in dts to work
---
 drivers/clk/imx/clk-imxrt1050.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

Comments

Giulio Benetti April 17, 2020, 6:29 p.m. UTC | #1 
Hi Lukasz,

On 3/22/20 11:44 PM, Giulio Benetti wrote:
> Need to add set_parent() callback to allow dts assigned-clock-parents to
> work so let's add it accordingly.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * introduce patch to allow clock's parent setting in dts to work
> ---
>   drivers/clk/imx/clk-imxrt1050.c | 19 +++++++++++++++++++
>   1 file changed, 19 insertions(+)
> 
> diff --git a/drivers/clk/imx/clk-imxrt1050.c b/drivers/clk/imx/clk-imxrt1050.c
> index bb12644605..329f4580c5 100644
> --- a/drivers/clk/imx/clk-imxrt1050.c
> +++ b/drivers/clk/imx/clk-imxrt1050.c
> @@ -71,11 +71,30 @@ static int imxrt1050_clk_enable(struct clk *clk)
>   	return __imxrt1050_clk_enable(clk, 1);
>   }
>   
> +static int imxrt1050_clk_set_parent(struct clk *clk, struct clk *parent)
> +{
> +	struct clk *c, *cp;
> +	int ret;
> +
> +	debug("%s(#%lu), parent: %lu\n", __func__, clk->id, parent->id);
> +
> +	ret = clk_get_by_id(clk->id, &c);
> +	if (ret)
> +		return ret;
> +
> +	ret = clk_get_by_id(parent->id, &cp);
> +	if (ret)
> +		return ret;
> +
> +	return clk_set_parent(c, cp);
> +}
> +
>   static struct clk_ops imxrt1050_clk_ops = {
>   	.set_rate = imxrt1050_clk_set_rate,
>   	.get_rate = imxrt1050_clk_get_rate,
>   	.enable = imxrt1050_clk_enable,
>   	.disable = imxrt1050_clk_disable,
> +	.set_parent = imxrt1050_clk_set_parent,
>   };
>   
>   static const char * const pll_ref_sels[] = {"osc", "dummy", };
> 

Can you please review this patch? There was not in previous patchset.

Thanks in advance
Kind regards
diff mbox series

Patch

diff --git a/drivers/clk/imx/clk-imxrt1050.c b/drivers/clk/imx/clk-imxrt1050.c
index bb12644605..329f4580c5 100644
--- a/drivers/clk/imx/clk-imxrt1050.c
+++ b/drivers/clk/imx/clk-imxrt1050.c
@@ -71,11 +71,30 @@  static int imxrt1050_clk_enable(struct clk *clk)
 	return __imxrt1050_clk_enable(clk, 1);
 }
 
+static int imxrt1050_clk_set_parent(struct clk *clk, struct clk *parent)
+{
+	struct clk *c, *cp;
+	int ret;
+
+	debug("%s(#%lu), parent: %lu\n", __func__, clk->id, parent->id);
+
+	ret = clk_get_by_id(clk->id, &c);
+	if (ret)
+		return ret;
+
+	ret = clk_get_by_id(parent->id, &cp);
+	if (ret)
+		return ret;
+
+	return clk_set_parent(c, cp);
+}
+
 static struct clk_ops imxrt1050_clk_ops = {
 	.set_rate = imxrt1050_clk_set_rate,
 	.get_rate = imxrt1050_clk_get_rate,
 	.enable = imxrt1050_clk_enable,
 	.disable = imxrt1050_clk_disable,
+	.set_parent = imxrt1050_clk_set_parent,
 };
 
 static const char * const pll_ref_sels[] = {"osc", "dummy", };