diff mbox series

bdinfo: Show information about fdt blob via bdinfo

Message ID 20200219051903.1276724-1-hs@denx.de
State Changes Requested
Delegated to: Tom Rini
Headers show
Series bdinfo: Show information about fdt blob via bdinfo | expand

Commit Message

Heiko Schocher Feb. 19, 2020, 5:19 a.m. UTC
PowerPC target supports OF booting, so print the
fdt address and size in bdinfo.

Signed-off-by: Heiko Schocher <hs@denx.de>
---
Travis build:
https://travis-ci.org/hsdenx/u-boot-test/builds/651885430

 cmd/bdinfo.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Simon Glass Feb. 20, 2020, 3:04 a.m. UTC | #1
On Tue, 18 Feb 2020 at 22:19, Heiko Schocher <hs@denx.de> wrote:
>
> PowerPC target supports OF booting, so print the
> fdt address and size in bdinfo.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
> Travis build:
> https://travis-ci.org/hsdenx/u-boot-test/builds/651885430
>
>  cmd/bdinfo.c | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>
Heiko Schocher April 9, 2020, 5:14 a.m. UTC | #2
Hello Tom,

Am 19.02.2020 um 06:19 schrieb Heiko Schocher:
> PowerPC target supports OF booting, so print the
> fdt address and size in bdinfo.
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
> Travis build:
> https://travis-ci.org/hsdenx/u-boot-test/builds/651885430
> 
>   cmd/bdinfo.c | 3 +++
>   1 file changed, 3 insertions(+)

Any issues with this patch, or do you plan to apply it after release?

Thanks!

bye,
Heiko
Heiko Schocher May 18, 2020, 4:28 a.m. UTC | #3
Hello Tom,

Am 09.04.2020 um 07:14 schrieb Heiko Schocher:
> Hello Tom,
> 
> Am 19.02.2020 um 06:19 schrieb Heiko Schocher:
>> PowerPC target supports OF booting, so print the
>> fdt address and size in bdinfo.
>>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> ---
>> Travis build:
>> https://travis-ci.org/hsdenx/u-boot-test/builds/651885430
>>
>>   cmd/bdinfo.c | 3 +++
>>   1 file changed, 3 insertions(+)
> 
> Any issues with this patch, or do you plan to apply it after release?
> 
> Thanks!

Any issues?

bye,
Heiko
Bin Meng May 18, 2020, 5:42 a.m. UTC | #4
Hi Heiko,

On Mon, May 18, 2020 at 12:28 PM Heiko Schocher <hs@denx.de> wrote:
>
> Hello Tom,
>
> Am 09.04.2020 um 07:14 schrieb Heiko Schocher:
> > Hello Tom,
> >
> > Am 19.02.2020 um 06:19 schrieb Heiko Schocher:
> >> PowerPC target supports OF booting, so print the
> >> fdt address and size in bdinfo.
> >>
> >> Signed-off-by: Heiko Schocher <hs@denx.de>
> >> ---
> >> Travis build:
> >> https://travis-ci.org/hsdenx/u-boot-test/builds/651885430
> >>
> >>   cmd/bdinfo.c | 3 +++
> >>   1 file changed, 3 insertions(+)
> >
> > Any issues with this patch, or do you plan to apply it after release?
> >
> > Thanks!
>
> Any issues?

I think it's better to have this patch rebased on top of Simon's
bdinfo clean-up series.
http://patchwork.ozlabs.org/project/uboot/list/?series=176007

Regards,
Bin
Tom Rini May 18, 2020, 3:17 p.m. UTC | #5
On Mon, May 18, 2020 at 01:42:32PM +0800, Bin Meng wrote:
> Hi Heiko,
> 
> On Mon, May 18, 2020 at 12:28 PM Heiko Schocher <hs@denx.de> wrote:
> >
> > Hello Tom,
> >
> > Am 09.04.2020 um 07:14 schrieb Heiko Schocher:
> > > Hello Tom,
> > >
> > > Am 19.02.2020 um 06:19 schrieb Heiko Schocher:
> > >> PowerPC target supports OF booting, so print the
> > >> fdt address and size in bdinfo.
> > >>
> > >> Signed-off-by: Heiko Schocher <hs@denx.de>
> > >> ---
> > >> Travis build:
> > >> https://travis-ci.org/hsdenx/u-boot-test/builds/651885430
> > >>
> > >>   cmd/bdinfo.c | 3 +++
> > >>   1 file changed, 3 insertions(+)
> > >
> > > Any issues with this patch, or do you plan to apply it after release?
> > >
> > > Thanks!
> >
> > Any issues?
> 
> I think it's better to have this patch rebased on top of Simon's
> bdinfo clean-up series.
> http://patchwork.ozlabs.org/project/uboot/list/?series=176007

Yes, if Simon's series doesn't already address this problem, it should.
Heiko Schocher May 19, 2020, 4:04 a.m. UTC | #6
Hello Tom, Bin,

Am 18.05.2020 um 17:17 schrieb Tom Rini:
> On Mon, May 18, 2020 at 01:42:32PM +0800, Bin Meng wrote:
>> Hi Heiko,
>>
>> On Mon, May 18, 2020 at 12:28 PM Heiko Schocher <hs@denx.de> wrote:
>>>
>>> Hello Tom,
>>>
>>> Am 09.04.2020 um 07:14 schrieb Heiko Schocher:
>>>> Hello Tom,
>>>>
>>>> Am 19.02.2020 um 06:19 schrieb Heiko Schocher:
>>>>> PowerPC target supports OF booting, so print the
>>>>> fdt address and size in bdinfo.
>>>>>
>>>>> Signed-off-by: Heiko Schocher <hs@denx.de>
>>>>> ---
>>>>> Travis build:
>>>>> https://travis-ci.org/hsdenx/u-boot-test/builds/651885430
>>>>>
>>>>>    cmd/bdinfo.c | 3 +++
>>>>>    1 file changed, 3 insertions(+)
>>>>
>>>> Any issues with this patch, or do you plan to apply it after release?
>>>>
>>>> Thanks!
>>>
>>> Any issues?
>>
>> I think it's better to have this patch rebased on top of Simon's
>> bdinfo clean-up series.
>> http://patchwork.ozlabs.org/project/uboot/list/?series=176007
> 
> Yes, if Simon's series doesn't already address this problem, it should.

Yep, I send a new patch (if necessary) after Simons patches are merged.

bye,
Heiko
diff mbox series

Patch

diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c
index d6a7175b37..42b0f49b1a 100644
--- a/cmd/bdinfo.c
+++ b/cmd/bdinfo.c
@@ -208,6 +208,9 @@  int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	print_baudrate();
 	print_num("relocaddr", gd->relocaddr);
 	board_detail();
+	print_num("fdt_blob", (ulong)gd->fdt_blob);
+	print_num("new_fdt", (ulong)gd->new_fdt);
+	print_num("fdt_size", (ulong)gd->fdt_size);
 	return 0;
 }