From patchwork Mon Feb 10 22:56:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rini X-Patchwork-Id: 1236031 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256 header.s=google header.b=WdsO1J/0; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48Gh9k5zlzz9sP7 for ; Tue, 11 Feb 2020 09:56:55 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 379A880367; Mon, 10 Feb 2020 23:56:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="WdsO1J/0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6C27C8037B; Mon, 10 Feb 2020 23:56:41 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-yb1-xb44.google.com (mail-yb1-xb44.google.com [IPv6:2607:f8b0:4864:20::b44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4360A80227 for ; Mon, 10 Feb 2020 23:56:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yb1-xb44.google.com with SMTP id x191so4405899ybg.12 for ; Mon, 10 Feb 2020 14:56:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=WPCWw/nPzRP+lrU4nDoErNHLw4tDOY5CleAGQAC+UpI=; b=WdsO1J/0GJHF4zf2y1D3JvhZFY9xYM1AAqjMbqeYd0BrIQxcgZI2UC9ycMJdkOui2F htxBVOEligmjVb3Y5N1oUyB2JgwybaZZauSAsKqlG8PonB79xvdZWQFVfQ7w3LEMV9Lr +oAXZbgPDiuwiphFCXya5sMTTQDNMHrJQ+ido= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=WPCWw/nPzRP+lrU4nDoErNHLw4tDOY5CleAGQAC+UpI=; b=iswwLzNgCO205wF0UQvDrjvyCA3cbPz1l5C/lmVcYKs8ygHReowvx1Szzd+080W9JZ AtI3gVm9xeN+UURDdE73fk/t4ELgMZcCAqJtHgDPqj5Cao5P2jnr31Zufdy1tAm2C50e 1YA87UoWQyX+DV6MED/LTHdRHC0ynsf2nhghMgeUgCCVIme2k1HERaHQF0QExmPIZWwN S5t+d5Mey50uAvUz0gY3whuf8kk0KHQGs1HP9VmfUM8oKY8BE1XwpSpisa9kTYpsHRTh tbQgexmpDrnKORbigKrRfADnUz44MSiYkgcs+kwLNluz8R2ZaAMFy5untD7am5qUIdsQ w+vg== X-Gm-Message-State: APjAAAWLrCghtgK7vUY0myM56maq9iSti7s5oPlYKDvdMCILW/Ex2EJo y4teQUvLtTwb5PEDsxciGCo0VwtOXG1Feg== X-Google-Smtp-Source: APXvYqxzYQL4AYUNpYYLjR/85p6WfFCmIZOQHPa+H+yIv2RHqtiSVfsYsIRAluzWyqT5JbywNNxzbg== X-Received: by 2002:a25:6b0b:: with SMTP id g11mr3437747ybc.358.1581375396548; Mon, 10 Feb 2020 14:56:36 -0800 (PST) Received: from bill-the-cat (2606-a000-1401-86dd-8802-c84a-5d7b-9391.inf6.spectrum.com. [2606:a000:1401:86dd:8802:c84a:5d7b:9391]) by smtp.gmail.com with ESMTPSA id t3sm1001407ywi.18.2020.02.10.14.56.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Feb 2020 14:56:34 -0800 (PST) Date: Mon, 10 Feb 2020 17:56:31 -0500 From: Tom Rini To: u-boot@lists.denx.de Subject: PCI / PCIe related dts issues Message-ID: <20200210225631.GZ13379@bill-the-cat> MIME-Version: 1.0 Content-Disposition: inline X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.26 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Opaniuk , liuhao , Lucas Stach , Stephen Warren , Marcel Ziswiler , Vitaly Andrianov , Allen Martin , Tom Warren , Silvio Fricke , shuyiqi , Alban Bedel Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.1 at phobos.denx.de X-Virus-Status: Clean Hey all, I'm sending this message to folks that are listed as maintainer for a platform that has some PCI / PCIe related DTS problems. These problems can be seen if you apply the following patch: And as these are also warnings that are normally visible in Linux. you may just need to re-sync your dts files. Thanks! diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn index da6df1429fb8..07c65f170b82 100644 --- a/scripts/Makefile.extrawarn +++ b/scripts/Makefile.extrawarn @@ -71,8 +71,6 @@ else ifeq ($(findstring 1,$(KBUILD_ENABLE_EXTRA_GCC_CHECKS)),) DTC_FLAGS += -Wno-unit_address_vs_reg DTC_FLAGS += -Wno-unit_address_format -DTC_FLAGS += -Wno-pci_bridge -DTC_FLAGS += -Wno-pci_device_bus_num DTC_FLAGS += -Wno-pci_device_reg DTC_FLAGS += -Wno-avoid_unnecessary_addr_size DTC_FLAGS += -Wno-alias_paths Doing this would bring us slightly closer to being in-line with current Linux-kernel kbuild files, is why I bring this up. A way to fix this on sandbox for example, which also has this problem is: diff --git a/arch/sandbox/dts/sandbox.dts b/arch/sandbox/dts/sandbox.dts index 4dd82f6a32fd..2d7db0249ebe 100644 --- a/arch/sandbox/dts/sandbox.dts +++ b/arch/sandbox/dts/sandbox.dts @@ -10,7 +10,7 @@ aliases { i2c0 = &i2c_0; - pci0 = &pci; + pci0 = &pcic; rtc0 = &rtc_0; axi0 = &axi; spi0 = &spi; @@ -52,9 +52,10 @@ pinctrl-0 = <&pinctrl_i2c0>; }; - pci: pci-controller { + pcic: pci@0 { compatible = "sandbox,pci"; device_type = "pci"; + bus-range = <0x00 0xff>; #address-cells = <3>; #size-cells = <2>; ranges = <0x02000000 0 0x10000000 0x10000000 0 0x2000 diff --git a/arch/sandbox/dts/sandbox.dtsi b/arch/sandbox/dts/sandbox.dtsi index 7bf144f53265..f7f3de784292 100644 --- a/arch/sandbox/dts/sandbox.dtsi +++ b/arch/sandbox/dts/sandbox.dtsi @@ -99,7 +99,7 @@ }; }; - pci-controller { + pci@0 { pci@1e,0 { compatible = "sandbox,pmc"; reg = <0xf000 0 0 0 0>; diff --git a/arch/sandbox/dts/sandbox64.dts b/arch/sandbox/dts/sandbox64.dts index 5c95cee9d7a9..97e33f110eef 100644 --- a/arch/sandbox/dts/sandbox64.dts +++ b/arch/sandbox/dts/sandbox64.dts @@ -10,7 +10,7 @@ aliases { i2c0 = &i2c_0; - pci0 = &pci; + pci0 = &pcic; rtc0 = &rtc_0; axi0 = &axi; spi0 = &spi; @@ -47,9 +47,10 @@ pinctrl-0 = <&pinctrl_i2c0>; }; - pci: pci-controller { + pcic: pci@0 { compatible = "sandbox,pci"; device_type = "pci"; + bus-range = <0x00 0xff>; #address-cells = <3>; #size-cells = <2>; ranges = <0x02000000 0 0x10000000 0 0x10000000 0 0x2000 diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts index c22844743143..4d3c42077858 100644 --- a/arch/sandbox/dts/test.dts +++ b/arch/sandbox/dts/test.dts @@ -463,9 +463,10 @@ compatible = "sandbox,pch"; }; - pci0: pci-controller0 { + pci0: pci@0 { compatible = "sandbox,pci"; device_type = "pci"; + bus-range = <0x00 0xff>; #address-cells = <3>; #size-cells = <2>; ranges = <0x02000000 0 0x10000000 0x10000000 0 0x2000000 @@ -531,9 +532,10 @@ }; }; - pci1: pci-controller1 { + pci1: pci@1 { compatible = "sandbox,pci"; device_type = "pci"; + bus-range = <0x00 0xff>; #address-cells = <3>; #size-cells = <2>; ranges = <0x02000000 0 0x30000000 0x30000000 0 0x2000 @@ -546,9 +548,10 @@ }; }; - pci2: pci-controller2 { + pci2: pci@2 { compatible = "sandbox,pci"; device_type = "pci"; + bus-range = <0x00 0xff>; #address-cells = <3>; #size-cells = <2>; ranges = <0x02000000 0 0x50000000 0x50000000 0 0x2000