diff mbox series

[U-Boot,1/5] Revert "powerpc: mpc85xx: delete FSL_SATA for T2080QDS board."

Message ID 20191127100145.44346-1-peng.ma@nxp.com
State Superseded
Delegated to: Priyanka Jain
Headers show
Series [U-Boot,1/5] Revert "powerpc: mpc85xx: delete FSL_SATA for T2080QDS board." | expand

Commit Message

Peng Ma Nov. 27, 2019, 10:02 a.m. UTC
This reverts commit 856b9cdb53f0e6c8d98f81cf71ef363c16b0aa0e.

Signed-off-by: Peng Ma <peng.ma@nxp.com>
---
 arch/powerpc/cpu/mpc85xx/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Wolfgang Denk Nov. 27, 2019, 4:07 p.m. UTC | #1
Dear Peng Ma,

In message <20191127100145.44346-1-peng.ma@nxp.com> you wrote:
> This reverts commit 856b9cdb53f0e6c8d98f81cf71ef363c16b0aa0e.
>
> Signed-off-by: Peng Ma <peng.ma@nxp.com>

Why?

A commit message should always explain why such an action is taking
place.

Best regards,

Wolfgang Denk
Peng Ma Nov. 28, 2019, 2:39 a.m. UTC | #2
>-----Original Message-----
>From: Wolfgang Denk <wd@denx.de>
>Sent: 2019年11月28日 0:08
>To: Peng Ma <peng.ma@nxp.com>
>Cc: Priyanka Jain <priyanka.jain@nxp.com>; Ruchika Gupta
><ruchika.gupta@nxp.com>; Shengzhou Liu <shengzhou.liu@nxp.com>; Yinbo
>Zhu <yinbo.zhu@nxp.com>; Z.q. Hou <zhiqiang.hou@nxp.com>;
>sjg@chromium.org; jagan@openedev.com; andre.przywara@arm.com;
>sr@denx.de; smoch@web.de; Andy Tang <andy.tang@nxp.com>;
>u-boot@lists.denx.de
>Subject: [EXT] Re: [PATCH 1/5] Revert "powerpc: mpc85xx: delete FSL_SATA for
>T2080QDS board."
>
>Caution: EXT Email
>
>Dear Peng Ma,
>
>In message <20191127100145.44346-1-peng.ma@nxp.com> you wrote:
>> This reverts commit 856b9cdb53f0e6c8d98f81cf71ef363c16b0aa0e.
>>
>> Signed-off-by: Peng Ma <peng.ma@nxp.com>
>
>Why?
>
>A commit message should always explain why such an action is taking place.
>
Hi, Wolfgang,

I am so sorry to send these series patches(revert patches not to explain why), I will refresh them and send V2.

Best Regards,
Peng	 

>Best regards,
>
>Wolfgang Denk
>
>--
>DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
>HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
>The high cost of living hasn't affected its popularity.
diff mbox series

Patch

diff --git a/arch/powerpc/cpu/mpc85xx/Kconfig b/arch/powerpc/cpu/mpc85xx/Kconfig
index 8cc82f80b4..6fc6ea8fef 100644
--- a/arch/powerpc/cpu/mpc85xx/Kconfig
+++ b/arch/powerpc/cpu/mpc85xx/Kconfig
@@ -352,6 +352,7 @@  config TARGET_T2080QDS
 	select PHYS_64BIT
 	select FSL_DDR_FIRST_SLOT_QUAD_CAPABLE
 	select FSL_DDR_INTERACTIVE
+	imply CMD_SATA
 
 config TARGET_T2080RDB
 	bool "Support T2080RDB"
@@ -360,7 +361,6 @@  config TARGET_T2080RDB
 	select SUPPORT_SPL
 	select PHYS_64BIT
 	imply CMD_SATA
-	imply FSL_SATA
 	imply PANIC_HANG
 
 config TARGET_T2081QDS
@@ -1099,8 +1099,10 @@  config ARCH_T2080
 	select SYS_FSL_SEC_COMPAT_4
 	select SYS_PPC64
 	select FSL_IFC
+	imply CMD_SATA
 	imply CMD_NAND
 	imply CMD_REGINFO
+	imply FSL_SATA
 
 config ARCH_T2081
 	bool