From patchwork Tue Nov 26 00:51:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AKASHI Takahiro X-Patchwork-Id: 1200698 X-Patchwork-Delegate: xypron.glpk@gmx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="ZdQ/98lJ"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 47MQZ66JMcz9sPV for ; Tue, 26 Nov 2019 12:00:46 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 7518CC21E63; Tue, 26 Nov 2019 00:58:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 6987FC21E07; Tue, 26 Nov 2019 00:53:22 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id CC5FDC21EC8; Tue, 26 Nov 2019 00:51:12 +0000 (UTC) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by lists.denx.de (Postfix) with ESMTPS id 7B029C21D9A for ; Tue, 26 Nov 2019 00:51:05 +0000 (UTC) Received: by mail-pf1-f196.google.com with SMTP id z4so8259359pfn.12 for ; Mon, 25 Nov 2019 16:51:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HayICzzsx87HHZXT8BNgrL0JMhk/uqSDY5FT/MLk+mk=; b=ZdQ/98lJlyiFw7iyvKpmQ/i4u6pt/5eBnNpL/0imLVLCgpb4+cCifNdhjXWJKFkr4c YIBMBa0ZDlQR4HhZJYVMxH6VJFyemIgiyi+BEKlypF+ztnKBBkrbWanLofOj4Fr/JLKP EOC+Ty/ZjBH/IO0fz+FAqiEs++VfVfmPYf6fIphaD3+JUb5yeViiuF9pp1PmA1Uiu3mf LSXo5SpgOkSfpOcbBI4HXXtFPbWzbBca38GE36u0STTroPZJ7wvWAcPBHnSg4dr2knah xPAxBxU1K8n45dzzTflxNcqWJVfqEStWgEtRKjbPnNRyRKq7sdMzi8tWOAO0xPcECL62 N32g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HayICzzsx87HHZXT8BNgrL0JMhk/uqSDY5FT/MLk+mk=; b=E6PEktQSyRzCbmToj3bs+fEknxY92bqlL+UFHwfQVnrHELdB58fKDiXDFCrJWvqBRi fW75upQoqJvTifbZPNFzqiIgdHgyJQfYqCsfuF3LjdrTCUomwbhINFrTFAdG02KJ7qcC loOpRE+I6UuBOKmpPZtMVjg1325x3KL2I7f44J1fJkhdmMvYKrth4R0CZJ8WsG6HUrUW lcySQcfHz/OHfAguBnKSZ8PbDWN/BNUSLEXbetu5byMnb/0+hIgKFOSAC4u2du+OLToZ RPOyUParjSh+8LZNnCzhu5zH4QbNuaFt4WFC6m7Z6GfY1avLXJWpjYKDgMzoBBqrpV4p 7ClQ== X-Gm-Message-State: APjAAAWzQC7XzlClSHCOyhcubRrTFD0DsUcWMGrw74YCZySu4/it8Yn6 Yt33toHe/CJQfZOmb2mt192hqw== X-Google-Smtp-Source: APXvYqxZ3vMGCqnFCT/+CrPlYTptTCW9WIQUzosoCJ8ZH448+qy1Klv/BfrBhlv6MCU/icfOHo9E/Q== X-Received: by 2002:a63:e647:: with SMTP id p7mr36253317pgj.47.1574729464107; Mon, 25 Nov 2019 16:51:04 -0800 (PST) Received: from linaro.org ([121.95.100.191]) by smtp.googlemail.com with ESMTPSA id e8sm9877204pga.17.2019.11.25.16.51.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Nov 2019 16:51:03 -0800 (PST) From: AKASHI Takahiro To: xypron.glpk@gmx.de, agraf@csgraf.de, trini@konsulko.com Date: Tue, 26 Nov 2019 09:51:15 +0900 Message-Id: <20191126005120.31156-12-takahiro.akashi@linaro.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191126005120.31156-1-takahiro.akashi@linaro.org> References: <20191126005120.31156-1-takahiro.akashi@linaro.org> MIME-Version: 1.0 Cc: u-boot@lists.denx.de, mail@patrick-wildt.de Subject: [U-Boot] [PATCH v2 11/16] cmd: env: add "-at" option to "env set -e" command X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" With "-at" option, EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS will be passed to SetVariable() to authenticate the variable. Signed-off-by: AKASHI Takahiro --- cmd/nvedit.c | 5 +++-- cmd/nvedit_efi.c | 5 ++++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/cmd/nvedit.c b/cmd/nvedit.c index 99a3bc57b15f..30cd655b7260 100644 --- a/cmd/nvedit.c +++ b/cmd/nvedit.c @@ -1399,7 +1399,7 @@ static char env_help_text[] = #endif #endif #if defined(CONFIG_CMD_NVEDIT_EFI) - "env set -e [-nv][-bs][-rt][-a][-i addr,size][-v] name [arg ...]\n" + "env set -e [-nv][-bs][-rt][-at][-a][-i addr,size][-v] name [arg ...]\n" " - set UEFI variable; unset if '-i' or 'arg' not specified\n" #endif "env set [-f] name [arg ...]\n"; @@ -1461,13 +1461,14 @@ U_BOOT_CMD_COMPLETE( setenv, CONFIG_SYS_MAXARGS, 0, do_env_set, "set environment variables", #if defined(CONFIG_CMD_NVEDIT_EFI) - "-e [-guid guid][-nv][-bs][-rt][-a][-v]\n" + "-e [-guid guid][-nv][-bs][-rt][-at][-a][-v]\n" " [-i addr,size name], or [name [value ...]]\n" " - set UEFI variable 'name' to 'value' ...'\n" " \"-guid\": set vendor guid\n" " \"-nv\": set non-volatile attribute\n" " \"-bs\": set boot-service attribute\n" " \"-rt\": set runtime attribute\n" + " \"-at\": set time-based authentication attribute\n" " \"-a\": append-write\n" " \"-i addr,size\": use as variable's value\n" " \"-v\": verbose message\n" diff --git a/cmd/nvedit_efi.c b/cmd/nvedit_efi.c index 579cf430593c..837e39e02179 100644 --- a/cmd/nvedit_efi.c +++ b/cmd/nvedit_efi.c @@ -458,7 +458,7 @@ out: * Return: CMD_RET_SUCCESS on success, or CMD_RET_RET_FAILURE * * This function is for "env set -e" or "setenv -e" command: - * => env set -e [-guid guid][-nv][-bs][-rt][-a][-v] + * => env set -e [-guid guid][-nv][-bs][-rt][-at][-a][-v] * [-i address,size] var, or * var [value ...] * Encode values specified and set given UEFI variable. @@ -517,6 +517,9 @@ int do_env_set_efi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) attributes |= EFI_VARIABLE_RUNTIME_ACCESS; } else if (!strcmp(argv[0], "-nv")) { attributes |= EFI_VARIABLE_NON_VOLATILE; + } else if (!strcmp(argv[0], "-at")) { + attributes |= + EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS; } else if (!strcmp(argv[0], "-a")) { attributes |= EFI_VARIABLE_APPEND_WRITE; } else if (!strcmp(argv[0], "-i")) {