From patchwork Sat Oct 26 00:26:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Walle X-Patchwork-Id: 1184508 X-Patchwork-Delegate: joe.hershberger@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=walle.cc header.i=@walle.cc header.b="g+Dmu4hw"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 470MKH4sZHz9sPc for ; Sat, 26 Oct 2019 11:28:35 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 58237C21E44; Sat, 26 Oct 2019 00:27:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id BB2D5C21EA1; Sat, 26 Oct 2019 00:27:16 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 1F971C21E02; Sat, 26 Oct 2019 00:27:14 +0000 (UTC) Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) by lists.denx.de (Postfix) with ESMTPS id F1493C21C51 for ; Sat, 26 Oct 2019 00:27:13 +0000 (UTC) Received: from apollo.fritz.box (unknown [IPv6:2a02:810c:c200:2e91:6257:18ff:fec4:ca34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id A6CF522F43; Sat, 26 Oct 2019 02:27:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1572049633; bh=+6+enxeILcD363+dk1DeJEUJFDYxtFl8g3wF8fOZNQU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g+Dmu4hwhhi1d9kYXdqK98t4Boh2fEVtbNQX9iJH2YY3gTcVLKAa2Rtb71x4UhQlG BUXx2NG02fWpFNOplfMeiHnXrBlRx/YgNS+pguENr0/wBZf/1NKVFHst1SGgNtOahv n1oQHu5DN3AJEAXU7OubOOTAe6sfYg++THLyzNuE= From: Michael Walle To: u-boot@lists.denx.de Date: Sat, 26 Oct 2019 02:26:24 +0200 Message-Id: <20191026002630.25865-4-michael@walle.cc> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191026002630.25865-1-michael@walle.cc> References: <20191026002630.25865-1-michael@walle.cc> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.101.4 at web X-Virus-Status: Clean Subject: [U-Boot] [PATCH 3/9] phy: atheros: ar8035: remove extra delay config X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Remove the hard-coded delay configuration. The AR8035 config() always enabled the TX delay mode, although it will be set according to the PHY interface mode, too. If bisecting shows that this commit breaks your board you probably have a wrong PHY interface mode. You probably want the PHY_INTERFACE_MODE_RGMII_TXID or PHY_INTERFACE_MODE_RGMII_ID mode. Signed-off-by: Michael Walle Acked-by: Joe Hershberger --- drivers/net/phy/atheros.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index 402998c8d5..629c6b192a 100644 --- a/drivers/net/phy/atheros.c +++ b/drivers/net/phy/atheros.c @@ -118,9 +118,6 @@ static int ar8035_config(struct phy_device *phydev) regval = phy_read(phydev, MDIO_DEVAD_NONE, 0xe); phy_write(phydev, MDIO_DEVAD_NONE, 0xe, (regval|0x0018)); - ar803x_debug_reg_mask(phydev, AR803x_DEBUG_REG_5, - 0, AR803x_RGMII_TX_CLK_DLY); - ret = ar803x_delay_config(phydev); if (ret < 0) return ret;