diff mbox series

[U-Boot,v2,16/17] test: add lib specific Kconfig

Message ID 20191025100749.16165-17-takahiro.akashi@linaro.org
State Superseded
Delegated to: Tom Rini
Headers show
Series import x509/pkcs7 parsers from linux | expand

Commit Message

Takahiro Akashi Oct. 25, 2019, 10:07 a.m. UTC
Adding new unit tests for library routines will make test/Kconfig
messy. So just create a Kconfig file under lib.

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
---
 test/Kconfig     | 8 +-------
 test/lib/Kconfig | 7 +++++++
 2 files changed, 8 insertions(+), 7 deletions(-)
 create mode 100644 test/lib/Kconfig

Comments

Tom Rini Oct. 25, 2019, 4:07 p.m. UTC | #1
On Fri, Oct 25, 2019 at 07:07:48PM +0900, AKASHI Takahiro wrote:
> Adding new unit tests for library routines will make test/Kconfig
> messy. So just create a Kconfig file under lib.
> 
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
>  test/Kconfig     | 8 +-------
>  test/lib/Kconfig | 7 +++++++
>  2 files changed, 8 insertions(+), 7 deletions(-)
>  create mode 100644 test/lib/Kconfig
> 
> diff --git a/test/Kconfig b/test/Kconfig
> index 48a0e501f88f..3a5aabedd0ef 100644
> --- a/test/Kconfig
> +++ b/test/Kconfig
> @@ -6,13 +6,7 @@ menuconfig UNIT_TEST
>  	  This does not require sandbox to be included, but it is most
>  	  often used there.
>  
> -config UT_LIB
> -	bool "Unit tests for library functions"
> -	depends on UNIT_TEST
> -	default y
> -	help
> -	  Enables the 'ut lib' command which tests library functions like
> -	  memcat(), memcyp(), memmove().
> +source "test/lib/Kconfig"
>  
>  config UT_TIME
>  	bool "Unit tests for time functions"
> diff --git a/test/lib/Kconfig b/test/lib/Kconfig
> new file mode 100644
> index 000000000000..a983bdcaa3f1
> --- /dev/null
> +++ b/test/lib/Kconfig
> @@ -0,0 +1,7 @@
> +config UT_LIB
> +	bool "Unit tests for library functions"
> +	depends on UNIT_TEST
> +	default y
> +	help
> +	  Enables the 'ut lib' command which tests library functions like
> +	  memcat(), memcyp(), memmove().

But we then only add one more entry in the next patch.  How many library
tests do you see adding when everything is done?  If it's less than 5,
we should just keep things in the test/Kconfig file I think.  The rest
of the series seems fine, thanks!
Takahiro Akashi Oct. 28, 2019, 12:26 a.m. UTC | #2
Tom,

On Fri, Oct 25, 2019 at 12:07:30PM -0400, Tom Rini wrote:
> On Fri, Oct 25, 2019 at 07:07:48PM +0900, AKASHI Takahiro wrote:
> > Adding new unit tests for library routines will make test/Kconfig
> > messy. So just create a Kconfig file under lib.
> > 
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > ---
> >  test/Kconfig     | 8 +-------
> >  test/lib/Kconfig | 7 +++++++
> >  2 files changed, 8 insertions(+), 7 deletions(-)
> >  create mode 100644 test/lib/Kconfig
> > 
> > diff --git a/test/Kconfig b/test/Kconfig
> > index 48a0e501f88f..3a5aabedd0ef 100644
> > --- a/test/Kconfig
> > +++ b/test/Kconfig
> > @@ -6,13 +6,7 @@ menuconfig UNIT_TEST
> >  	  This does not require sandbox to be included, but it is most
> >  	  often used there.
> >  
> > -config UT_LIB
> > -	bool "Unit tests for library functions"
> > -	depends on UNIT_TEST
> > -	default y
> > -	help
> > -	  Enables the 'ut lib' command which tests library functions like
> > -	  memcat(), memcyp(), memmove().
> > +source "test/lib/Kconfig"
> >  
> >  config UT_TIME
> >  	bool "Unit tests for time functions"
> > diff --git a/test/lib/Kconfig b/test/lib/Kconfig
> > new file mode 100644
> > index 000000000000..a983bdcaa3f1
> > --- /dev/null
> > +++ b/test/lib/Kconfig
> > @@ -0,0 +1,7 @@
> > +config UT_LIB
> > +	bool "Unit tests for library functions"
> > +	depends on UNIT_TEST
> > +	default y
> > +	help
> > +	  Enables the 'ut lib' command which tests library functions like
> > +	  memcat(), memcyp(), memmove().
> 
> But we then only add one more entry in the next patch.  How many library
> tests do you see adding when everything is done?

Only this one.

> If it's less than 5,
> we should just keep things in the test/Kconfig file I think.  The rest
> of the series seems fine, thanks!

As you know, there are bunch of library functions which are NOT
tested by "ut". I would expect that more and more tests should come
as someone modify any of libraries functions.

But I don't have a strong opinion here and will follow your suggestion.

-Takahiro Akashi


> -- 
> Tom
diff mbox series

Patch

diff --git a/test/Kconfig b/test/Kconfig
index 48a0e501f88f..3a5aabedd0ef 100644
--- a/test/Kconfig
+++ b/test/Kconfig
@@ -6,13 +6,7 @@  menuconfig UNIT_TEST
 	  This does not require sandbox to be included, but it is most
 	  often used there.
 
-config UT_LIB
-	bool "Unit tests for library functions"
-	depends on UNIT_TEST
-	default y
-	help
-	  Enables the 'ut lib' command which tests library functions like
-	  memcat(), memcyp(), memmove().
+source "test/lib/Kconfig"
 
 config UT_TIME
 	bool "Unit tests for time functions"
diff --git a/test/lib/Kconfig b/test/lib/Kconfig
new file mode 100644
index 000000000000..a983bdcaa3f1
--- /dev/null
+++ b/test/lib/Kconfig
@@ -0,0 +1,7 @@ 
+config UT_LIB
+	bool "Unit tests for library functions"
+	depends on UNIT_TEST
+	default y
+	help
+	  Enables the 'ut lib' command which tests library functions like
+	  memcat(), memcyp(), memmove().