| Message ID | 20190912091256.15573-2-marcel@ziswiler.com |
|---|---|
| State | Accepted |
| Commit | bfe682e9ddbd8d13903f5e51452d8bff07706f85 |
| Delegated to: | Tom Warren |
| Headers | show |
| Series | apalis/colibri_t30: uart pinmuxing improvements | expand |
On Thu, Sep 12, 2019 at 12:13 PM Marcel Ziswiler <marcel@ziswiler.com> wrote: > > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > Add pinmuxing comment stating that TRISTATE means the output driver is > tri-stated and INPUT means the input driver is enabled vs. OUTPUT where > it is disabled. > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > --- > > board/toradex/apalis_t30/pinmux-config-apalis_t30.h | 2 ++ > board/toradex/colibri_t30/pinmux-config-colibri_t30.h | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/board/toradex/apalis_t30/pinmux-config-apalis_t30.h b/board/toradex/apalis_t30/pinmux-config-apalis_t30.h > index 49c2df7ab2..8d6696aaad 100644 > --- a/board/toradex/apalis_t30/pinmux-config-apalis_t30.h > +++ b/board/toradex/apalis_t30/pinmux-config-apalis_t30.h > @@ -11,7 +11,9 @@ > .pingrp = PMUX_PINGRP_##_pingrp, \ > .func = PMUX_FUNC_##_mux, \ > .pull = PMUX_PULL_##_pull, \ > +/* TRISTATE here means output driver is tri-stated */ \ > .tristate = PMUX_TRI_##_tri, \ > +/* INPUT here means input driver is enabled vs. OUTPUT where it is disabled */ \ > .io = PMUX_PIN_##_io, \ > .lock = PMUX_PIN_LOCK_DEFAULT, \ > .od = PMUX_PIN_OD_DEFAULT, \ > diff --git a/board/toradex/colibri_t30/pinmux-config-colibri_t30.h b/board/toradex/colibri_t30/pinmux-config-colibri_t30.h > index bdbbf5e49a..6181b506a4 100644 > --- a/board/toradex/colibri_t30/pinmux-config-colibri_t30.h > +++ b/board/toradex/colibri_t30/pinmux-config-colibri_t30.h > @@ -11,7 +11,9 @@ > .pingrp = PMUX_PINGRP_##_pingrp, \ > .func = PMUX_FUNC_##_mux, \ > .pull = PMUX_PULL_##_pull, \ > +/* TRISTATE here means output driver is tri-stated */ \ > .tristate = PMUX_TRI_##_tri, \ > +/* INPUT here means input driver is enabled vs. OUTPUT where it is disabled */ \ > .io = PMUX_PIN_##_io, \ > .lock = PMUX_PIN_LOCK_DEFAULT, \ > .od = PMUX_PIN_OD_DEFAULT, \ > -- > 2.21.0 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot Reviewed-by: Igor Opaniuk <igor.opaniuk@toradex.com>
diff --git a/board/toradex/apalis_t30/pinmux-config-apalis_t30.h b/board/toradex/apalis_t30/pinmux-config-apalis_t30.h index 49c2df7ab2..8d6696aaad 100644 --- a/board/toradex/apalis_t30/pinmux-config-apalis_t30.h +++ b/board/toradex/apalis_t30/pinmux-config-apalis_t30.h @@ -11,7 +11,9 @@ .pingrp = PMUX_PINGRP_##_pingrp, \ .func = PMUX_FUNC_##_mux, \ .pull = PMUX_PULL_##_pull, \ +/* TRISTATE here means output driver is tri-stated */ \ .tristate = PMUX_TRI_##_tri, \ +/* INPUT here means input driver is enabled vs. OUTPUT where it is disabled */ \ .io = PMUX_PIN_##_io, \ .lock = PMUX_PIN_LOCK_DEFAULT, \ .od = PMUX_PIN_OD_DEFAULT, \ diff --git a/board/toradex/colibri_t30/pinmux-config-colibri_t30.h b/board/toradex/colibri_t30/pinmux-config-colibri_t30.h index bdbbf5e49a..6181b506a4 100644 --- a/board/toradex/colibri_t30/pinmux-config-colibri_t30.h +++ b/board/toradex/colibri_t30/pinmux-config-colibri_t30.h @@ -11,7 +11,9 @@ .pingrp = PMUX_PINGRP_##_pingrp, \ .func = PMUX_FUNC_##_mux, \ .pull = PMUX_PULL_##_pull, \ +/* TRISTATE here means output driver is tri-stated */ \ .tristate = PMUX_TRI_##_tri, \ +/* INPUT here means input driver is enabled vs. OUTPUT where it is disabled */ \ .io = PMUX_PIN_##_io, \ .lock = PMUX_PIN_LOCK_DEFAULT, \ .od = PMUX_PIN_OD_DEFAULT, \