diff mbox series

[U-Boot,v4,2/2] part: always enable part_get_info_ptr() for driver

Message ID 20190815083217.476-2-kever.yang@rock-chips.com
State New
Delegated to: Tom Rini
Headers show
Series [U-Boot,v4,1/2] disk: update to use SPL_PARTITIONS for SPL | expand

Commit Message

Kever Yang Aug. 15, 2019, 8:32 a.m. UTC
The partition driver has its Kconfig option, and the part_get_info_prt()
interface are mendatory interface for partition drivers, always enable the
macro to make partition driver works correctly.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

Changes in v4:
- formate commit message to ~75 columns

Changes in v3: None
Changes in v2:
- add patch to use SPL_PARTITIONS so that we don't add disk driver for
  boards who don't need it.

 include/part.h | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

Comments

Kever Yang Nov. 28, 2019, 3:09 a.m. UTC | #1
Hi Tom, Simon,

  Is there anything I need to update for this patch?

Thanks,
- Kever

Kever Yang <kever.yang@rock-chips.com> 于2019年8月15日周四 下午4:32写道:

> The partition driver has its Kconfig option, and the part_get_info_prt()
> interface are mendatory interface for partition drivers, always enable the
> macro to make partition driver works correctly.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> Changes in v4:
> - formate commit message to ~75 columns
>
> Changes in v3: None
> Changes in v2:
> - add patch to use SPL_PARTITIONS so that we don't add disk driver for
>   boards who don't need it.
>
>  include/part.h | 11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/include/part.h b/include/part.h
> index ebca546db5..7d00fae56f 100644
> --- a/include/part.h
> +++ b/include/part.h
> @@ -241,22 +241,15 @@ static inline int blk_get_device_part_str(const char
> *ifname,
>  #endif
>
>  /*
> - * We don't support printing partition information in SPL and only support
> - * getting partition information in a few cases.
> + * We don't support printing partition information in SPL
>   */
>  #ifdef CONFIG_SPL_BUILD
>  # define part_print_ptr(x)     NULL
> -# if defined(CONFIG_SPL_FS_EXT4) || defined(CONFIG_SPL_FS_FAT) || \
> -       defined(CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION)
> -#  define part_get_info_ptr(x) x
> -# else
> -#  define part_get_info_ptr(x) NULL
> -# endif
>  #else
>  #define part_print_ptr(x)      x
> -#define part_get_info_ptr(x)   x
>  #endif
>
> +#define part_get_info_ptr(x)   x
>
>  struct part_driver {
>         const char *name;
> --
> 2.17.1
>
>
diff mbox series

Patch

diff --git a/include/part.h b/include/part.h
index ebca546db5..7d00fae56f 100644
--- a/include/part.h
+++ b/include/part.h
@@ -241,22 +241,15 @@  static inline int blk_get_device_part_str(const char *ifname,
 #endif
 
 /*
- * We don't support printing partition information in SPL and only support
- * getting partition information in a few cases.
+ * We don't support printing partition information in SPL
  */
 #ifdef CONFIG_SPL_BUILD
 # define part_print_ptr(x)	NULL
-# if defined(CONFIG_SPL_FS_EXT4) || defined(CONFIG_SPL_FS_FAT) || \
-	defined(CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION)
-#  define part_get_info_ptr(x)	x
-# else
-#  define part_get_info_ptr(x)	NULL
-# endif
 #else
 #define part_print_ptr(x)	x
-#define part_get_info_ptr(x)	x
 #endif
 
+#define part_get_info_ptr(x)	x
 
 struct part_driver {
 	const char *name;