diff mbox series

[U-Boot,v6,5/5] configs: am65x_evm_a53: enable networking

Message ID 20190709050037.8239-6-j-keerthy@ti.com
State Accepted
Commit c558c50dbb468656748037af9a9dd900c5d2030d
Delegated to: Joe Hershberger
Headers show
Series net: ethernet: ti: Introduce am654 gigabit eth switch subsystem driver | expand

Commit Message

Keerthy July 9, 2019, 5 a.m. UTC
From: Grygorii Strashko <grygorii.strashko@ti.com>

Enable TI K3 AM65x CPSW NUSS driver.

Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Keerthy <j-keerthy@ti.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
---

Changes in v6:

  * Removed unused HEXDUMP config.
  * Added Joe's Ack.

 configs/am65x_evm_a53_defconfig | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Lokesh Vutla July 9, 2019, 6:30 a.m. UTC | #1
On 09/07/19 10:30 AM, Keerthy wrote:
> From: Grygorii Strashko <grygorii.strashko@ti.com>
> 
> Enable TI K3 AM65x CPSW NUSS driver.
> 
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> ---
> 
> Changes in v6:
> 
>   * Removed unused HEXDUMP config.
>   * Added Joe's Ack.
> 
>  configs/am65x_evm_a53_defconfig | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/configs/am65x_evm_a53_defconfig b/configs/am65x_evm_a53_defconfig
> index 41cf0100fa..b940af3f56 100644
> --- a/configs/am65x_evm_a53_defconfig
> +++ b/configs/am65x_evm_a53_defconfig
> @@ -44,6 +44,7 @@ CONFIG_SPL_MULTI_DTB_FIT_NO_COMPRESSION=y
>  CONFIG_ENV_IS_IN_FAT=y
>  CONFIG_ENV_FAT_INTERFACE="mmc"
>  CONFIG_ENV_FAT_DEVICE_AND_PART="1:1"
> +CONFIG_NET_RANDOM_ETHADDR=y

Do we really need this?


Thanks and regards,
Lokesh

>  CONFIG_DM=y
>  CONFIG_SPL_DM=y
>  CONFIG_SPL_DM_SEQ_ALIAS=y
> @@ -58,6 +59,11 @@ CONFIG_K3_SEC_PROXY=y
>  CONFIG_DM_MMC=y
>  CONFIG_MMC_SDHCI=y
>  CONFIG_MMC_SDHCI_K3_ARASAN=y
> +CONFIG_PHY_TI=y
> +CONFIG_PHY_FIXED=y
> +CONFIG_DM_ETH=y
> +CONFIG_TI_AM65_CPSW_NUSS=y
> +CONFIG_PHY=y
>  CONFIG_PINCTRL=y
>  # CONFIG_PINCTRL_GENERIC is not set
>  CONFIG_SPL_PINCTRL=y
>
Keerthy July 9, 2019, 6:35 a.m. UTC | #2
On 09/07/19 12:00 PM, Lokesh Vutla wrote:
> 
> 
> On 09/07/19 10:30 AM, Keerthy wrote:
>> From: Grygorii Strashko <grygorii.strashko@ti.com>
>>
>> Enable TI K3 AM65x CPSW NUSS driver.
>>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> Reviewed-by: Tom Rini <trini@konsulko.com>
>> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
>> ---
>>
>> Changes in v6:
>>
>>    * Removed unused HEXDUMP config.
>>    * Added Joe's Ack.
>>
>>   configs/am65x_evm_a53_defconfig | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/configs/am65x_evm_a53_defconfig b/configs/am65x_evm_a53_defconfig
>> index 41cf0100fa..b940af3f56 100644
>> --- a/configs/am65x_evm_a53_defconfig
>> +++ b/configs/am65x_evm_a53_defconfig
>> @@ -44,6 +44,7 @@ CONFIG_SPL_MULTI_DTB_FIT_NO_COMPRESSION=y
>>   CONFIG_ENV_IS_IN_FAT=y
>>   CONFIG_ENV_FAT_INTERFACE="mmc"
>>   CONFIG_ENV_FAT_DEVICE_AND_PART="1:1"
>> +CONFIG_NET_RANDOM_ETHADDR=y

Fallback option in case efuse MAC ID read fails for some reason.

> 
> Do we really need this?
> 
> 
> Thanks and regards,
> Lokesh
> 
>>   CONFIG_DM=y
>>   CONFIG_SPL_DM=y
>>   CONFIG_SPL_DM_SEQ_ALIAS=y
>> @@ -58,6 +59,11 @@ CONFIG_K3_SEC_PROXY=y
>>   CONFIG_DM_MMC=y
>>   CONFIG_MMC_SDHCI=y
>>   CONFIG_MMC_SDHCI_K3_ARASAN=y
>> +CONFIG_PHY_TI=y
>> +CONFIG_PHY_FIXED=y
>> +CONFIG_DM_ETH=y
>> +CONFIG_TI_AM65_CPSW_NUSS=y
>> +CONFIG_PHY=y
>>   CONFIG_PINCTRL=y
>>   # CONFIG_PINCTRL_GENERIC is not set
>>   CONFIG_SPL_PINCTRL=y
>>
Lokesh Vutla July 9, 2019, 9 a.m. UTC | #3
On 09/07/19 12:05 PM, Keerthy wrote:
> 
> 
> On 09/07/19 12:00 PM, Lokesh Vutla wrote:
>>
>>
>> On 09/07/19 10:30 AM, Keerthy wrote:
>>> From: Grygorii Strashko <grygorii.strashko@ti.com>
>>>
>>> Enable TI K3 AM65x CPSW NUSS driver.
>>>
>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>> Reviewed-by: Tom Rini <trini@konsulko.com>
>>> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
>>> ---
>>>
>>> Changes in v6:
>>>
>>>    * Removed unused HEXDUMP config.
>>>    * Added Joe's Ack.
>>>
>>>   configs/am65x_evm_a53_defconfig | 6 ++++++
>>>   1 file changed, 6 insertions(+)
>>>
>>> diff --git a/configs/am65x_evm_a53_defconfig b/configs/am65x_evm_a53_defconfig
>>> index 41cf0100fa..b940af3f56 100644
>>> --- a/configs/am65x_evm_a53_defconfig
>>> +++ b/configs/am65x_evm_a53_defconfig
>>> @@ -44,6 +44,7 @@ CONFIG_SPL_MULTI_DTB_FIT_NO_COMPRESSION=y
>>>   CONFIG_ENV_IS_IN_FAT=y
>>>   CONFIG_ENV_FAT_INTERFACE="mmc"
>>>   CONFIG_ENV_FAT_DEVICE_AND_PART="1:1"
>>> +CONFIG_NET_RANDOM_ETHADDR=y
> 
> Fallback option in case efuse MAC ID read fails for some reason.

Ahh I forgot that this is a fallback option.

Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>

Thanks and regards,
Lokesh

> 
>>
>> Do we really need this?
>>
>>
>> Thanks and regards,
>> Lokesh
>>
>>>   CONFIG_DM=y
>>>   CONFIG_SPL_DM=y
>>>   CONFIG_SPL_DM_SEQ_ALIAS=y
>>> @@ -58,6 +59,11 @@ CONFIG_K3_SEC_PROXY=y
>>>   CONFIG_DM_MMC=y
>>>   CONFIG_MMC_SDHCI=y
>>>   CONFIG_MMC_SDHCI_K3_ARASAN=y
>>> +CONFIG_PHY_TI=y
>>> +CONFIG_PHY_FIXED=y
>>> +CONFIG_DM_ETH=y
>>> +CONFIG_TI_AM65_CPSW_NUSS=y
>>> +CONFIG_PHY=y
>>>   CONFIG_PINCTRL=y
>>>   # CONFIG_PINCTRL_GENERIC is not set
>>>   CONFIG_SPL_PINCTRL=y
>>>
Joe Hershberger July 15, 2019, 10:51 p.m. UTC | #4
Hi Keerthy,

https://patchwork.ozlabs.org/patch/1129507/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git

Thanks!
-Joe
diff mbox series

Patch

diff --git a/configs/am65x_evm_a53_defconfig b/configs/am65x_evm_a53_defconfig
index 41cf0100fa..b940af3f56 100644
--- a/configs/am65x_evm_a53_defconfig
+++ b/configs/am65x_evm_a53_defconfig
@@ -44,6 +44,7 @@  CONFIG_SPL_MULTI_DTB_FIT_NO_COMPRESSION=y
 CONFIG_ENV_IS_IN_FAT=y
 CONFIG_ENV_FAT_INTERFACE="mmc"
 CONFIG_ENV_FAT_DEVICE_AND_PART="1:1"
+CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DM=y
 CONFIG_SPL_DM=y
 CONFIG_SPL_DM_SEQ_ALIAS=y
@@ -58,6 +59,11 @@  CONFIG_K3_SEC_PROXY=y
 CONFIG_DM_MMC=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_K3_ARASAN=y
+CONFIG_PHY_TI=y
+CONFIG_PHY_FIXED=y
+CONFIG_DM_ETH=y
+CONFIG_TI_AM65_CPSW_NUSS=y
+CONFIG_PHY=y
 CONFIG_PINCTRL=y
 # CONFIG_PINCTRL_GENERIC is not set
 CONFIG_SPL_PINCTRL=y