From patchwork Fri Jun 21 13:39:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 1120311 X-Patchwork-Delegate: lukma@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="ahPEQXDX"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 45Vg4v0Cy2z9s5c for ; Fri, 21 Jun 2019 23:48:30 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 863D3C21E42; Fri, 21 Jun 2019 13:47:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id BB2FAC21E60; Fri, 21 Jun 2019 13:47:07 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 541B7C21E08; Fri, 21 Jun 2019 13:39:49 +0000 (UTC) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by lists.denx.de (Postfix) with ESMTPS id 1E01BC21E76 for ; Fri, 21 Jun 2019 13:39:49 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20190621133948euoutp013f1991d2d99f7e957194a0f989d2953b~qOlxEG5gO0559705597euoutp01S; Fri, 21 Jun 2019 13:39:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20190621133948euoutp013f1991d2d99f7e957194a0f989d2953b~qOlxEG5gO0559705597euoutp01S DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1561124388; bh=Y767DWWCM2yjEQvsi0wfA66HK6pS4OSMsu2aGttyIyU=; h=From:To:Cc:Subject:Date:References:From; b=ahPEQXDXtsJl+JPj2VrUAp2wxRHbVpj47nrdvXuU1fuo37Fjk4zGr4CU+MnZ/K07x 67dyqrNCkmJAzU5tLor72qLhQP73/LFBn/QPaGqtnJkJfrtmh/KZX37q1+KQHi73eo CBaJHazxwgNidhLIRTvxRPRpBwgbuu3fJ3Zg/chE= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20190621133948eucas1p2b21b018d707c60b4a1d57756ea906d5b~qOlwa71lj1192111921eucas1p29; Fri, 21 Jun 2019 13:39:48 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 99.2F.04298.32EDC0D5; Fri, 21 Jun 2019 14:39:47 +0100 (BST) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20190621133947eucas1p2f9d0e45116a8ab922fe877200460075e~qOlvtpii11587215872eucas1p2o; Fri, 21 Jun 2019 13:39:47 +0000 (GMT) X-AuditID: cbfec7f2-f2dff700000010ca-49-5d0cde23b073 Received: from eusync3.samsung.com ( [203.254.199.213]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id AC.3B.04146.22EDC0D5; Fri, 21 Jun 2019 14:39:47 +0100 (BST) Received: from AMDC2765.DIGITAL.local ([106.120.51.73]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0PTG00837BA7X280@eusync3.samsung.com>; Fri, 21 Jun 2019 14:39:46 +0100 (BST) From: Marek Szyprowski To: u-boot@lists.denx.de Date: Fri, 21 Jun 2019 15:39:29 +0200 Message-id: <20190621133929.854-1-m.szyprowski@samsung.com> X-Mailer: git-send-email 2.17.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphkeLIzCtJLcpLzFFi42LZduznOV3lezyxBk/OGlhsnLGe1eLGrzZW i+fvLjNZrD1yl91ixuSXbBZv93ayO7B5zJt1gsXj7J0djB59W1YxBjBHcdmkpOZklqUW6dsl cGWcX7uWteAeW8X1p1+YGhj3snYxcnJICJhIfO9YDGRzcQgJrGCUmHrlMTOE85lRYuKSo0ww VdcWv4OqWsYo0TttMlTVf0aJGw/2g81iEzCU6HrbxQZiiwhISPzqv8oIUsQscIdRYuPpa4wg CWEBR4mmx8/BxrIIqEosnPKavYuRg4NXwFri1TcniG3yEqs3HABbICFwlVXi9acGFoiEi8T3 iwuhDpeR6Ow4yARR1Mwo8fDcWnYIp4dR4nLTDEaIKmuJw8cvgnUwC/BJTNo2nRlkm4QAr0RH mxBEiYfEu1WfwEqEBGIl2mb/Z57AKL6AkWEVo3hqaXFuemqxYV5quV5xYm5xaV66XnJ+7iZG YNyc/nf80w7Gr5eSDjEKcDAq8fAemMUdK8SaWFZcmXuIUYKDWUmElyeHJ1aINyWxsiq1KD++ qDQntfgQozQHi5I4bzXDg2ghgfTEktTs1NSC1CKYLBMHp1QDoxxLeI0s65ZrvwMDr6//bfxj AZfU409c+/fcurHUouCQnIIOM985ecX5TyuDi4UKQ58ucuS9eq+1ioX3arLBlMl3OtKXH2Hi +Fn1mUHEn7NrlVOshe85dvbLO41b8vZL+G531m/77D07qGzyHNNnXP/qg16mt8lwHrA7vlfO TX3LOW59k9dySizFGYmGWsxFxYkA+MQg/JcCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAJMWRmVeSWpSXmKPExsVy+t/xq7rK93hiDT46WGycsZ7V4savNlaL 5+8uM1msPXKX3WLG5JdsFm/3drI7sHnMm3WCxePsnR2MHn1bVjEGMEdx2aSk5mSWpRbp2yVw ZZxfu5a14B5bxfWnX5gaGPeydjFyckgImEhcW/wOyObiEBJYwiix7nAHM4TTyCSxdMEcJpAq NgFDia63XWwgtoiAhMSv/quMIEXMAncYJVZcPQ5WJCzgKNH0+DmYzSKgKrFwymv2LkYODl4B a4lX35wgtslLrN5wgHkCI9cCRoZVjCKppcW56bnFhnrFibnFpXnpesn5uZsYgf7eduzn5h2M lzYGH2IU4GBU4uE9MIs7Vog1say4MvcQowQHs5IIL08OT6wQb0piZVVqUX58UWlOavEhRmkO FiVx3g6BgzFCAumJJanZqakFqUUwWSYOTqkGxgaPvgdX8lem7nU6IjA37fzjR3YMedmtF61j ajdLTuLZv2L542xRp/xE8Xdf1JrVF3FlXNz1RPn/7vjT1veY2n93vZe+z6xQ6LZn4WoT700P JqUaZp6cJ5hhmTzrxlXW84yvvAtbTkSkX4/nigm+p/zWQUknvsnsllukILvygz1Me60O7AmO VGIpzkg01GIuKk4EAMmvQB7zAQAA X-CMS-MailID: 20190621133947eucas1p2f9d0e45116a8ab922fe877200460075e CMS-TYPE: 201P X-CMS-RootMailID: 20190621133947eucas1p2f9d0e45116a8ab922fe877200460075e References: Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski Subject: [U-Boot] [PATCH] thor: fix crash after usb initialization failure X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Registration of USB download gadget might fail for various reasons, so add a check for g_dnl_register() funtion return value. Without this fix, thor_init() will try to access the registered gadget structures resulting in NULL pointer dereference issue. Signed-off-by: Marek Szyprowski --- cmd/thordown.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cmd/thordown.c b/cmd/thordown.c index 19ae6721d19..2e1b2c5bea6 100644 --- a/cmd/thordown.c +++ b/cmd/thordown.c @@ -37,7 +37,11 @@ int do_thor_down(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) goto exit; } - g_dnl_register("usb_dnl_thor"); + ret = g_dnl_register("usb_dnl_thor"); + if (ret) { + error("g_dnl_register failed %d\n", ret); + return ret; + } ret = thor_init(); if (ret) {