| Message ID | 20190621102808.37856-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | 8b295a20262802a7ae9704bafa5d0cafb3b4744f |
| Delegated to: | Bin Meng |
| Headers | show |
| Series | [U-Boot,v3,1/2] watchdog: tangier: Replace unused constant with a comment | expand |
On Fri, Jun 21, 2019 at 6:28 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > The default timeout value had been left in order to leave some traces > about default setup of watchdog done by firmware. > > For better understanding and compiler burden, replace it with a comment. > > Suggested-by: Stefan Roese <sr@denx.de> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/watchdog/tangier_wdt.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On Sat, Jun 22, 2019 at 10:23 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > On Fri, Jun 21, 2019 at 6:28 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > The default timeout value had been left in order to leave some traces > > about default setup of watchdog done by firmware. > > > > For better understanding and compiler burden, replace it with a comment. > > > > Suggested-by: Stefan Roese <sr@denx.de> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > drivers/watchdog/tangier_wdt.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> applied to u-boot-x86, thanks!
diff --git a/drivers/watchdog/tangier_wdt.c b/drivers/watchdog/tangier_wdt.c index be4a8f467a..b2f40ef057 100644 --- a/drivers/watchdog/tangier_wdt.c +++ b/drivers/watchdog/tangier_wdt.c @@ -10,7 +10,12 @@ #define WDT_PRETIMEOUT 15 #define WDT_TIMEOUT_MIN (1 + WDT_PRETIMEOUT) #define WDT_TIMEOUT_MAX 170 -#define WDT_DEFAULT_TIMEOUT 90 + +/* + * Note, firmware chooses 90 seconds as a default timeout for watchdog on + * Intel Tangier SoC. It means that without handling it in the running code + * the reboot will happen. + */ #ifndef CONFIG_WATCHDOG_TIMEOUT_MSECS #define WATCHDOG_HEARTBEAT 60000
The default timeout value had been left in order to leave some traces about default setup of watchdog done by firmware. For better understanding and compiler burden, replace it with a comment. Suggested-by: Stefan Roese <sr@denx.de> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/watchdog/tangier_wdt.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)