diff mbox series

[U-Boot,v3,6/7] cmd: efidebug: make some boot variables non-volatile

Message ID 20190604065211.15907-7-takahiro.akashi@linaro.org
State Accepted, archived
Delegated to: Heinrich Schuchardt
Headers show
Series efi_loader: non-volatile variables support | expand

Commit Message

AKASHI Takahiro June 4, 2019, 6:52 a.m. UTC
Boot####, BootOrder and BootNext should be non-volatile.

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
---
 cmd/efidebug.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Heinrich Schuchardt June 4, 2019, 9:45 p.m. UTC | #1
On 6/4/19 8:52 AM, AKASHI Takahiro wrote:
> Boot####, BootOrder and BootNext should be non-volatile.
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>

Reviewed-by: Heinrich Schuchardt

> ---
>   cmd/efidebug.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/cmd/efidebug.c b/cmd/efidebug.c
> index c4ac9dd634e2..e65722625455 100644
> --- a/cmd/efidebug.c
> +++ b/cmd/efidebug.c
> @@ -558,6 +558,7 @@ static int do_efi_boot_add(cmd_tbl_t *cmdtp, int flag,
>   	}
>
>   	ret = EFI_CALL(RT->set_variable(var_name16, &guid,
> +					EFI_VARIABLE_NON_VOLATILE |
>   					EFI_VARIABLE_BOOTSERVICE_ACCESS |
>   					EFI_VARIABLE_RUNTIME_ACCESS,
>   					size, data));
> @@ -909,6 +910,7 @@ static int do_efi_boot_next(cmd_tbl_t *cmdtp, int flag,
>   	guid = efi_global_variable_guid;
>   	size = sizeof(u16);
>   	ret = EFI_CALL(RT->set_variable(L"BootNext", &guid,
> +					EFI_VARIABLE_NON_VOLATILE |
>   					EFI_VARIABLE_BOOTSERVICE_ACCESS |
>   					EFI_VARIABLE_RUNTIME_ACCESS,
>   					size, &bootnext));
> @@ -964,6 +966,7 @@ static int do_efi_boot_order(cmd_tbl_t *cmdtp, int flag,
>
>   	guid = efi_global_variable_guid;
>   	ret = EFI_CALL(RT->set_variable(L"BootOrder", &guid,
> +					EFI_VARIABLE_NON_VOLATILE |
>   					EFI_VARIABLE_BOOTSERVICE_ACCESS |
>   					EFI_VARIABLE_RUNTIME_ACCESS,
>   					size, bootorder));
>
Ilias Apalodimas June 11, 2019, 10:20 a.m. UTC | #2
On Tue, Jun 04, 2019 at 03:52:10PM +0900, AKASHI Takahiro wrote:
> Boot####, BootOrder and BootNext should be non-volatile.
> 
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> Reviewed-by: Heinrich Schuchardt
> ---
>  cmd/efidebug.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/cmd/efidebug.c b/cmd/efidebug.c
> index c4ac9dd634e2..e65722625455 100644
> --- a/cmd/efidebug.c
> +++ b/cmd/efidebug.c
> @@ -558,6 +558,7 @@ static int do_efi_boot_add(cmd_tbl_t *cmdtp, int flag,
>  	}
>  
>  	ret = EFI_CALL(RT->set_variable(var_name16, &guid,
> +					EFI_VARIABLE_NON_VOLATILE |
>  					EFI_VARIABLE_BOOTSERVICE_ACCESS |
>  					EFI_VARIABLE_RUNTIME_ACCESS,
>  					size, data));
> @@ -909,6 +910,7 @@ static int do_efi_boot_next(cmd_tbl_t *cmdtp, int flag,
>  	guid = efi_global_variable_guid;
>  	size = sizeof(u16);
>  	ret = EFI_CALL(RT->set_variable(L"BootNext", &guid,
> +					EFI_VARIABLE_NON_VOLATILE |
>  					EFI_VARIABLE_BOOTSERVICE_ACCESS |
>  					EFI_VARIABLE_RUNTIME_ACCESS,
>  					size, &bootnext));
> @@ -964,6 +966,7 @@ static int do_efi_boot_order(cmd_tbl_t *cmdtp, int flag,
>  
>  	guid = efi_global_variable_guid;
>  	ret = EFI_CALL(RT->set_variable(L"BootOrder", &guid,
> +					EFI_VARIABLE_NON_VOLATILE |
>  					EFI_VARIABLE_BOOTSERVICE_ACCESS |
>  					EFI_VARIABLE_RUNTIME_ACCESS,
>  					size, bootorder));

Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
diff mbox series

Patch

diff --git a/cmd/efidebug.c b/cmd/efidebug.c
index c4ac9dd634e2..e65722625455 100644
--- a/cmd/efidebug.c
+++ b/cmd/efidebug.c
@@ -558,6 +558,7 @@  static int do_efi_boot_add(cmd_tbl_t *cmdtp, int flag,
 	}
 
 	ret = EFI_CALL(RT->set_variable(var_name16, &guid,
+					EFI_VARIABLE_NON_VOLATILE |
 					EFI_VARIABLE_BOOTSERVICE_ACCESS |
 					EFI_VARIABLE_RUNTIME_ACCESS,
 					size, data));
@@ -909,6 +910,7 @@  static int do_efi_boot_next(cmd_tbl_t *cmdtp, int flag,
 	guid = efi_global_variable_guid;
 	size = sizeof(u16);
 	ret = EFI_CALL(RT->set_variable(L"BootNext", &guid,
+					EFI_VARIABLE_NON_VOLATILE |
 					EFI_VARIABLE_BOOTSERVICE_ACCESS |
 					EFI_VARIABLE_RUNTIME_ACCESS,
 					size, &bootnext));
@@ -964,6 +966,7 @@  static int do_efi_boot_order(cmd_tbl_t *cmdtp, int flag,
 
 	guid = efi_global_variable_guid;
 	ret = EFI_CALL(RT->set_variable(L"BootOrder", &guid,
+					EFI_VARIABLE_NON_VOLATILE |
 					EFI_VARIABLE_BOOTSERVICE_ACCESS |
 					EFI_VARIABLE_RUNTIME_ACCESS,
 					size, bootorder));