| Message ID | 20190516064948.6263-1-wen.he_1@nxp.com |
|---|---|
| State | Deferred |
| Delegated to: | Anatolij Gustschin |
| Headers | show |
| Series | [U-Boot,v2] board: ls1028a: Add an empty video hw init function | expand |
On Thu, May 16, 2019 at 2:48 PM Wen He <wen.he_1@nxp.com> wrote: > > The video driver causes a link failure when config VIDEO built-in, > > drivers/video/cfb_console.c:2022: undefined reference to `video_hw_init' > > Adding an empty video hw init to slove the build issue, now the board > does not support display anything on U-boot. > > Signed-off-by: Wen He <wen.he_1@nxp.com> > --- > board/freescale/ls1028a/ls1028a.c | 6 ++++++ > 1 file changed, 6 insertions(+) > I should have commented in the v2 patch here. Sorry for the duplication. Please stop adding non-DM driver support to any new platforms. We should start using DM driver. In this case, use DM_VIDEO. Regards, Bin
> -----Original Message----- > From: Bin Meng <bmeng.cn@gmail.com> > Sent: 2019年5月16日 20:15 > To: Wen He <wen.he_1@nxp.com>; Simon Glass <sjg@chromium.org>; Tom > Rini <trini@konsulko.com> > Cc: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Jagdish Gediya > <jagdish.gediya@nxp.com>; u-boot@lists.denx.de > Subject: [EXT] Re: [U-Boot] [v2] board: ls1028a: Add an empty video hw init > function > > Caution: EXT Email > > On Thu, May 16, 2019 at 2:48 PM Wen He <wen.he_1@nxp.com> wrote: > > > > The video driver causes a link failure when config VIDEO built-in, > > > > drivers/video/cfb_console.c:2022: undefined reference to `video_hw_init' > > > > Adding an empty video hw init to slove the build issue, now the board > > does not support display anything on U-boot. > > > > Signed-off-by: Wen He <wen.he_1@nxp.com> > > --- > > board/freescale/ls1028a/ls1028a.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > I should have commented in the v2 patch here. Sorry for the duplication. > > Please stop adding non-DM driver support to any new platforms. We should > start using DM driver. In this case, use DM_VIDEO. Thanks for the comments. Understand, I will send next version for the feature. Best Regards, Wen > > Regards, > Bin
diff --git a/board/freescale/ls1028a/ls1028a.c b/board/freescale/ls1028a/ls1028a.c index e5de4eb70c..ece91660bf 100644 --- a/board/freescale/ls1028a/ls1028a.c +++ b/board/freescale/ls1028a/ls1028a.c @@ -20,6 +20,7 @@ #endif #include <fsl_immap.h> #include <netdev.h> +#include <video_fb.h> #include <fdtdec.h> #include <miiphy.h> @@ -229,3 +230,8 @@ int checkboard(void) return 0; } #endif + +void *video_hw_init(void) +{ + return NULL; +}
The video driver causes a link failure when config VIDEO built-in, drivers/video/cfb_console.c:2022: undefined reference to `video_hw_init' Adding an empty video hw init to slove the build issue, now the board does not support display anything on U-boot. Signed-off-by: Wen He <wen.he_1@nxp.com> --- board/freescale/ls1028a/ls1028a.c | 6 ++++++ 1 file changed, 6 insertions(+)