| Message ID | 20190430025347.3097-4-erosca@de.adit-jv.com |
|---|---|
| State | Superseded |
| Delegated to: | Heinrich Schuchardt |
| Headers | show |
| Series | Misc EFI/GPT/UUID fixes | expand |
On 4/30/19 4:53 AM, Eugeniu Rosca wrote: > Apply the following changes: > - Guard the 'gpt read' command by 'ifdef CONFIG_CMD_GPT_RENAME', > since 'gpt read' is not available on CMD_GPT_RENAME=n > - Prefix the {read,swap,rename} commands with one space for consistency > - Prefix the 'guid' commands with 'gpt' for consistency > > Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Non-related: doc/README.commands describes the preferred way to implement sub-commands. > --- > cmd/gpt.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/cmd/gpt.c b/cmd/gpt.c > index 638870352f40..33cda513969f 100644 > --- a/cmd/gpt.c > +++ b/cmd/gpt.c > @@ -876,21 +876,21 @@ U_BOOT_CMD(gpt, CONFIG_SYS_MAXARGS, 1, do_gpt, > " Example usage:\n" > " gpt write mmc 0 $partitions\n" > " gpt verify mmc 0 $partitions\n" > - " read <interface> <dev>\n" > - " - read GPT into a data structure for manipulation\n" > - " guid <interface> <dev>\n" > + " gpt guid <interface> <dev>\n" > " - print disk GUID\n" > - " guid <interface> <dev> <varname>\n" > + " gpt guid <interface> <dev> <varname>\n" > " - set environment variable to disk GUID\n" > " Example usage:\n" > " gpt guid mmc 0\n" > " gpt guid mmc 0 varname\n" > #ifdef CONFIG_CMD_GPT_RENAME > "gpt partition renaming commands:\n" > - "gpt swap <interface> <dev> <name1> <name2>\n" > + " gpt read <interface> <dev>\n" > + " - read GPT into a data structure for manipulation\n" > + " gpt swap <interface> <dev> <name1> <name2>\n" > " - change all partitions named name1 to name2\n" > " and vice-versa\n" > - "gpt rename <interface> <dev> <part> <name>\n" > + " gpt rename <interface> <dev> <part> <name>\n" > " - rename the specified partition\n" > " Example usage:\n" > " gpt swap mmc 0 foo bar\n" >
diff --git a/cmd/gpt.c b/cmd/gpt.c index 638870352f40..33cda513969f 100644 --- a/cmd/gpt.c +++ b/cmd/gpt.c @@ -876,21 +876,21 @@ U_BOOT_CMD(gpt, CONFIG_SYS_MAXARGS, 1, do_gpt, " Example usage:\n" " gpt write mmc 0 $partitions\n" " gpt verify mmc 0 $partitions\n" - " read <interface> <dev>\n" - " - read GPT into a data structure for manipulation\n" - " guid <interface> <dev>\n" + " gpt guid <interface> <dev>\n" " - print disk GUID\n" - " guid <interface> <dev> <varname>\n" + " gpt guid <interface> <dev> <varname>\n" " - set environment variable to disk GUID\n" " Example usage:\n" " gpt guid mmc 0\n" " gpt guid mmc 0 varname\n" #ifdef CONFIG_CMD_GPT_RENAME "gpt partition renaming commands:\n" - "gpt swap <interface> <dev> <name1> <name2>\n" + " gpt read <interface> <dev>\n" + " - read GPT into a data structure for manipulation\n" + " gpt swap <interface> <dev> <name1> <name2>\n" " - change all partitions named name1 to name2\n" " and vice-versa\n" - "gpt rename <interface> <dev> <part> <name>\n" + " gpt rename <interface> <dev> <part> <name>\n" " - rename the specified partition\n" " Example usage:\n" " gpt swap mmc 0 foo bar\n"
Apply the following changes: - Guard the 'gpt read' command by 'ifdef CONFIG_CMD_GPT_RENAME', since 'gpt read' is not available on CMD_GPT_RENAME=n - Prefix the {read,swap,rename} commands with one space for consistency - Prefix the 'guid' commands with 'gpt' for consistency Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com> --- cmd/gpt.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)