diff mbox series

[U-Boot,2/2] ls1028a: enable watchdog for ls1028a SoC

Message ID 20190426062430.48022-2-qiang.zhao@nxp.com
State Superseded
Delegated to: Prabhakar Kushwaha
Headers show
Series [U-Boot,1/2] watchdog: add sp805 watchdog support | expand

Commit Message

Qiang Zhao April 26, 2019, 6:23 a.m. UTC 
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
 include/configs/ls1028a_common.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Bin Meng April 26, 2019, 6:35 a.m. UTC | #1 
On Fri, Apr 26, 2019 at 2:23 PM Qiang Zhao <qiang.zhao@nxp.com> wrote:
>
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
>  include/configs/ls1028a_common.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/configs/ls1028a_common.h b/include/configs/ls1028a_common.h
> index 3cb64c5f0c..3aec8087af 100644
> --- a/include/configs/ls1028a_common.h
> +++ b/include/configs/ls1028a_common.h
> @@ -29,6 +29,8 @@
>  #define CONFIG_REMAKE_ELF
>  #define CONFIG_FSL_LAYERSCAPE
>  #define CONFIG_MP
> +#define CONFIG_WDT_SP805
> +#define CONFIG_HW_WATCHDOG
>

Could you please stop adding ad-hoc CONFIG_XXX in config.h file,
instead create Kconfig options, and/or converting driver to DM?

>  #include <asm/arch/stream_id_lsch3.h>
>  #include <asm/arch/config.h>

Regards,
Bin
Stefan Roese April 26, 2019, 6:52 a.m. UTC | #2 
On 26.04.19 08:23, Qiang Zhao wrote:
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
>   include/configs/ls1028a_common.h | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/include/configs/ls1028a_common.h b/include/configs/ls1028a_common.h
> index 3cb64c5f0c..3aec8087af 100644
> --- a/include/configs/ls1028a_common.h
> +++ b/include/configs/ls1028a_common.h
> @@ -29,6 +29,8 @@
>   #define CONFIG_REMAKE_ELF
>   #define CONFIG_FSL_LAYERSCAPE
>   #define CONFIG_MP
> +#define CONFIG_WDT_SP805
> +#define CONFIG_HW_WATCHDOG

Please see my last reply. CONFIG_HW_WATCHDOG should not be needed. I plan
to work on a patchset to remove this option completely.

And as Bin also mentioned, the CONFIG options should be added to the
board defconfig file instead.

Thanks,
Stefan
diff mbox series

Patch

diff --git a/include/configs/ls1028a_common.h b/include/configs/ls1028a_common.h
index 3cb64c5f0c..3aec8087af 100644
--- a/include/configs/ls1028a_common.h
+++ b/include/configs/ls1028a_common.h
@@ -29,6 +29,8 @@ 
 #define CONFIG_REMAKE_ELF
 #define CONFIG_FSL_LAYERSCAPE
 #define CONFIG_MP
+#define CONFIG_WDT_SP805
+#define CONFIG_HW_WATCHDOG
 
 #include <asm/arch/stream_id_lsch3.h>
 #include <asm/arch/config.h>