diff mbox series

[U-Boot,v2,05/14] colibri-imx6ull: fix ethernet phy power on

Message ID 20190409152420.11394-6-marcel@ziswiler.com
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show
Series colibri-imx6ull device tree enablement and driver model conversion | expand

Commit Message

Marcel Ziswiler April 9, 2019, 3:24 p.m. UTC
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>

Just give the new Ethernet PHY power save mode circuitry time to settle.

Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Acked-by: Max Krummenacher <max.krummenacher@toradex.com>

---

Changes in v2: None

 board/toradex/colibri-imx6ull/colibri-imx6ull.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Igor Opaniuk April 11, 2019, 8:05 a.m. UTC | #1
Reviewed-by: Igor Opaniuk <igor.opaniuk@toradex.com>

On Tue, Apr 9, 2019 at 5:28 PM Marcel Ziswiler <marcel@ziswiler.com> wrote:
>
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Just give the new Ethernet PHY power save mode circuitry time to settle.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Acked-by: Max Krummenacher <max.krummenacher@toradex.com>
>
> ---
>
> Changes in v2: None
>
>  board/toradex/colibri-imx6ull/colibri-imx6ull.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/board/toradex/colibri-imx6ull/colibri-imx6ull.c b/board/toradex/colibri-imx6ull/colibri-imx6ull.c
> index fe60b8e870..b6f45edb86 100644
> --- a/board/toradex/colibri-imx6ull/colibri-imx6ull.c
> +++ b/board/toradex/colibri-imx6ull/colibri-imx6ull.c
> @@ -263,6 +263,9 @@ static int setup_fec(void)
>                         IOMUX_GPR1_FEC2_CLOCK_MUX2_SEL_MASK,
>                         IOMUX_GPR1_FEC2_CLOCK_MUX1_SEL_MASK);
>
> +       /* give new Ethernet PHY power save mode circuitry time to settle */
> +       mdelay(300);
> +
>         return 0;
>  }
>
> --
> 2.20.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
diff mbox series

Patch

diff --git a/board/toradex/colibri-imx6ull/colibri-imx6ull.c b/board/toradex/colibri-imx6ull/colibri-imx6ull.c
index fe60b8e870..b6f45edb86 100644
--- a/board/toradex/colibri-imx6ull/colibri-imx6ull.c
+++ b/board/toradex/colibri-imx6ull/colibri-imx6ull.c
@@ -263,6 +263,9 @@  static int setup_fec(void)
 			IOMUX_GPR1_FEC2_CLOCK_MUX2_SEL_MASK,
 			IOMUX_GPR1_FEC2_CLOCK_MUX1_SEL_MASK);
 
+	/* give new Ethernet PHY power save mode circuitry time to settle */
+	mdelay(300);
+
 	return 0;
 }