From patchwork Tue Mar 5 05:53:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AKASHI Takahiro X-Patchwork-Id: 1051622 X-Patchwork-Delegate: xypron.glpk@gmx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="Fxma2u5E"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 44D5d74WQHz9s1B for ; Tue, 5 Mar 2019 16:52:11 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 4D8C0C21E16; Tue, 5 Mar 2019 05:52:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 2577CC21DF3; Tue, 5 Mar 2019 05:52:00 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 247E4C21DC1; Tue, 5 Mar 2019 05:51:54 +0000 (UTC) Received: from mail-yw1-f67.google.com (mail-yw1-f67.google.com [209.85.161.67]) by lists.denx.de (Postfix) with ESMTPS id B0688C21E2B for ; Tue, 5 Mar 2019 05:51:50 +0000 (UTC) Received: by mail-yw1-f67.google.com with SMTP id s204so6075656ywg.2 for ; Mon, 04 Mar 2019 21:51:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SKnktM/NKAgY6OOGTW+wiR8R0J7qw7EvrZpzKaPIgbM=; b=Fxma2u5E42XiWR+YzOJydKBYbUiUkyztp7M914P4QCP67OwHhf1EqmcwXE8zzI3Jks QyJJx966Xt541k8mQTaG5yBgIgKVbORbVWpRQ/aPyVia/nKEAVPQ/+r+5CKPdO0swMhF ePjYlfn2srM9A+Ob9Redwbyy9ifO0ByP+ye62hi+SPSH+DrlXaOLs53fNcf3Xw2H82y1 ZmQPGPNXzJgRQTp1ONupRX8BRrUSIpBjNoemcY12Zq2A5dsla4nk44NGuO0As+7AZiBA e18b14xCgcyRclGvOrpf759FHlqcHcbDNjpgdZ4pm8gQm3nwiLvehNTG2Ifk50X39Ye5 Ntdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SKnktM/NKAgY6OOGTW+wiR8R0J7qw7EvrZpzKaPIgbM=; b=aF0gEzKrAUvnrh0xHrkn0mV6KbQT32Y1SGcv5j2mV0NU35bx91r1X17Rj6iQV+SjlV 7pXARfDw1E8WTPJ9KDLIWG0Wl29rl6SWWzPjegq1rAuZZJEF9C+cLr2229aD4CydC5ba ItARjbJ5FmEScfee7FYfqwoP+CE8Fhs3C218mS+KrliTk03NGqGFhx7szNujoc8iZOsV GrT1Qu2I9z0z4kvpqGn8hI0YqOI+XAOF8Qiubre6KPSYV5k9U/SvlmOvjDCrT4CbyHxl wNy5G5/mT+2UTPE/tNvXlUfgHfc5P1NQGDjp+CR2i0z3vasnvLqhKJeoSEP+MFGQkqji U4fw== X-Gm-Message-State: APjAAAXb2lNSfOnCKwgjJ2PTkI0Q7Rd6/6QMW+s7sUiK/EbLBpLgJ/yP k9X4Sq3M0aQGYTKmxx+WElnGxm1nXlw= X-Google-Smtp-Source: APXvYqy4EfqkBM9mZlnocxRa6Q2tXj/UPb6qO8xrCJLBg3kB7bnWi0kg81RAfcS0xTWzoh5O7zPESQ== X-Received: by 2002:a5b:78b:: with SMTP id b11mr753800ybq.185.1551765109725; Mon, 04 Mar 2019 21:51:49 -0800 (PST) Received: from linaro.org ([121.95.100.191]) by smtp.googlemail.com with ESMTPSA id h204sm3309414ywh.52.2019.03.04.21.51.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Mar 2019 21:51:49 -0800 (PST) From: AKASHI Takahiro To: xypron.glpk@gmx.de, agraf@suse.de Date: Tue, 5 Mar 2019 14:53:30 +0900 Message-Id: <20190305055337.3793-2-takahiro.akashi@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190305055337.3793-1-takahiro.akashi@linaro.org> References: <20190305055337.3793-1-takahiro.akashi@linaro.org> MIME-Version: 1.0 Cc: u-boot@lists.denx.de Subject: [U-Boot] [RFC 1/8] efi_loader: boottime: don't add device path protocol to image handle X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" It is just wrong to add devcie path protocol to image handle. Signed-off-by: AKASHI Takahiro --- lib/efi_loader/efi_boottime.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c index bd8b8a17ae71..7bd9c0a952d4 100644 --- a/lib/efi_loader/efi_boottime.c +++ b/lib/efi_loader/efi_boottime.c @@ -1540,17 +1540,8 @@ efi_status_t efi_setup_loaded_image(struct efi_device_path *device_path, info->file_path = file_path; info->system_table = &systab; - if (device_path) { + if (device_path) info->device_handle = efi_dp_find_obj(device_path, NULL); - /* - * When asking for the device path interface, return - * bootefi_device_path - */ - ret = efi_add_protocol(&obj->header, - &efi_guid_device_path, device_path); - if (ret != EFI_SUCCESS) - goto failure; - } /* * When asking for the loaded_image interface, just