diff mbox series

[U-Boot,01/10] board: tbs2910: Fix default environment

Message ID 20190301121101.14163-2-smoch@web.de
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show
Series tbs2910 fixes and driver model conversion | expand

Commit Message

Sören Moch March 1, 2019, 12:10 p.m. UTC 
Especially fix usb keyboard support. Other changes are only for
beautification.

Signed-off-by: Soeren Moch <smoch@web.de>
---
Cc: Stefano Babic <sbabic@denx.de>
Cc: u-boot@lists.denx.de
---
 include/configs/tbs2910.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

--
2.17.1

Comments

Sören Moch March 14, 2019, 7:16 p.m. UTC | #1 
On 01.03.19 13:10, Soeren Moch wrote:
> Especially fix usb keyboard support. Other changes are only for
> beautification.
>
> Signed-off-by: Soeren Moch <smoch@web.de>
> ---
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: u-boot@lists.denx.de
Stefano,

apparently you decided to pull fixes for v2019.04 and DM conversions for
v2019.07. Since this patch (1/10) is a fix, can you at least pull this
now, and the rest of the series later (or for -next)?

Thanks,
Soeren
Stefano Babic March 14, 2019, 7:18 p.m. UTC | #2 
On 14/03/19 20:16, Soeren Moch wrote:
> On 01.03.19 13:10, Soeren Moch wrote:
>> Especially fix usb keyboard support. Other changes are only for
>> beautification.
>>
>> Signed-off-by: Soeren Moch <smoch@web.de>
>> ---
>> Cc: Stefano Babic <sbabic@denx.de>
>> Cc: u-boot@lists.denx.de
> Stefano,
> 
> apparently you decided to pull fixes for v2019.04 and DM conversions for
> v2019.07.

That is right.

> Since this patch (1/10) is a fix, can you at least pull this
> now, and the rest of the series later (or for -next)?

I pick up 1/10

Regards,
Stefano
diff mbox series

Patch

diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h
index 2d4b9c9bfe..b06c90939c 100644
--- a/include/configs/tbs2910.h
+++ b/include/configs/tbs2910.h
@@ -94,7 +94,7 @@ 
 		"run set_con_hdmi; " \
 	"else " \
 		"run set_con_serial; " \
-	"fi;"
+	"fi"
 #endif /* CONFIG_USB_KEYBOARD */
 #endif /* CONFIG_CMD_USB      */

@@ -142,12 +142,12 @@ 
 	"console=ttymxc0\0" \
 	"fan=gpio set 92\0" \
 	"set_con_serial=setenv stdout serial; " \
-			"setenv stderr serial;\0" \
+			"setenv stderr serial\0" \
 	"set_con_hdmi=setenv stdout serial,vga; " \
-			"setenv stderr serial,vga;\0" \
-	"stderr=serial,vga;\0" \
-	"stdin=serial,usbkbd;\0" \
-	"stdout=serial,vga;\0"
+			"setenv stderr serial,vga\0" \
+	"stderr=serial,vga\0" \
+	"stdin=serial,usbkbd\0" \
+	"stdout=serial,vga\0"

 #define CONFIG_BOOTCOMMAND \
 	"mmc rescan; " \