diff mbox series

[U-Boot,v1,18/22] config: colibri_vf: enable mtd partitions via dt

Message ID 20190215222039.10005-19-marcel@ziswiler.com
State Superseded
Delegated to: Stefano Babic
Headers show
Series colibri vybrid fixes, device tree enablement and driver model conversion | expand

Commit Message

Marcel Ziswiler Feb. 15, 2019, 10:20 p.m. UTC 
From: Stefan Agner <stefan.agner@toradex.com>

Use device tree to set MTD partitions of the NAND chip.

Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

---

 configs/colibri_vf_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Igor Opaniuk March 11, 2019, 2:01 p.m. UTC | #1 
Off-topic: I'm just wondering, why no one introduced a proper Kconfig symbol for
FDT_FIXUP_PARTITIONS. Currently there is no any description of this
option through
the code and what it's actually used for. But, anyway, it doesn't
directly relate to this particular patch-set,
it can be addressed in a separate patch.

Reviewed-by: Igor Opaniuk <igor.opaniuk@toradex.com>

On Sat, 16 Feb 2019 at 00:27, Marcel Ziswiler <marcel@ziswiler.com> wrote:
>
> From: Stefan Agner <stefan.agner@toradex.com>
>
> Use device tree to set MTD partitions of the NAND chip.
>
> Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
> Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
>
>  configs/colibri_vf_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/configs/colibri_vf_defconfig b/configs/colibri_vf_defconfig
> index 344fe77234..8f6cceca7f 100644
> --- a/configs/colibri_vf_defconfig
> +++ b/configs/colibri_vf_defconfig
> @@ -91,4 +91,5 @@ CONFIG_VIDEO_FSL_DCU_FB=y
>  CONFIG_VIDEO=y
>  CONFIG_SYS_CONSOLE_FG_COL=0x00
>  CONFIG_OF_LIBFDT_OVERLAY=y
> +CONFIG_FDT_FIXUP_PARTITIONS=y
>  # CONFIG_EFI_UNICODE_CAPITALIZATION is not set
> --
> 2.20.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
Marcel Ziswiler March 24, 2019, 9:33 p.m. UTC | #2 
On Mon, 2019-03-11 at 14:01 +0000, Igor Opaniuk wrote:
> Off-topic: I'm just wondering, why no one introduced a proper Kconfig
> symbol for
> FDT_FIXUP_PARTITIONS. Currently there is no any description of this
> option through
> the code and what it's actually used for. But, anyway, it doesn't
> directly relate to this particular patch-set,
> it can be addressed in a separate patch.

Yeah, I agree. Can you please cook one up? Just ping me on slack should
you require any further explanations.

> Reviewed-by: Igor Opaniuk <igor.opaniuk@toradex.com>
> 
> On Sat, 16 Feb 2019 at 00:27, Marcel Ziswiler <marcel@ziswiler.com>
> wrote:
> > From: Stefan Agner <stefan.agner@toradex.com>
> > 
> > Use device tree to set MTD partitions of the NAND chip.
> > 
> > Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
> > Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > 
> > ---
> > 
> >  configs/colibri_vf_defconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/configs/colibri_vf_defconfig
> > b/configs/colibri_vf_defconfig
> > index 344fe77234..8f6cceca7f 100644
> > --- a/configs/colibri_vf_defconfig
> > +++ b/configs/colibri_vf_defconfig
> > @@ -91,4 +91,5 @@ CONFIG_VIDEO_FSL_DCU_FB=y
> >  CONFIG_VIDEO=y
> >  CONFIG_SYS_CONSOLE_FG_COL=0x00
> >  CONFIG_OF_LIBFDT_OVERLAY=y
> > +CONFIG_FDT_FIXUP_PARTITIONS=y
> >  # CONFIG_EFI_UNICODE_CAPITALIZATION is not set
> > --
> > 2.20.1
> > 
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot@lists.denx.de
> > https://lists.denx.de/listinfo/u-boot
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
diff mbox series

Patch

diff --git a/configs/colibri_vf_defconfig b/configs/colibri_vf_defconfig
index 344fe77234..8f6cceca7f 100644
--- a/configs/colibri_vf_defconfig
+++ b/configs/colibri_vf_defconfig
@@ -91,4 +91,5 @@  CONFIG_VIDEO_FSL_DCU_FB=y
 CONFIG_VIDEO=y
 CONFIG_SYS_CONSOLE_FG_COL=0x00
 CONFIG_OF_LIBFDT_OVERLAY=y
+CONFIG_FDT_FIXUP_PARTITIONS=y
 # CONFIG_EFI_UNICODE_CAPITALIZATION is not set