From patchwork Fri Jan 18 11:19:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1027225 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.b="eE/add3C"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="fnn/RUeB"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43gzBl6THBz9sBQ for ; Fri, 18 Jan 2019 22:25:19 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 91EA4C220D5; Fri, 18 Jan 2019 11:22:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=KHOP_BIG_TO_CC, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 4BAA2C21E3E; Fri, 18 Jan 2019 11:20:59 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 9335CC21E0F; Fri, 18 Jan 2019 11:19:36 +0000 (UTC) Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by lists.denx.de (Postfix) with ESMTPS id E2C4BC21E96 for ; Fri, 18 Jan 2019 11:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1547810371; x=1579346371; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AGopGUiXazjgN5ZuY1nzw0BAbdwpOrkv1RV7FfRgwcQ=; b=eE/add3CLmikqV0KDT/c9XYmo1VvNSswyy9O5A7g2tEKx5NeByEZhhDu Wg//cuTSWoEvU4RyeRYJPZ+roaYj4067PH2+FJse4kpOus2UXdb7mMyye ryV80sYNqfeBIq5Rn9Cw4wgVskhoDwa1ZVv23F0xY9Aklvu6JzSA76dg2 ZX3VyiVdwYsO2xHlPeGZSDrFEalL0RTgWlTutc4Dy8pA1Qb90jE0AhqD0 qw3+MU3CpNkcny4XAptwFzfBXKrR4GRPFJxTB8/UTyoYeCzGTBGPz85hb UO0w6X9cDiXUBfwyOeyxFfQVplyPifCWac3toLTtWIttwIbBw95tHU08b A==; X-IronPort-AV: E=Sophos;i="5.56,491,1539619200"; d="scan'208";a="100370992" Received: from mail-sn1nam02lp2056.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.36.56]) by ob1.hgst.iphmx.com with ESMTP; 18 Jan 2019 19:19:28 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u0pk+m+saWEBpumb8AcuizP7KdgAEiXUxCJ16WAWEek=; b=fnn/RUeB8we7BHKUAzkGjxVdX038M4EK63xpuXnHAh2Rx/ouhiofqu30WPBNVCZctt0W0EnG51zqI1ehWEfP+D+4wpLX0BmU7nGYr1I+7U1i8FEp9Ykj2Dl3BZ8PdoDdQczH70SdVYER7+mtKxHTeBx4cMlEmrLrR+1QFKTaXgE= Received: from BYAPR04MB5303.namprd04.prod.outlook.com (20.178.49.148) by BYAPR04MB4197.namprd04.prod.outlook.com (20.176.250.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1537.24; Fri, 18 Jan 2019 11:19:25 +0000 Received: from BYAPR04MB5303.namprd04.prod.outlook.com ([fe80::add1:92cc:65d7:5d94]) by BYAPR04MB5303.namprd04.prod.outlook.com ([fe80::add1:92cc:65d7:5d94%2]) with mapi id 15.20.1537.018; Fri, 18 Jan 2019 11:19:25 +0000 From: Anup Patel To: Rick Chen , Bin Meng , Joe Hershberger , Lukas Auer , Masahiro Yamada , Simon Glass Thread-Topic: [PATCH v2 09/11] drivers: serial_sifive: Skip baudrate config if no input clock Thread-Index: AQHUrx+rF7KuvmNSPEumpy1BMk5tRA== Date: Fri, 18 Jan 2019 11:19:25 +0000 Message-ID: <20190118111820.71349-10-anup.patel@wdc.com> References: <20190118111820.71349-1-anup.patel@wdc.com> In-Reply-To: <20190118111820.71349-1-anup.patel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MA1PR01CA0115.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:1::31) To BYAPR04MB5303.namprd04.prod.outlook.com (2603:10b6:a03:c8::20) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anup.Patel@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [49.207.48.211] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR04MB4197; 6:f7mSmrrugcH4rrUigf36o4Wdhc8twqsFa0yaDz7IDuJjCYgs8Z00APYrUsA6JrwikBYz0dFou4CQ3rBdpVvBTv6PrS+DSGi9R3cuO8Hwdkf33Nx3S9umG7BawiVzUcSRyAMTEEChL7izbVK/kpJA+1ANkaG8a42TYh1okcHes27L/SN7f/hJX/WWSMUkbj2XSJdZSuayVgoNxsLzTeFllAqtj2pBUUtpYr1i5+hC+c1cIpaKnPyF2QioYD44loOgMLUXTZpQmrm1ETeLOHjfIVuI9UydW6cZrz7DOcUdF2YHaz/kBOm2WBG5DIPR52JWdEE/h6jK8TAXBcwC66I6Zeg73UNMnPPDscpghU8W6yvrrMnOPOLqUQz3a/K7FP8V7JVjDWzJGIugpzfzaTjN/Ca8TQq9x6GwjSpHStMZxf3gubCdwzSvv0eMxpwqpxuqoP76ar9w9Huc+sNZmjH8cA==; 5:BR32SEzQOWQ0uSfHZKeoY66TmjyRAcjrNdH/oVHAepzz/Bx5fAZ2ZRIJTD4w4GOF6Y7/4zuHDm1OaESbVa7sXCrNkVIG2NH3Hwtl+l8okAxfUuWGMnMyfQCtoiVQOC4JL8mFtwE30PzPffsxmp16aWGrCQ7hq0SI1tva07XecEHVXL+WcfsYdw2IBeMhtH24bfb4y9u4EeajebaaOUXWgQ==; 7:fFga1NPRuVIN+8gylcERwZdZ5uRaBAqk0veyfkBw81wvmarjJsfoIeCIOYANai69EltDj0XDWsgyNpKzrD137lDFJWqkDZvnDqVxcidbdDN0abYeSYRKt4KPjAW9HUNb0C37LnEygIwQTEwmDMB5bw== x-ms-office365-filtering-correlation-id: 7250ed5f-2972-4f02-129f-08d67d36ce02 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:BYAPR04MB4197; x-ms-traffictypediagnostic: BYAPR04MB4197: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-forefront-prvs: 0921D55E4F x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(136003)(39860400002)(366004)(376002)(396003)(346002)(189003)(199004)(81156014)(81166006)(14454004)(8676002)(7736002)(4326008)(39060400002)(305945005)(36756003)(478600001)(68736007)(8936002)(50226002)(97736004)(2906002)(256004)(25786009)(476003)(486006)(2616005)(105586002)(72206003)(6436002)(6486002)(6512007)(44832011)(1076003)(110136005)(54906003)(71190400001)(71200400001)(106356001)(316002)(386003)(6116002)(76176011)(102836004)(6506007)(26005)(55236004)(186003)(11346002)(53936002)(3846002)(446003)(86362001)(7416002)(52116002)(5660300001)(99286004)(66066001); DIR:OUT; SFP:1102; SCL:1; SRVR:BYAPR04MB4197; H:BYAPR04MB5303.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: LEOBf5tZVniukuYEVuSyWJq6BVLq5ULFzyQdUB2fljZpEPT4/uVmn+urFu6KH6xY9mkSpDr1YkZ5+FoEmPX5WqPWouoO4igoaiO05tA0aFGgjkoQzryRNat7qZYjoKO4H0sUqVrwqD/7nomzTCRVeB4RFE+5KLHAiinuFmVi74t7ybSxt6mXsie7eLhBgCNsS+n9vrV8Wp2ajLqpXn0F8PdKHFyn1f6WjzX6PvMxvSr37zrXoDn99CalXJFlCYWjHbe8imahzA951WS67aQ2sJf2J+ER4NWT7uUyweJxjt6XRg4bNVbbOdNLpoijiUhY6mDXgZgnFNRsELQZY9fnRy1DKe2yVEAwtutk08j5JSSffRxJOd8tOCCt14AaBJCG51ap1bV+lR9ed+1plp/oFJ4CDZuZ0AGLuUvI+FunNas= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7250ed5f-2972-4f02-129f-08d67d36ce02 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2019 11:19:22.5108 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4197 Cc: Palmer Dabbelt , U-Boot Mailing List , Alexander Graf , Christoph Hellwig , Paul Walmsley Subject: [U-Boot] [PATCH v2 09/11] drivers: serial_sifive: Skip baudrate config if no input clock X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Atish Patra It is possible that input clock is not available because clk device was not available and 'clock-frequency' DT property is also not available. In this case, instead of failing we should just skip baudrate config by returning zero. Signed-off-by: Atish Patra Signed-off-by: Anup Patel Reviewed-by: Alexander Graf --- drivers/serial/serial_sifive.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/serial/serial_sifive.c b/drivers/serial/serial_sifive.c index ea4d35d48c..537bc7a975 100644 --- a/drivers/serial/serial_sifive.c +++ b/drivers/serial/serial_sifive.c @@ -99,27 +99,27 @@ static int _sifive_serial_getc(struct uart_sifive *regs) static int sifive_serial_setbrg(struct udevice *dev, int baudrate) { - int err; + int ret; struct clk clk; struct sifive_uart_platdata *platdata = dev_get_platdata(dev); + u32 clock = 0; - err = clk_get_by_index(dev, 0, &clk); - if (!err) { - err = clk_get_rate(&clk); - if (!IS_ERR_VALUE(err)) - platdata->clock = err; - } else if (err != -ENOENT && err != -ENODEV && err != -ENOSYS) { + ret = clk_get_by_index(dev, 0, &clk); + if (IS_ERR_VALUE(ret)) { debug("SiFive UART failed to get clock\n"); - return err; - } - - if (!platdata->clock) - platdata->clock = dev_read_u32_default(dev, "clock-frequency", 0); - if (!platdata->clock) { - debug("SiFive UART clock not defined\n"); - return -EINVAL; + ret = dev_read_u32(dev, "clock-frequency", &clock); + if (IS_ERR_VALUE(ret)) { + debug("SiFive UART clock not defined\n"); + return 0; + } + } else { + clock = clk_get_rate(&clk); + if (IS_ERR_VALUE(clock)) { + debug("SiFive UART clock get rate failed\n"); + return 0; + } } - + platdata->clock = clock; _sifive_serial_setbrg(platdata->regs, platdata->clock, baudrate); return 0;