From patchwork Sat Nov 17 09:24:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Goldschmidt X-Patchwork-Id: 999268 X-Patchwork-Delegate: joe.hershberger@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="f7NWPe7x"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 42xqTQ0Kg3z9s5c for ; Sat, 17 Nov 2018 20:25:45 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 91AC1C222AB; Sat, 17 Nov 2018 09:25:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 34853C222F8; Sat, 17 Nov 2018 09:25:03 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id F39D9C222F3; Sat, 17 Nov 2018 09:24:54 +0000 (UTC) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by lists.denx.de (Postfix) with ESMTPS id B2275C222CC for ; Sat, 17 Nov 2018 09:24:50 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id z13-v6so27194019wrs.3 for ; Sat, 17 Nov 2018 01:24:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hrS8AC7ds6qe24BnF6nuWUjYOqMfjtGyDntBILtTbwQ=; b=f7NWPe7xVxPrpJL28HsokqSmcRs9u+M5u+eVNER6EEljwYSUlrST/uLcRNQWQfGok8 Jal36+9kt3+tC1TUBHnyJbDfiDqPSfpN/8WHrH5NcQpA9OMjNEEyvb1bGoJOV+0QhGOu 2W0BPbQ+YQNF3afmXxVv5SOUy1l9MA3PtGBduugl6Nsg0QHy6eyl062TzdN2YSrksFqT 5XKHxZpFJF+/tIm7XqQgqum/rAxxvbHVcTwsq40UP7QUeLt8omugooSRZfDL9ej0aZGY g2OjQEZ462obOA1UeRagKz6BCHYbdpfiPUBrc2Zx6AFCCtx/I7SA40i19yDzHLzzWH0O QY3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hrS8AC7ds6qe24BnF6nuWUjYOqMfjtGyDntBILtTbwQ=; b=VsuE5bnsxh2TW7lFI9YqP++qdI3cDNlzaQw7OsgkSvkNUJFv8q9+IwRT5zBZBM4R3a Xynrq6R9l07d5z9ZzstPndZ+qplCJ5YfOOzuvKZJntsrltLIXqQa2vdtuGdjliLmwgYh zgplJGhL2ofBDSjMaBrStmT8gHTaBlQOuKcoCe4jGmSsY3z2A1xovgE0Zo3cQMtoCVj9 P4DkvMuV+N3TTaahwgoiip/G3nI1i64drfZUcW7yhBhPNEgBVYxkni/0KpPSWquuXPmA vYTion/XQzqaT5Ikqkv8xpaQd+1oiWXM7yFcNSHDrREvFERNV7TO5k1to06iUq8J1UD4 xrJQ== X-Gm-Message-State: AGRZ1gJGyEv8zhgI1i27Az4Xpd5DsJxDi4vm3KPHIe76v3wns+85HMze QJ9D8dx8+TzlWJZ9UvE+C34= X-Google-Smtp-Source: AJdET5dq3nR3eJRAoxsCDzQc0whaFvQmmeEhnnvTUuH47BMFs16Gi0b9aZjc9/ZnXA0jvKjNOYbhng== X-Received: by 2002:adf:b253:: with SMTP id y19-v6mr11732358wra.213.1542446690343; Sat, 17 Nov 2018 01:24:50 -0800 (PST) Received: from ubuntu.home ([2a02:8071:6a3:700:456c:50ae:6b7:768d]) by smtp.gmail.com with ESMTPSA id c6-v6sm18884502wre.45.2018.11.17.01.24.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 17 Nov 2018 01:24:49 -0800 (PST) From: Simon Goldschmidt To: Joe Hershberger , u-boot@lists.denx.de Date: Sat, 17 Nov 2018 10:24:42 +0100 Message-Id: <20181117092442.15638-2-simon.k.r.goldschmidt@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181117092442.15638-1-simon.k.r.goldschmidt@gmail.com> References: <20181117092442.15638-1-simon.k.r.goldschmidt@gmail.com> Cc: Marek Vasut Subject: [U-Boot] [PATCH 2/2] net: designware: clear padding bytes X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Short frames are padded to the minimum allowed size of 60 bytes. However, the designware driver sends old data in these padding bytes. It is common practice to zero out these padding bytes ro prevent leaking memory contents to other hosts. Fix the padding code to zero out the padded bytes at the end. Tested on socfpga gen5. Signed-off-by: Simon Goldschmidt Acked-by: Joe Hershberger --- drivers/net/designware.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/designware.c b/drivers/net/designware.c index 688cf9fef2..33463de0f8 100644 --- a/drivers/net/designware.c +++ b/drivers/net/designware.c @@ -380,9 +380,11 @@ static int _dw_eth_send(struct dw_eth_dev *priv, void *packet, int length) return -EPERM; } - length = max(length, ETH_ZLEN); - memcpy((void *)data_start, packet, length); + if (length < ETH_ZLEN) { + memset(&((char *)data_start)[length], 0, ETH_ZLEN - length); + length = ETH_ZLEN; + } /* Flush data to be sent */ flush_dcache_range(data_start, data_end);