| Message ID | 20180916172301.25982-3-pbrobinson@gmail.com |
|---|---|
| State | Accepted |
| Commit | cba0ae6e49085dba539d223c58d1c203a98689f0 |
| Delegated to: | Tom Warren |
| Headers | show |
| Series | [U-Boot,1/6] tegra: cleanup dangling comments in include/configs | expand |
On Sun, 2018-09-16 at 18:22 +0100, Peter Robinson wrote: > All other Tegra devices that define USB_EHCI_TXFIFO_THRESH use hex > representation, fix tegra20 to be the same format. > > Signed-off-by: Peter Robinson <pbrobinson@gmail.com> > Cc: Tom Warren <twarren@nvidia.com> > Cc: Stephen Warren <swarren@nvidia.com> > --- > include/configs/tegra20-common.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/configs/tegra20-common.h > b/include/configs/tegra20-common.h > index 7f0a5292c2e..3551616cd1e 100644 > --- a/include/configs/tegra20-common.h > +++ b/include/configs/tegra20-common.h > @@ -78,7 +78,7 @@ > * parameter, the default (2) causes occasional Data Buffer Errors > in OUT > * packets depending on the buffer address and size. > */ > -#define CONFIG_USB_EHCI_TXFIFO_THRESH 10 > +#define CONFIG_USB_EHCI_TXFIFO_THRESH 0x10 I'm not quite sure about this one but believe that 10 on tegra20 vs. 0x10 on the others may actually be intentional. At least the same value is used in the Linux kernel: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree /drivers/usb/host/ehci-tegra.c#n567 Maybe one of them Warrens would know where exactly that distinction/value came from? However, I agree that using 0xa instead of 10 would make this more clear. > #define CONFIG_EHCI_IS_TDI > > #define CONFIG_SYS_NAND_SELF_INIT
diff --git a/include/configs/tegra20-common.h b/include/configs/tegra20-common.h index 7f0a5292c2e..3551616cd1e 100644 --- a/include/configs/tegra20-common.h +++ b/include/configs/tegra20-common.h @@ -78,7 +78,7 @@ * parameter, the default (2) causes occasional Data Buffer Errors in OUT * packets depending on the buffer address and size. */ -#define CONFIG_USB_EHCI_TXFIFO_THRESH 10 +#define CONFIG_USB_EHCI_TXFIFO_THRESH 0x10 #define CONFIG_EHCI_IS_TDI #define CONFIG_SYS_NAND_SELF_INIT
All other Tegra devices that define USB_EHCI_TXFIFO_THRESH use hex representation, fix tegra20 to be the same format. Signed-off-by: Peter Robinson <pbrobinson@gmail.com> Cc: Tom Warren <twarren@nvidia.com> Cc: Stephen Warren <swarren@nvidia.com> --- include/configs/tegra20-common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)