| Message ID | 20180814092119.17315-2-christian.gmeiner@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot,1/4] env: fat: drop not needed #ifdef CMD_SAVEENV | expand |
On 14 August 2018 at 03:21, Christian Gmeiner <christian.gmeiner@gmail.com> wrote: > env_save_ptr(..) macro handles CMD_SAVEENV already. > > Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> > --- > env/flash.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org> I'd be tempted to do these changes in one patch, but either is fine with me. - Simon
diff --git a/env/flash.c b/env/flash.c index 32236c716e..f6e62df23c 100644 --- a/env/flash.c +++ b/env/flash.c @@ -360,9 +360,7 @@ U_BOOT_ENV_LOCATION(flash) = { #ifdef LOADENV .load = env_flash_load, #endif -#ifdef CMD_SAVEENV .save = env_save_ptr(env_flash_save), -#endif #ifdef INITENV .init = env_flash_init, #endif
env_save_ptr(..) macro handles CMD_SAVEENV already. Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> --- env/flash.c | 2 -- 1 file changed, 2 deletions(-)