| Message ID | 20180720025723.6736-15-takahiro.akashi@linaro.org |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | fs: fat: extend FAT write operations | expand |
On 07/20/2018 04:57 AM, AKASHI Takahiro wrote: > In this patch, a new command, fatmkdir, is added. > > Please note that, as there is no notion of "current directory" on u-boot, > a directory name specified must contains an absolute directory path as > a parent directory. Otherwise, "/" (root directory) is assumed. > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> > --- Please, provide a Python test with an additional patch. Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
On Fri, Jul 20, 2018 at 07:09:17PM +0200, Heinrich Schuchardt wrote: > On 07/20/2018 04:57 AM, AKASHI Takahiro wrote: > > In this patch, a new command, fatmkdir, is added. > > > > Please note that, as there is no notion of "current directory" on u-boot, > > a directory name specified must contains an absolute directory path as > > a parent directory. Otherwise, "/" (root directory) is assumed. > > > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> > > --- > > Please, provide a Python test with an additional patch. Please see my reply to Simon's/Tom's comments. > Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Thanks a lot for your review. -Takahiro AKASHI
diff --git a/cmd/fat.c b/cmd/fat.c index 2a5f7bfc26..136a5114c6 100644 --- a/cmd/fat.c +++ b/cmd/fat.c @@ -151,4 +151,17 @@ U_BOOT_CMD( " - write file 'filename' from the address 'addr' in RAM\n" " to 'dev' on 'interface'" ); + +static int do_fat_mkdir(cmd_tbl_t *cmdtp, int flag, int argc, + char * const argv[]) +{ + return do_mkdir(cmdtp, flag, argc, argv, FS_TYPE_FAT); +} + +U_BOOT_CMD( + fatmkdir, 4, 1, do_fat_mkdir, + "create a directory", + "<interface> [<dev[:part]>] <directory>\n" + " - create a directory in 'dev' on 'interface'" +); #endif
In this patch, a new command, fatmkdir, is added. Please note that, as there is no notion of "current directory" on u-boot, a directory name specified must contains an absolute directory path as a parent directory. Otherwise, "/" (root directory) is assumed. Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> --- cmd/fat.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)