diff mbox series

[U-Boot,v3] tegra: nyan-big: Update CONFIG_SYS_TEXT to the default in README.chromium

Message ID 20180610051746.25713-1-pbrobinson@gmail.com
State Accepted
Delegated to: Tom Warren
Headers show
Series [U-Boot,v3] tegra: nyan-big: Update CONFIG_SYS_TEXT to the default in README.chromium | expand

Commit Message

Peter Robinson June 10, 2018, 5:17 a.m. UTC
To build U-Boot on a Nyan Big Chromebook the docs outline adjusting the Tegra124
defined CONFIG_SYS_TEXT_BASE but this has since been moved to individual config
files. We should have the default required for U-Boot chain loading on the
chromebook as the default CONFIG_SYS_TEXT_BASE and update the docs to remove
this now non required step.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---

v3: Update commit message
v2: Update to 2018.07 RC1

 configs/nyan-big_defconfig |  2 +-
 doc/README.chromium        | 27 +++++++--------------------
 2 files changed, 8 insertions(+), 21 deletions(-)

Comments

Simon Glass June 11, 2018, 2:53 p.m. UTC | #1
On 9 June 2018 at 21:17, Peter Robinson <pbrobinson@gmail.com> wrote:
> To build U-Boot on a Nyan Big Chromebook the docs outline adjusting the Tegra124
> defined CONFIG_SYS_TEXT_BASE but this has since been moved to individual config
> files. We should have the default required for U-Boot chain loading on the
> chromebook as the default CONFIG_SYS_TEXT_BASE and update the docs to remove
> this now non required step.
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>
> v3: Update commit message
> v2: Update to 2018.07 RC1
>
>  configs/nyan-big_defconfig |  2 +-
>  doc/README.chromium        | 27 +++++++--------------------
>  2 files changed, 8 insertions(+), 21 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Peter Robinson July 6, 2018, 6:38 a.m. UTC | #2
Tom,

Ping, could we get this applied please?

Peter

On Sun, Jun 10, 2018 at 6:17 AM, Peter Robinson <pbrobinson@gmail.com> wrote:
> To build U-Boot on a Nyan Big Chromebook the docs outline adjusting the Tegra124
> defined CONFIG_SYS_TEXT_BASE but this has since been moved to individual config
> files. We should have the default required for U-Boot chain loading on the
> chromebook as the default CONFIG_SYS_TEXT_BASE and update the docs to remove
> this now non required step.
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>
> v3: Update commit message
> v2: Update to 2018.07 RC1
>
>  configs/nyan-big_defconfig |  2 +-
>  doc/README.chromium        | 27 +++++++--------------------
>  2 files changed, 8 insertions(+), 21 deletions(-)
>
> diff --git a/configs/nyan-big_defconfig b/configs/nyan-big_defconfig
> index 8868d1f9e10..3b64c643716 100644
> --- a/configs/nyan-big_defconfig
> +++ b/configs/nyan-big_defconfig
> @@ -1,6 +1,6 @@
>  CONFIG_ARM=y
>  CONFIG_TEGRA=y
> -CONFIG_SYS_TEXT_BASE=0x80110000
> +CONFIG_SYS_TEXT_BASE=0x81000100
>  CONFIG_DEBUG_UART_BASE=0x70006000
>  CONFIG_DEBUG_UART_CLOCK=408000000
>  CONFIG_TEGRA124=y
> diff --git a/doc/README.chromium b/doc/README.chromium
> index 7bf4d874474..45eaeced2da 100644
> --- a/doc/README.chromium
> +++ b/doc/README.chromium
> @@ -43,26 +43,13 @@ https://git.collabora.com/cgit/user/tomeu/u-boot.git/commit/?h=nyan-big
>  https://lists.denx.de/pipermail/u-boot/2017-May/289491.html
>  https://github.com/chromeos-nvidia-androidtv/gnu-linux-on-acer-chromebook-13#copy-data-to-the-sd-card
>
> -1. Patch U-Boot
> -
> -Open include/configs/tegra124-common.h
> -
> -Change:
> -
> -#define CONFIG_SYS_TEXT_BASE   0x80110000
> -
> -to:
> -
> -#define CONFIG_SYS_TEXT_BASE   0x81000100
> -
> -
> -2. Build U-Boot
> +1. Build U-Boot
>
>     mkdir b
>     make -j8 O=b/nyan-big CROSS_COMPILE=arm-linux-gnueabi- nyan-big_defconfig all
>
>
> -3. Select a .its file
> +2. Select a .its file
>
>  Select something from doc/chromium which matches your board, or create your
>  own.
> @@ -72,7 +59,7 @@ used by U-Boot. This is because the Chromebook expects to pass it to the
>  kernel, and crashes if it is not present.
>
>
> -4. Build and sign an image
> +3. Build and sign an image
>
>     ./b/nyan-big/tools/mkimage -f doc/chromium/nyan-big.its u-boot-chromium.fit
>     echo test >dummy.txt
> @@ -82,7 +69,7 @@ kernel, and crashes if it is not present.
>         --bootloader dummy.txt --pack u-boot.kpart
>
>
> -5. Prepare an SD card
> +4. Prepare an SD card
>
>     DISK=/dev/sdc   # Replace with your actual SD card device
>     sudo cgpt create $DISK
> @@ -91,12 +78,12 @@ kernel, and crashes if it is not present.
>     sudo gdisk $DISK   # Enter command 'w' to write a protective MBR to the disk
>
>
> -6. Write U-Boot to the SD card
> +5. Write U-Boot to the SD card
>
>     sudo dd if=u-boot.kpart of=/dev/sdc1; sync
>
>
> -7. Start it up
> +6. Start it up
>
>  Reboot the device in dev mode. Make sure that you have USB booting enabled. To
>  do this, login as root (via Ctrl-Alt-forward_arrow) and type
> @@ -115,7 +102,7 @@ mode screen. It should show something like the following on the display:
>     Tegra124 (Nyan-big) #
>
>
> -8. Known problems
> +7. Known problems
>
>  On the serial console the word MMC is chopped at the start of the line:
>
> --
> 2.17.1
>
Tom Rini July 6, 2018, 6:05 p.m. UTC | #3
On Fri, Jul 06, 2018 at 05:31:00PM +0000, Tom Warren wrote:

> Applied to tegra-master, just waiting on our automated build/test framework to give it a green light, then I'll issue a PR to TomR.  Sorry for the delay.

Please note that the release is scheduled for Monday, so if you have
stuff that should be in the release, that's OK, but otherwise it'll be
taken after.  Thanks!

> 
> Tom
> 
> -----Original Message-----
> From: Peter Robinson <pbrobinson@gmail.com> 
> Sent: Thursday, July 5, 2018 11:38 PM
> To: Allen Martin <AMartin@nvidia.com>; Simon Glass <sjg@chromium.org>; Tom Warren <TWarren@nvidia.com>; u-boot@lists.denx.de
> Cc: Peter Robinson <pbrobinson@gmail.com>
> Subject: Re: [PATCH v3] tegra: nyan-big: Update CONFIG_SYS_TEXT to the default in README.chromium
> 
> Tom,
> 
> Ping, could we get this applied please?
> 
> Peter
> 
> On Sun, Jun 10, 2018 at 6:17 AM, Peter Robinson <pbrobinson@gmail.com> wrote:
> > To build U-Boot on a Nyan Big Chromebook the docs outline adjusting 
> > the Tegra124 defined CONFIG_SYS_TEXT_BASE but this has since been 
> > moved to individual config files. We should have the default required 
> > for U-Boot chain loading on the chromebook as the default 
> > CONFIG_SYS_TEXT_BASE and update the docs to remove this now non required step.
> >
> > Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> > ---
> >
> > v3: Update commit message
> > v2: Update to 2018.07 RC1
> >
> >  configs/nyan-big_defconfig |  2 +-
> >  doc/README.chromium        | 27 +++++++--------------------
> >  2 files changed, 8 insertions(+), 21 deletions(-)
> >
> > diff --git a/configs/nyan-big_defconfig b/configs/nyan-big_defconfig 
> > index 8868d1f9e10..3b64c643716 100644
> > --- a/configs/nyan-big_defconfig
> > +++ b/configs/nyan-big_defconfig
> > @@ -1,6 +1,6 @@
> >  CONFIG_ARM=y
> >  CONFIG_TEGRA=y
> > -CONFIG_SYS_TEXT_BASE=0x80110000
> > +CONFIG_SYS_TEXT_BASE=0x81000100
> >  CONFIG_DEBUG_UART_BASE=0x70006000
> >  CONFIG_DEBUG_UART_CLOCK=408000000
> >  CONFIG_TEGRA124=y
> > diff --git a/doc/README.chromium b/doc/README.chromium index 
> > 7bf4d874474..45eaeced2da 100644
> > --- a/doc/README.chromium
> > +++ b/doc/README.chromium
> > @@ -43,26 +43,13 @@ 
> > https://git.collabora.com/cgit/user/tomeu/u-boot.git/commit/?h=nyan-bi
> > g  https://lists.denx.de/pipermail/u-boot/2017-May/289491.html
> >  
> > https://github.com/chromeos-nvidia-androidtv/gnu-linux-on-acer-chromeb
> > ook-13#copy-data-to-the-sd-card
> >
> > -1. Patch U-Boot
> > -
> > -Open include/configs/tegra124-common.h
> > -
> > -Change:
> > -
> > -#define CONFIG_SYS_TEXT_BASE   0x80110000
> > -
> > -to:
> > -
> > -#define CONFIG_SYS_TEXT_BASE   0x81000100
> > -
> > -
> > -2. Build U-Boot
> > +1. Build U-Boot
> >
> >     mkdir b
> >     make -j8 O=b/nyan-big CROSS_COMPILE=arm-linux-gnueabi- 
> > nyan-big_defconfig all
> >
> >
> > -3. Select a .its file
> > +2. Select a .its file
> >
> >  Select something from doc/chromium which matches your board, or 
> > create your  own.
> > @@ -72,7 +59,7 @@ used by U-Boot. This is because the Chromebook 
> > expects to pass it to the  kernel, and crashes if it is not present.
> >
> >
> > -4. Build and sign an image
> > +3. Build and sign an image
> >
> >     ./b/nyan-big/tools/mkimage -f doc/chromium/nyan-big.its u-boot-chromium.fit
> >     echo test >dummy.txt
> > @@ -82,7 +69,7 @@ kernel, and crashes if it is not present.
> >         --bootloader dummy.txt --pack u-boot.kpart
> >
> >
> > -5. Prepare an SD card
> > +4. Prepare an SD card
> >
> >     DISK=/dev/sdc   # Replace with your actual SD card device
> >     sudo cgpt create $DISK
> > @@ -91,12 +78,12 @@ kernel, and crashes if it is not present.
> >     sudo gdisk $DISK   # Enter command 'w' to write a protective MBR to the disk
> >
> >
> > -6. Write U-Boot to the SD card
> > +5. Write U-Boot to the SD card
> >
> >     sudo dd if=u-boot.kpart of=/dev/sdc1; sync
> >
> >
> > -7. Start it up
> > +6. Start it up
> >
> >  Reboot the device in dev mode. Make sure that you have USB booting 
> > enabled. To  do this, login as root (via Ctrl-Alt-forward_arrow) and 
> > type @@ -115,7 +102,7 @@ mode screen. It should show something like the following on the display:
> >     Tegra124 (Nyan-big) #
> >
> >
> > -8. Known problems
> > +7. Known problems
> >
> >  On the serial console the word MMC is chopped at the start of the line:
> >
> > --
> > 2.17.1
> >
> --
> nvpublic
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
diff mbox series

Patch

diff --git a/configs/nyan-big_defconfig b/configs/nyan-big_defconfig
index 8868d1f9e10..3b64c643716 100644
--- a/configs/nyan-big_defconfig
+++ b/configs/nyan-big_defconfig
@@ -1,6 +1,6 @@ 
 CONFIG_ARM=y
 CONFIG_TEGRA=y
-CONFIG_SYS_TEXT_BASE=0x80110000
+CONFIG_SYS_TEXT_BASE=0x81000100
 CONFIG_DEBUG_UART_BASE=0x70006000
 CONFIG_DEBUG_UART_CLOCK=408000000
 CONFIG_TEGRA124=y
diff --git a/doc/README.chromium b/doc/README.chromium
index 7bf4d874474..45eaeced2da 100644
--- a/doc/README.chromium
+++ b/doc/README.chromium
@@ -43,26 +43,13 @@  https://git.collabora.com/cgit/user/tomeu/u-boot.git/commit/?h=nyan-big
 https://lists.denx.de/pipermail/u-boot/2017-May/289491.html
 https://github.com/chromeos-nvidia-androidtv/gnu-linux-on-acer-chromebook-13#copy-data-to-the-sd-card
 
-1. Patch U-Boot
-
-Open include/configs/tegra124-common.h
-
-Change:
-
-#define CONFIG_SYS_TEXT_BASE	0x80110000
-
-to:
-
-#define CONFIG_SYS_TEXT_BASE	0x81000100
-
-
-2. Build U-Boot
+1. Build U-Boot
 
    mkdir b
    make -j8 O=b/nyan-big CROSS_COMPILE=arm-linux-gnueabi- nyan-big_defconfig all
 
 
-3. Select a .its file
+2. Select a .its file
 
 Select something from doc/chromium which matches your board, or create your
 own.
@@ -72,7 +59,7 @@  used by U-Boot. This is because the Chromebook expects to pass it to the
 kernel, and crashes if it is not present.
 
 
-4. Build and sign an image
+3. Build and sign an image
 
    ./b/nyan-big/tools/mkimage -f doc/chromium/nyan-big.its u-boot-chromium.fit
    echo test >dummy.txt
@@ -82,7 +69,7 @@  kernel, and crashes if it is not present.
 	--bootloader dummy.txt --pack u-boot.kpart
 
 
-5. Prepare an SD card
+4. Prepare an SD card
 
    DISK=/dev/sdc   # Replace with your actual SD card device
    sudo cgpt create $DISK
@@ -91,12 +78,12 @@  kernel, and crashes if it is not present.
    sudo gdisk $DISK   # Enter command 'w' to write a protective MBR to the disk
 
 
-6. Write U-Boot to the SD card
+5. Write U-Boot to the SD card
 
    sudo dd if=u-boot.kpart of=/dev/sdc1; sync
 
 
-7. Start it up
+6. Start it up
 
 Reboot the device in dev mode. Make sure that you have USB booting enabled. To
 do this, login as root (via Ctrl-Alt-forward_arrow) and type
@@ -115,7 +102,7 @@  mode screen. It should show something like the following on the display:
    Tegra124 (Nyan-big) #
 
 
-8. Known problems
+7. Known problems
 
 On the serial console the word MMC is chopped at the start of the line: