From patchwork Mon Jun 4 16:03:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfgang Denk X-Patchwork-Id: 925145 X-Patchwork-Delegate: wd@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=denx.de Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 41009W6jDgz9s08 for ; Tue, 5 Jun 2018 02:03:58 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 1CD57C21F88; Mon, 4 Jun 2018 16:03:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id DAC73C21E89; Mon, 4 Jun 2018 16:03:49 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 2AEB0C21E89; Mon, 4 Jun 2018 16:03:48 +0000 (UTC) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by lists.denx.de (Postfix) with ESMTPS id C8FEBC21BE5 for ; Mon, 4 Jun 2018 16:03:47 +0000 (UTC) Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 41009H4X5bz1qyB5 for ; Mon, 4 Jun 2018 18:03:47 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 41009H4QySz1qqyB for ; Mon, 4 Jun 2018 18:03:47 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id FFLtXRSQY141 for ; Mon, 4 Jun 2018 18:03:47 +0200 (CEST) X-Auth-Info: 4ROAmn+nrzjN4chJpMy7EwMJTxJs0qxydYWddrd8qBg= Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA for ; Mon, 4 Jun 2018 18:03:47 +0200 (CEST) Received: by janitor.denx.de (Postfix, from userid 119) id 8B69F25F; Mon, 4 Jun 2018 18:03:46 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 5D95B7C; Mon, 4 Jun 2018 18:03:44 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 26D8F240040; Mon, 4 Jun 2018 18:03:44 +0200 (CEST) To: Tom Rini From: Wolfgang Denk MIME-Version: 1.0 Date: Mon, 04 Jun 2018 18:03:44 +0200 Message-Id: <20180604160344.26D8F240040@gemini.denx.de> Cc: u-boot@lists.denx.de Subject: [U-Boot] Unclear patch origin ? X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Dear Tom, I wonder where commit b5351a439088dfffd83bfaac81f604344ee2e3bd Author: Tom Rini Date: Sun Jun 3 16:10:22 2018 -0400 SPDX: Fixup tags from latest EFI PR Signed-off-by: Tom Rini (and maybe more) is/are coming from. I cannot see any trace of this on the U-Boot mailing list. Which means, the patch was probably checked in without any review taking place? What is the process here? What I really wonder about is this part of the commit: i. e. you change the C++ comment style into classic C style - which we discussed at length, and you told me that was deprecated at this place? I can't understand what is going on here... Best regards, Wolfgang Denk --- a/arch/sandbox/include/asm/setjmp.h +++ b/arch/sandbox/include/asm/setjmp.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * (C) 2018 Google, Inc * Written by Simon Glass