| Message ID | 20180604160344.26D8F240040@gemini.denx.de |
|---|---|
| State | Not Applicable |
| Delegated to: | Wolfgang Denk |
| Headers | show |
| Series | [U-Boot] Unclear patch origin ? | expand |
On Mon, Jun 04, 2018 at 06:03:44PM +0200, Wolfgang Denk wrote: > Dear Tom, > > I wonder where > > commit b5351a439088dfffd83bfaac81f604344ee2e3bd > Author: Tom Rini <trini@konsulko.com> > Date: Sun Jun 3 16:10:22 2018 -0400 > > SPDX: Fixup tags from latest EFI PR > > Signed-off-by: Tom Rini <trini@konsulko.com> > > (and maybe more) is/are coming from. I cannot see any trace of this > on the U-Boot mailing list. Which means, the patch was probably > checked in without any review taking place? What is the process > here? > > > What I really wonder about is this part of the commit: > > --- a/arch/sandbox/include/asm/setjmp.h > +++ b/arch/sandbox/include/asm/setjmp.h > @@ -1,4 +1,4 @@ > -// SPDX-License-Identifier: GPL-2.0+ > +/* SPDX-License-Identifier: GPL-2.0+ */ > /* > * (C) 2018 Google, Inc > * Written by Simon Glass <sjg@chromium.org> > > > i. e. you change the C++ comment style into classic C style - which > we discussed at length, and you told me that was deprecated at this > place? > > I can't understand what is going on here... Trivial checkpatch.pl fixes and correct-by-inspection warning fixes don't get posted (and if I can figure out and fix them quickly, that's less of a burden on me than rejecting a change). When it doesn't come in via signed tag I often amend and signed-off-by and briefly note that was changed in brackets. In this case it's following the documented style. I posted the patch to update Licenses/README to have the same relevant text as the kernel. In this case: C source: // SPDX-License-Identifier: <SPDX License Expression> C header: /* SPDX-License-Identifier: <SPDX License Expression> */ ... If a specific tool cannot handle the standard comment style, then the appropriate comment mechanism which the tool accepts shall be used. This is the reason for having the "/\* \*/" style comment in C header files. There was build breakage observed with generated .lds files where 'ld' failed to parse the C++ comment. This has been fixed by now, but there are still older assembler tools which cannot handle C++ style comments. One of the things on my mental TODO list for the -rc1 email today was to let everyone know that I expect people to make use of ./scripts/checkpatch.pl --git and make sure that if there are WARNING / ERROR / CHECK statements they know why they're showing up.
--- a/arch/sandbox/include/asm/setjmp.h +++ b/arch/sandbox/include/asm/setjmp.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * (C) 2018 Google, Inc * Written by Simon Glass <sjg@chromium.org>
Dear Tom, I wonder where commit b5351a439088dfffd83bfaac81f604344ee2e3bd Author: Tom Rini <trini@konsulko.com> Date: Sun Jun 3 16:10:22 2018 -0400 SPDX: Fixup tags from latest EFI PR Signed-off-by: Tom Rini <trini@konsulko.com> (and maybe more) is/are coming from. I cannot see any trace of this on the U-Boot mailing list. Which means, the patch was probably checked in without any review taking place? What is the process here? What I really wonder about is this part of the commit: i. e. you change the C++ comment style into classic C style - which we discussed at length, and you told me that was deprecated at this place? I can't understand what is going on here... Best regards, Wolfgang Denk