| Message ID | 20180321134445.19646-1-felipe.balbi@linux.intel.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot] arm: dts: am4372: fix DTC warnings | expand |
On Wed, Mar 21, 2018 at 03:44:45PM +0200, Felipe Balbi wrote: > The following warnings are fixed: > > arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@48038000 > arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@4803C000 > arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): Missing interrupt-controller or interrupt-map property in /ocp/gpmc@50000000 > arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): Missing #interrupt-cells in interrupt-parent /ocp/gpmc@50000000 > arch/arm/dts/am437x-gp-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@48038000 > arch/arm/dts/am437x-gp-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@4803C000 > arch/arm/dts/am437x-idk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@48038000 > arch/arm/dts/am437x-idk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@4803C000 > arch/arm/dts/am437x-sk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@48038000 > arch/arm/dts/am437x-sk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@4803C000 > > The fix was basically to copy the missing data from mainline linux. Shouldn't we just re-sync with v4.16-rc? Thanks!
Hi, Tom Rini <trini@konsulko.com> writes: > On Wed, Mar 21, 2018 at 03:44:45PM +0200, Felipe Balbi wrote: >> The following warnings are fixed: >> >> arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@48038000 >> arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@4803C000 >> arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): Missing interrupt-controller or interrupt-map property in /ocp/gpmc@50000000 >> arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): Missing #interrupt-cells in interrupt-parent /ocp/gpmc@50000000 >> arch/arm/dts/am437x-gp-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@48038000 >> arch/arm/dts/am437x-gp-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@4803C000 >> arch/arm/dts/am437x-idk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@48038000 >> arch/arm/dts/am437x-idk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@4803C000 >> arch/arm/dts/am437x-sk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@48038000 >> arch/arm/dts/am437x-sk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@4803C000 >> >> The fix was basically to copy the missing data from mainline linux. > > Shouldn't we just re-sync with v4.16-rc? Thanks! sure, if you prefer doing that. But in that case, it seems like extracting Linux's DTS to its own project (linux-dts.git??) and using that as submodule would be far better.
On Thu, Mar 22, 2018 at 09:57:46AM +0200, Felipe Balbi wrote: > > Hi, > > Tom Rini <trini@konsulko.com> writes: > > On Wed, Mar 21, 2018 at 03:44:45PM +0200, Felipe Balbi wrote: > >> The following warnings are fixed: > >> > >> arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@48038000 > >> arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@4803C000 > >> arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): Missing interrupt-controller or interrupt-map property in /ocp/gpmc@50000000 > >> arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): Missing #interrupt-cells in interrupt-parent /ocp/gpmc@50000000 > >> arch/arm/dts/am437x-gp-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@48038000 > >> arch/arm/dts/am437x-gp-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@4803C000 > >> arch/arm/dts/am437x-idk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@48038000 > >> arch/arm/dts/am437x-idk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@4803C000 > >> arch/arm/dts/am437x-sk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@48038000 > >> arch/arm/dts/am437x-sk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@4803C000 > >> > >> The fix was basically to copy the missing data from mainline linux. > > > > Shouldn't we just re-sync with v4.16-rc? Thanks! > > sure, if you prefer doing that. But in that case, it seems like > extracting Linux's DTS to its own project (linux-dts.git??) and using > that as submodule would be far better. Except we also have our own files in arch/*/dts/ so we expect people to just sync the DTS files they use as-needed.
diff --git a/arch/arm/dts/am4372.dtsi b/arch/arm/dts/am4372.dtsi index 3ffa8e016e08..5c205f0ff0fa 100644 --- a/arch/arm/dts/am4372.dtsi +++ b/arch/arm/dts/am4372.dtsi @@ -764,7 +764,8 @@ reg = <0x48038000 0x2000>, <0x46000000 0x400000>; reg-names = "mpu", "dat"; - interrupts = <80>, <81>; + interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "tx", "rx"; status = "disabled"; dmas = <&edma 8>, @@ -778,7 +779,8 @@ reg = <0x4803C000 0x2000>, <0x46400000 0x400000>; reg-names = "mpu", "dat"; - interrupts = <82>, <83>; + interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "tx", "rx"; status = "disabled"; dmas = <&edma 10>, @@ -807,6 +809,8 @@ gpmc,num-waitpins = <2>; #address-cells = <2>; #size-cells = <1>; + interrupt-controller; + #interrupt-cells = <2>; status = "disabled"; };
The following warnings are fixed: arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@48038000 arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@4803C000 arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): Missing interrupt-controller or interrupt-map property in /ocp/gpmc@50000000 arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): Missing #interrupt-cells in interrupt-parent /ocp/gpmc@50000000 arch/arm/dts/am437x-gp-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@48038000 arch/arm/dts/am437x-gp-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@4803C000 arch/arm/dts/am437x-idk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@48038000 arch/arm/dts/am437x-idk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@4803C000 arch/arm/dts/am437x-sk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@48038000 arch/arm/dts/am437x-sk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp@4803C000 The fix was basically to copy the missing data from mainline linux. Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com> --- arch/arm/dts/am4372.dtsi | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)