From patchwork Wed Mar 21 02:40:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 888513 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="lTnVaBA0"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 405Yxl004cz9rxs for ; Wed, 21 Mar 2018 13:42:50 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 92067C21D56; Wed, 21 Mar 2018 02:41:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id AD998C21DF9; Wed, 21 Mar 2018 02:41:52 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 6041FC21DDC; Wed, 21 Mar 2018 02:41:23 +0000 (UTC) Received: from mail-pf0-f194.google.com (mail-pf0-f194.google.com [209.85.192.194]) by lists.denx.de (Postfix) with ESMTPS id 1CA17C21D56 for ; Wed, 21 Mar 2018 02:41:20 +0000 (UTC) Received: by mail-pf0-f194.google.com with SMTP id z10so1454306pfh.13 for ; Tue, 20 Mar 2018 19:41:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4aXe3YgdBYmsjLCJluNkNFjbNF3QDZRglGOdmILqme4=; b=lTnVaBA0kOJSd42k79gkgKKEsJRzkkj2JCm6zNyVaSHbfix+oCbh9m4MS02L6huzCA Jl+47z69/lgAFnq/ce/UyKsZysVTDLFw8ERVb2C42zmrOsl0UKq322qvmdpqU3tv8xtf utLvrRdkeQkvpHylluPiZIrVn5fdC9kZYr0u30cHk2FpITaTS/QVVk0Z9M0Bg82gnMBe vT/ZlFpxL7W3XYJde4T9ymzqIcS1+Q8RA1L0Nzi32wAp3fzjlokZucesO6NwCQXXQ1+U PmEcTZE5xyE419GQiCZ+cT3MieB4ISGICoBCA3WlivmXvat0Wwh4dQ5PZb3Cz4PR3BTX CUmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4aXe3YgdBYmsjLCJluNkNFjbNF3QDZRglGOdmILqme4=; b=f5cOuLlFzgRatTlbuE+JoSJMQPAIn2Kf1zdpjc+EcWORppAYUvnKBrbBhSXrONas6A GV2WdSSAjQCEY93yNNMYP3wUFybvQ558WDkElzVNdBJIPChxRmURXiedlS/clUli636Z Y2VpUj5/clLMujS1rVPO7JsWaOu6VMerTflRe4/x0XeNsMVtXj3XobD7cJLjtR71ZlZ3 IXrI5Qs1jSrV1F/IwdyaXozcadLvFwOqWyY/1BDof2sVaWOALMzLfB1BuSPAa+/Q9Iln SiJI9H3/sw4zlfxChtde/nFRG0ojjRrjm0JFUKlO9F82+lFbL3U9fsjSHhqUYbK1Qzkx nhLg== X-Gm-Message-State: AElRT7Hjgg6H/6ovQjYud+qlgmz3heY+R81AF1b4L2zycmiE/+4hCg4f T020eOATOvdzQ71kksb45DbpmHmh X-Google-Smtp-Source: AG47ELuK59vT7aOfpFZskOLJ34yEzg1je2Qam/Hw0Qs3iYWI4Qt3I4IgzTzeNm15VGweY4CRTUgtKA== X-Received: by 10.101.86.141 with SMTP id v13mr6843492pgs.353.1521600078552; Tue, 20 Mar 2018 19:41:18 -0700 (PDT) Received: from chrisp-dl.ws.atlnz.lc ([2001:df5:b000:22:3a2c:4aff:fe70:2b02]) by smtp.gmail.com with ESMTPSA id h10sm5187829pgf.19.2018.03.20.19.41.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 20 Mar 2018 19:41:17 -0700 (PDT) From: Chris Packham To: u-boot@lists.denx.de Date: Wed, 21 Mar 2018 15:40:37 +1300 Message-Id: <20180321024037.26393-6-judge.packham@gmail.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180321024037.26393-1-judge.packham@gmail.com> References: <20180321024037.26393-1-judge.packham@gmail.com> Cc: Marek Vasut , Chris Packham Subject: [U-Boot] [PATCH v1 5/5] rtc: rx8025: remove redundant code in rtc_reset X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" As of commit 1a1fa2406689 ("rtc: Set valid date after reset") the command "date reset" will set the date/time to 2000-01-01 0:00:00 after calling rtc_reset(). This means that the rx8025 implementation of rtc_reset() does not need to call rtc_set(). Signed-off-by: Chris Packham --- drivers/rtc/rx8025.c | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/rtc/rx8025.c b/drivers/rtc/rx8025.c index b4a149b73808..c43966a50d76 100644 --- a/drivers/rtc/rx8025.c +++ b/drivers/rtc/rx8025.c @@ -163,11 +163,10 @@ int rtc_set (struct rtc_time *tmp) } /* - * Reset the RTC. We setting the date back to 1970-01-01. + * Reset the RTC */ void rtc_reset (void) { - struct rtc_time tmp; uchar buf[16]; uchar ctl2; @@ -178,21 +177,6 @@ void rtc_reset (void) ctl2 &= ~(RTC_CTL2_BIT_PON | RTC_CTL2_BIT_VDET); ctl2 |= RTC_CTL2_BIT_XST | RTC_CTL2_BIT_VDSL; rtc_write (RTC_CTL2_REG_ADDR, ctl2); - - tmp.tm_year = 1970; - tmp.tm_mon = 1; - tmp.tm_mday= 1; - tmp.tm_hour = 0; - tmp.tm_min = 0; - tmp.tm_sec = 0; - - rtc_set(&tmp); - - printf ( "RTC: %4d-%02d-%02d %2d:%02d:%02d UTC\n", - tmp.tm_year, tmp.tm_mon, tmp.tm_mday, - tmp.tm_hour, tmp.tm_min, tmp.tm_sec); - - return; } /*