diff mbox series

[U-Boot,v1,3/5] rtc: mx27rtc: remove redundant code in rtc_reset

Message ID 20180321024037.26393-4-judge.packham@gmail.com
State Accepted
Commit fbd8179cbadd44a9a45ef3eff7c2b5b5aa56938a
Delegated to: Tom Rini
Headers show
Series rtc: remove redundant code in rtc_reset | expand

Commit Message

Chris Packham March 21, 2018, 2:40 a.m. UTC 
As of commit 1a1fa2406689 ("rtc: Set valid date after reset") the
command "date reset" will set the date/time to 2000-01-01 0:00:00 after
calling rtc_reset(). This means that the mx27rtc implementation of
rtc_reset() can be an empty stub function.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---

 drivers/rtc/mx27rtc.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Tom Rini April 7, 2018, 1:25 p.m. UTC | #1 
On Wed, Mar 21, 2018 at 03:40:35PM +1300, Chris Packham wrote:

> As of commit 1a1fa2406689 ("rtc: Set valid date after reset") the
> command "date reset" will set the date/time to 2000-01-01 0:00:00 after
> calling rtc_reset(). This means that the mx27rtc implementation of
> rtc_reset() can be an empty stub function.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/drivers/rtc/mx27rtc.c b/drivers/rtc/mx27rtc.c
index 29ccdf17301b..b42770e05bd9 100644
--- a/drivers/rtc/mx27rtc.c
+++ b/drivers/rtc/mx27rtc.c
@@ -61,9 +61,5 @@  int rtc_set(struct rtc_time *time)
 
 void rtc_reset(void)
 {
-	struct rtc_regs *rtc_regs = (struct rtc_regs *)IMX_RTC_BASE;
-
-	writel(0, &rtc_regs->dayr);
-	writel(0, &rtc_regs->hourmin);
-	writel(0, &rtc_regs->seconds);
+	/* nothing to do */
 }