| Message ID | 20180124095343.10978-1-jh80.chung@samsung.com |
|---|---|
| State | Superseded |
| Delegated to: | Jaehoon Chung |
| Headers | show |
| Series | [U-Boot] samsung: board: init the s2mps11 pmic during booting time | expand |
Hi Jaehoon, On 24 January 2018 at 15:23, Jaehoon Chung <jh80.chung@samsung.com> wrote: > Exynos5422 board has s2mps11 pmic. > If CONFIG_PMIC_S2MPS11 is enabled, it can initialize PMIC and Regulators > during booting time. > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > --- > board/samsung/common/exynos5-dt.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/board/samsung/common/exynos5-dt.c b/board/samsung/common/exynos5-dt.c > index a4eb351405..9189bf59b9 100644 > --- a/board/samsung/common/exynos5-dt.c > +++ b/board/samsung/common/exynos5-dt.c > @@ -93,7 +93,11 @@ int exynos_power_init(void) > struct udevice *dev; > int ret; > > +#ifdef CONFIG_PMIC_S2MPS11 > + ret = pmic_get("s2mps11_pmic", &dev); > +#else > ret = pmic_get("max77686", &dev); > +#endif > if (!ret) { > /* TODO(sjg@chromium.org): Move into the clock/pmic API */ > ret = pmic_clrsetbits(dev, MAX77686_REG_PMIC_32KHZ, 0, > -- > 2.15.1 > Please add my. Tested-by: Anand Moon <linux.amoon@gmail.com> Best Regards -Anand
Hi, On 01/24/2018 09:47 PM, Anand Moon wrote: > Hi Jaehoon, > > On 24 January 2018 at 15:23, Jaehoon Chung <jh80.chung@samsung.com> wrote: >> Exynos5422 board has s2mps11 pmic. >> If CONFIG_PMIC_S2MPS11 is enabled, it can initialize PMIC and Regulators >> during booting time. I will resend the patch v2, this patch is getting "s2mps11_pmic". But after that, it's controlling MAX77686 pmic . if (!ret) { pmic_clrsetbits(dev, MAX77686....); } Will fix them. Best Regards, Jaehoon Chung >> >> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> >> --- >> board/samsung/common/exynos5-dt.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/board/samsung/common/exynos5-dt.c b/board/samsung/common/exynos5-dt.c >> index a4eb351405..9189bf59b9 100644 >> --- a/board/samsung/common/exynos5-dt.c >> +++ b/board/samsung/common/exynos5-dt.c >> @@ -93,7 +93,11 @@ int exynos_power_init(void) >> struct udevice *dev; >> int ret; >> >> +#ifdef CONFIG_PMIC_S2MPS11 >> + ret = pmic_get("s2mps11_pmic", &dev); >> +#else >> ret = pmic_get("max77686", &dev); >> +#endif >> if (!ret) { >> /* TODO(sjg@chromium.org): Move into the clock/pmic API */ >> ret = pmic_clrsetbits(dev, MAX77686_REG_PMIC_32KHZ, 0, >> -- >> 2.15.1 >> > > Please add my. > Tested-by: Anand Moon <linux.amoon@gmail.com> > > Best Regards > -Anand > > >
diff --git a/board/samsung/common/exynos5-dt.c b/board/samsung/common/exynos5-dt.c index a4eb351405..9189bf59b9 100644 --- a/board/samsung/common/exynos5-dt.c +++ b/board/samsung/common/exynos5-dt.c @@ -93,7 +93,11 @@ int exynos_power_init(void) struct udevice *dev; int ret; +#ifdef CONFIG_PMIC_S2MPS11 + ret = pmic_get("s2mps11_pmic", &dev); +#else ret = pmic_get("max77686", &dev); +#endif if (!ret) { /* TODO(sjg@chromium.org): Move into the clock/pmic API */ ret = pmic_clrsetbits(dev, MAX77686_REG_PMIC_32KHZ, 0,
Exynos5422 board has s2mps11 pmic. If CONFIG_PMIC_S2MPS11 is enabled, it can initialize PMIC and Regulators during booting time. Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> --- board/samsung/common/exynos5-dt.c | 4 ++++ 1 file changed, 4 insertions(+)