| Message ID | 20171218200942.23586-2-tuomas@tuxera.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | [U-Boot,1/2] mmc: sunxi: Support cd-inverted DT property | expand |
On Mon, Dec 18, 2017 at 10:09:42PM +0200, Tuomas Tynkkynen wrote: > After the previous commit which adds support for the cd-inverted > property to the sunxi MMC driver, driver-model MMC works fine on this > board. > > Signed-off-by: Tuomas Tynkkynen <tuomas@tuxera.com> > --- > configs/Linksprite_pcDuino3_Nano_defconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/configs/Linksprite_pcDuino3_Nano_defconfig b/configs/Linksprite_pcDuino3_Nano_defconfig > index 13538fafd1..44ce8b3ead 100644 > --- a/configs/Linksprite_pcDuino3_Nano_defconfig > +++ b/configs/Linksprite_pcDuino3_Nano_defconfig > @@ -17,9 +17,11 @@ CONFIG_SPL_I2C_SUPPORT=y > # CONFIG_SPL_ISO_PARTITION is not set > # CONFIG_SPL_EFI_PARTITION is not set > CONFIG_SCSI_AHCI=y > +CONFIG_DM_MMC=y > CONFIG_ETH_DESIGNWARE=y > CONFIG_RGMII=y > CONFIG_SUN7I_GMAC=y > CONFIG_SCSI=y > +CONFIG_DM_SCSI=y Those should not be in a single defconfig, but enabled for all the Allwinner boards (that have SATA and MMC). Maxime
On Wed, 2017-12-20 at 13:26 +0100, Maxime Ripard wrote: > On Mon, Dec 18, 2017 at 10:09:42PM +0200, Tuomas Tynkkynen wrote: > > After the previous commit which adds support for the cd-inverted > > property to the sunxi MMC driver, driver-model MMC works fine on > > this > > board. > > > > Signed-off-by: Tuomas Tynkkynen <tuomas@tuxera.com> > > --- > > configs/Linksprite_pcDuino3_Nano_defconfig | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/configs/Linksprite_pcDuino3_Nano_defconfig > > b/configs/Linksprite_pcDuino3_Nano_defconfig > > index 13538fafd1..44ce8b3ead 100644 > > --- a/configs/Linksprite_pcDuino3_Nano_defconfig > > +++ b/configs/Linksprite_pcDuino3_Nano_defconfig > > @@ -17,9 +17,11 @@ CONFIG_SPL_I2C_SUPPORT=y > > # CONFIG_SPL_ISO_PARTITION is not set > > # CONFIG_SPL_EFI_PARTITION is not set > > CONFIG_SCSI_AHCI=y > > +CONFIG_DM_MMC=y > > CONFIG_ETH_DESIGNWARE=y > > CONFIG_RGMII=y > > CONFIG_SUN7I_GMAC=y > > CONFIG_SCSI=y > > +CONFIG_DM_SCSI=y > > Those should not be in a single defconfig, but enabled for all the > Allwinner boards (that have SATA and MMC). > > Maxime > Makes sense. I don't have any other boards to test with so I just imitated Simon's change for the non-Nano pcduino3. I will try to see if this could be imply'd in Kconfig.
On Wed, Dec 20, 2017 at 03:37:13PM +0200, Tuomas Tynkkynen wrote: > On Wed, 2017-12-20 at 13:26 +0100, Maxime Ripard wrote: > > On Mon, Dec 18, 2017 at 10:09:42PM +0200, Tuomas Tynkkynen wrote: > > > After the previous commit which adds support for the cd-inverted > > > property to the sunxi MMC driver, driver-model MMC works fine on > > > this > > > board. > > > > > > Signed-off-by: Tuomas Tynkkynen <tuomas@tuxera.com> > > > --- > > > configs/Linksprite_pcDuino3_Nano_defconfig | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/configs/Linksprite_pcDuino3_Nano_defconfig > > > b/configs/Linksprite_pcDuino3_Nano_defconfig > > > index 13538fafd1..44ce8b3ead 100644 > > > --- a/configs/Linksprite_pcDuino3_Nano_defconfig > > > +++ b/configs/Linksprite_pcDuino3_Nano_defconfig > > > @@ -17,9 +17,11 @@ CONFIG_SPL_I2C_SUPPORT=y > > > # CONFIG_SPL_ISO_PARTITION is not set > > > # CONFIG_SPL_EFI_PARTITION is not set > > > CONFIG_SCSI_AHCI=y > > > +CONFIG_DM_MMC=y > > > CONFIG_ETH_DESIGNWARE=y > > > CONFIG_RGMII=y > > > CONFIG_SUN7I_GMAC=y > > > CONFIG_SCSI=y > > > +CONFIG_DM_SCSI=y > > > > Those should not be in a single defconfig, but enabled for all the > > Allwinner boards (that have SATA and MMC). > > > > Maxime > > > > Makes sense. I don't have any other boards to test with so I just > imitated Simon's change for the non-Nano pcduino3. > > I will try to see if this could be imply'd in Kconfig. You can also use a default y if ARCH_SUNXI. That's actually a better option, since imply still have a few glitches that generate an error when the situation is valid. Thanks! Maxime
diff --git a/configs/Linksprite_pcDuino3_Nano_defconfig b/configs/Linksprite_pcDuino3_Nano_defconfig index 13538fafd1..44ce8b3ead 100644 --- a/configs/Linksprite_pcDuino3_Nano_defconfig +++ b/configs/Linksprite_pcDuino3_Nano_defconfig @@ -17,9 +17,11 @@ CONFIG_SPL_I2C_SUPPORT=y # CONFIG_SPL_ISO_PARTITION is not set # CONFIG_SPL_EFI_PARTITION is not set CONFIG_SCSI_AHCI=y +CONFIG_DM_MMC=y CONFIG_ETH_DESIGNWARE=y CONFIG_RGMII=y CONFIG_SUN7I_GMAC=y CONFIG_SCSI=y +CONFIG_DM_SCSI=y CONFIG_USB_EHCI_HCD=y CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
After the previous commit which adds support for the cd-inverted property to the sunxi MMC driver, driver-model MMC works fine on this board. Signed-off-by: Tuomas Tynkkynen <tuomas@tuxera.com> --- configs/Linksprite_pcDuino3_Nano_defconfig | 2 ++ 1 file changed, 2 insertions(+)