diff mbox series

[U-Boot] armv8: ls1043a: disable IFC in SPL only when QSPI is used

Message ID 20170913054617.20501-1-yangbo.lu@nxp.com
State Changes Requested
Delegated to: York Sun
Headers show
Series [U-Boot] armv8: ls1043a: disable IFC in SPL only when QSPI is used | expand

Commit Message

Yangbo Lu Sept. 13, 2017, 5:46 a.m. UTC
SD boot couldn't work with ls1043aqds_sdcard_ifc_defconfig since
IFC in SPL is disabled. This patch is to fix this issue.

Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
---
 include/configs/ls1043a_common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

York Sun Sept. 14, 2017, 9:18 p.m. UTC | #1
On 09/12/2017 11:03 PM, Yangbo Lu wrote:
> SD boot couldn't work with ls1043aqds_sdcard_ifc_defconfig since
> IFC in SPL is disabled. This patch is to fix this issue.

You subject matches the change. But the commit message is confusing. 
Please rephrase it.

York

> 
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
> ---
>   include/configs/ls1043a_common.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/configs/ls1043a_common.h b/include/configs/ls1043a_common.h
> index 002830c27e..1f9efffa56 100644
> --- a/include/configs/ls1043a_common.h
> +++ b/include/configs/ls1043a_common.h
> @@ -22,7 +22,7 @@
>   #if (defined(CONFIG_SPL_BUILD) && defined(CONFIG_NAND_BOOT))
>   #define SPL_NO_MMC
>   #endif
> -#if (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SD_BOOT))
> +#if (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SD_BOOT_QSPI))
>   #define SPL_NO_IFC
>   #endif
>   
>
Yangbo Lu Sept. 15, 2017, 2:11 a.m. UTC | #2
Hi York,

Thanks for your comments.
The v2 patch had been sent out.

Best regards,
Yangbo Lu

-----Original Message-----
From: York Sun 

Sent: 2017年9月15日 5:18
To: Y.b. Lu <yangbo.lu@nxp.com>; u-boot@lists.denx.de
Subject: Re: [PATCH] armv8: ls1043a: disable IFC in SPL only when QSPI is used

On 09/12/2017 11:03 PM, Yangbo Lu wrote:
> SD boot couldn't work with ls1043aqds_sdcard_ifc_defconfig since IFC 

> in SPL is disabled. This patch is to fix this issue.


You subject matches the change. But the commit message is confusing. 
Please rephrase it.

York

> 

> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>

> ---

>   include/configs/ls1043a_common.h | 2 +-

>   1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/include/configs/ls1043a_common.h 

> b/include/configs/ls1043a_common.h

> index 002830c27e..1f9efffa56 100644

> --- a/include/configs/ls1043a_common.h

> +++ b/include/configs/ls1043a_common.h

> @@ -22,7 +22,7 @@

>   #if (defined(CONFIG_SPL_BUILD) && defined(CONFIG_NAND_BOOT))

>   #define SPL_NO_MMC

>   #endif

> -#if (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SD_BOOT))

> +#if (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SD_BOOT_QSPI))

>   #define SPL_NO_IFC

>   #endif

>   

>
diff mbox series

Patch

diff --git a/include/configs/ls1043a_common.h b/include/configs/ls1043a_common.h
index 002830c27e..1f9efffa56 100644
--- a/include/configs/ls1043a_common.h
+++ b/include/configs/ls1043a_common.h
@@ -22,7 +22,7 @@ 
 #if (defined(CONFIG_SPL_BUILD) && defined(CONFIG_NAND_BOOT))
 #define SPL_NO_MMC
 #endif
-#if (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SD_BOOT))
+#if (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SD_BOOT_QSPI))
 #define SPL_NO_IFC
 #endif