| Message ID | 20170913021751.9289-3-icenowy@aosc.io |
|---|---|
| State | Superseded |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | Allwinner DE2 HDMI SimpleFB support | expand |
Hi, On Wed, Sep 13, 2017 at 10:17:50AM +0800, Icenowy Zheng wrote: > Add an option to indicate that the video driver should setup a SimpleFB > node that passes the video framebuffer initialized by U-Boot to the > operating system kernel. > > Currently only the Allwinner DE2 driver uses this option. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > --- > drivers/video/Kconfig | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > index 082cc4a528..e4e71763f5 100644 > --- a/drivers/video/Kconfig > +++ b/drivers/video/Kconfig > @@ -601,4 +601,14 @@ config VIDEO_DW_HDMI > rather requires a SoC-specific glue driver to call it), it > can not be enabled from the configuration menu. > > +config VIDEO_DT_SIMPLEFB > + bool "Enable SimpleFB support for passing framebuffer to OS" > + depends on VIDEO_DE2 > + default y SIMPLEFB is also used by other platforms, but most platforms also won't use it. Adding an imply VIDEO_DT_SIMPLEFB to VIDEO_DE2 would make everyone happy I guess. Maxime
在 2017-09-13 20:04，Maxime Ripard 写道： > Hi, > > On Wed, Sep 13, 2017 at 10:17:50AM +0800, Icenowy Zheng wrote: >> Add an option to indicate that the video driver should setup a >> SimpleFB >> node that passes the video framebuffer initialized by U-Boot to the >> operating system kernel. >> >> Currently only the Allwinner DE2 driver uses this option. >> >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io> >> --- >> drivers/video/Kconfig | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig >> index 082cc4a528..e4e71763f5 100644 >> --- a/drivers/video/Kconfig >> +++ b/drivers/video/Kconfig >> @@ -601,4 +601,14 @@ config VIDEO_DW_HDMI >> rather requires a SoC-specific glue driver to call it), it >> can not be enabled from the configuration menu. >> >> +config VIDEO_DT_SIMPLEFB >> + bool "Enable SimpleFB support for passing framebuffer to OS" >> + depends on VIDEO_DE2 >> + default y > > SIMPLEFB is also used by other platforms, but most platforms also > won't use it. > > Adding an imply VIDEO_DT_SIMPLEFB to VIDEO_DE2 would make everyone > happy I guess. Then should I drop the "depends on VIDEO_DE2"? > > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com
> SIMPLEFB is also used by other platforms, but most platforms also > won't use it. > > Adding an imply VIDEO_DT_SIMPLEFB to VIDEO_DE2 would make everyone > happy I guess. You meant adding a "select VIDEO_DT_SIMPLEFB" to VIDEO_DE2 ?
Hi, On 13/09/17 16:50, Vincent Legoll wrote: >> SIMPLEFB is also used by other platforms, but most platforms also >> won't use it. >> >> Adding an imply VIDEO_DT_SIMPLEFB to VIDEO_DE2 would make everyone >> happy I guess. > > You meant adding a "select VIDEO_DT_SIMPLEFB" to VIDEO_DE2 ? I think he explicitly meant "imply", which is a rather recent addition to Kconfig [1]: =============== - weak reverse dependencies: "imply" <symbol> ["if" <expr>] This is similar to "select" as it enforces a lower limit on another symbol except that the "implied" symbol's value may still be set to n from a direct dependency or with a visible prompt. =============== [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/kbuild/kconfig-language.txt#n116 Cheers, Andre
On Wed, Sep 13, 2017 at 09:17:21PM +0800, icenowy@aosc.io wrote: > 在 2017-09-13 20:04，Maxime Ripard 写道： > > Hi, > > > > On Wed, Sep 13, 2017 at 10:17:50AM +0800, Icenowy Zheng wrote: > > > Add an option to indicate that the video driver should setup a > > > SimpleFB > > > node that passes the video framebuffer initialized by U-Boot to the > > > operating system kernel. > > > > > > Currently only the Allwinner DE2 driver uses this option. > > > > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > > > --- > > > drivers/video/Kconfig | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > > > index 082cc4a528..e4e71763f5 100644 > > > --- a/drivers/video/Kconfig > > > +++ b/drivers/video/Kconfig > > > @@ -601,4 +601,14 @@ config VIDEO_DW_HDMI > > > rather requires a SoC-specific glue driver to call it), it > > > can not be enabled from the configuration menu. > > > > > > +config VIDEO_DT_SIMPLEFB > > > + bool "Enable SimpleFB support for passing framebuffer to OS" > > > + depends on VIDEO_DE2 > > > + default y > > > > SIMPLEFB is also used by other platforms, but most platforms also > > won't use it. > > > > Adding an imply VIDEO_DT_SIMPLEFB to VIDEO_DE2 would make everyone > > happy I guess. > > Then should I drop the "depends on VIDEO_DE2"? Yes. Maxime
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index 082cc4a528..e4e71763f5 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -601,4 +601,14 @@ config VIDEO_DW_HDMI rather requires a SoC-specific glue driver to call it), it can not be enabled from the configuration menu. +config VIDEO_DT_SIMPLEFB + bool "Enable SimpleFB support for passing framebuffer to OS" + depends on VIDEO_DE2 + default y + help + Enables the code to pass the framebuffer to the kernel as a + simple framebuffer in the device tree. + The video output is initialized by U-Boot, and kept by the + kernel. + endmenu
Add an option to indicate that the video driver should setup a SimpleFB node that passes the video framebuffer initialized by U-Boot to the operating system kernel. Currently only the Allwinner DE2 driver uses this option. Signed-off-by: Icenowy Zheng <icenowy@aosc.io> --- drivers/video/Kconfig | 10 ++++++++++ 1 file changed, 10 insertions(+)