diff mbox

[U-Boot] x86: extend baudrate table with 57600

Message ID 20170606115138.7845-1-christian.gmeiner@gmail.com
State Changes Requested
Delegated to: Bin Meng
Headers show

Commit Message

Christian Gmeiner June 6, 2017, 11:51 a.m. UTC 
Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
---
 include/configs/x86-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini June 6, 2017, 8:04 p.m. UTC | #1 
On Tue, Jun 06, 2017 at 01:51:38PM +0200, Christian Gmeiner wrote:

> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> ---
>  include/configs/x86-common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h
> index b5ef8b5..9a97714 100644
> --- a/include/configs/x86-common.h
> +++ b/include/configs/x86-common.h
> @@ -56,7 +56,7 @@
>   * Serial Configuration
>   */
>  #define CONFIG_SYS_BAUDRATE_TABLE	{300, 600, 1200, 2400, 4800, \
> -					 9600, 19200, 38400, 115200}
> +					 9600, 19200, 38400, 57600, 115200}
>  #define CONFIG_SYS_NS16550_PORT_MAPPED
>  
>  #define CONFIG_CMDLINE_EDITING

Can we just use the fall back table instead?  Thanks!
Christian Gmeiner June 8, 2017, 7:38 a.m. UTC | #2 
Hi Tom

2017-06-06 22:04 GMT+02:00 Tom Rini <trini@konsulko.com>:
> On Tue, Jun 06, 2017 at 01:51:38PM +0200, Christian Gmeiner wrote:
>
>> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
>> ---
>>  include/configs/x86-common.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h
>> index b5ef8b5..9a97714 100644
>> --- a/include/configs/x86-common.h
>> +++ b/include/configs/x86-common.h
>> @@ -56,7 +56,7 @@
>>   * Serial Configuration
>>   */
>>  #define CONFIG_SYS_BAUDRATE_TABLE    {300, 600, 1200, 2400, 4800, \
>> -                                      9600, 19200, 38400, 115200}
>> +                                      9600, 19200, 38400, 57600, 115200}
>>  #define CONFIG_SYS_NS16550_PORT_MAPPED
>>
>>  #define CONFIG_CMDLINE_EDITING
>
> Can we just use the fall back table instead?  Thanks!
>

Can you point me to the "fall back table"?

thanks
--
Christian Gmeiner, MSc

https://www.youtube.com/user/AloryOFFICIAL
https://soundcloud.com/christian-gmeiner
Tom Rini June 9, 2017, 12:58 a.m. UTC | #3 
On Thu, Jun 08, 2017 at 09:38:49AM +0200, Christian Gmeiner wrote:
> Hi Tom
> 
> 2017-06-06 22:04 GMT+02:00 Tom Rini <trini@konsulko.com>:
> > On Tue, Jun 06, 2017 at 01:51:38PM +0200, Christian Gmeiner wrote:
> >
> >> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> >> ---
> >>  include/configs/x86-common.h | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h
> >> index b5ef8b5..9a97714 100644
> >> --- a/include/configs/x86-common.h
> >> +++ b/include/configs/x86-common.h
> >> @@ -56,7 +56,7 @@
> >>   * Serial Configuration
> >>   */
> >>  #define CONFIG_SYS_BAUDRATE_TABLE    {300, 600, 1200, 2400, 4800, \
> >> -                                      9600, 19200, 38400, 115200}
> >> +                                      9600, 19200, 38400, 57600, 115200}
> >>  #define CONFIG_SYS_NS16550_PORT_MAPPED
> >>
> >>  #define CONFIG_CMDLINE_EDITING
> >
> > Can we just use the fall back table instead?  Thanks!
> 
> Can you point me to the "fall back table"?

If one isn't defined the one in <config_fallbacks.h> is used.
Bin Meng June 22, 2017, 6:50 a.m. UTC | #4 
Hi Christian,

On Fri, Jun 9, 2017 at 8:58 AM, Tom Rini <trini@konsulko.com> wrote:
> On Thu, Jun 08, 2017 at 09:38:49AM +0200, Christian Gmeiner wrote:
>> Hi Tom
>>
>> 2017-06-06 22:04 GMT+02:00 Tom Rini <trini@konsulko.com>:
>> > On Tue, Jun 06, 2017 at 01:51:38PM +0200, Christian Gmeiner wrote:
>> >
>> >> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
>> >> ---
>> >>  include/configs/x86-common.h | 2 +-
>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >>
>> >> diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h
>> >> index b5ef8b5..9a97714 100644
>> >> --- a/include/configs/x86-common.h
>> >> +++ b/include/configs/x86-common.h
>> >> @@ -56,7 +56,7 @@
>> >>   * Serial Configuration
>> >>   */
>> >>  #define CONFIG_SYS_BAUDRATE_TABLE    {300, 600, 1200, 2400, 4800, \
>> >> -                                      9600, 19200, 38400, 115200}
>> >> +                                      9600, 19200, 38400, 57600, 115200}
>> >>  #define CONFIG_SYS_NS16550_PORT_MAPPED
>> >>
>> >>  #define CONFIG_CMDLINE_EDITING
>> >
>> > Can we just use the fall back table instead?  Thanks!
>>
>> Can you point me to the "fall back table"?
>
> If one isn't defined the one in <config_fallbacks.h> is used.

Can you respin the patch per Tom's suggestion? Thanks!

Regards,
Bin
Christian Gmeiner Sept. 4, 2018, 10:07 a.m. UTC | #5 
Hi all,

I totally forgot to answer that mail - but as I need this change my
motivation is back.

Am Do., 22. Juni 2017 um 08:50 Uhr schrieb Bin Meng <bmeng.cn@gmail.com>:
>
> Hi Christian,
>
> On Fri, Jun 9, 2017 at 8:58 AM, Tom Rini <trini@konsulko.com> wrote:
> > On Thu, Jun 08, 2017 at 09:38:49AM +0200, Christian Gmeiner wrote:
> >> Hi Tom
> >>
> >> 2017-06-06 22:04 GMT+02:00 Tom Rini <trini@konsulko.com>:
> >> > On Tue, Jun 06, 2017 at 01:51:38PM +0200, Christian Gmeiner wrote:
> >> >
> >> >> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> >> >> ---
> >> >>  include/configs/x86-common.h | 2 +-
> >> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >> >>
> >> >> diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h
> >> >> index b5ef8b5..9a97714 100644
> >> >> --- a/include/configs/x86-common.h
> >> >> +++ b/include/configs/x86-common.h
> >> >> @@ -56,7 +56,7 @@
> >> >>   * Serial Configuration
> >> >>   */
> >> >>  #define CONFIG_SYS_BAUDRATE_TABLE    {300, 600, 1200, 2400, 4800, \
> >> >> -                                      9600, 19200, 38400, 115200}
> >> >> +                                      9600, 19200, 38400, 57600, 115200}
> >> >>  #define CONFIG_SYS_NS16550_PORT_MAPPED
> >> >>
> >> >>  #define CONFIG_CMDLINE_EDITING
> >> >
> >> > Can we just use the fall back table instead?  Thanks!
> >>
> >> Can you point me to the "fall back table"?
> >
> > If one isn't defined the one in <config_fallbacks.h> is used.
>

The fallback table looks okay and has 57600 as baud rate in it. The problematic
part is the xf86-common.h which defines CONFIG_SYS_BAUDRATE_TABLE and
as a result the fallback table plays no role here.

> Can you respin the patch per Tom's suggestion? Thanks!

I think that the current patch is okay as Tom's suggestion does not fly.
Bin Meng Sept. 5, 2018, 4:57 a.m. UTC | #6 
Hi Christian,

On Tue, Sep 4, 2018 at 6:07 PM Christian Gmeiner
<christian.gmeiner@gmail.com> wrote:
>
> Hi all,
>
> I totally forgot to answer that mail - but as I need this change my
> motivation is back.
>
> Am Do., 22. Juni 2017 um 08:50 Uhr schrieb Bin Meng <bmeng.cn@gmail.com>:
> >
> > Hi Christian,
> >
> > On Fri, Jun 9, 2017 at 8:58 AM, Tom Rini <trini@konsulko.com> wrote:
> > > On Thu, Jun 08, 2017 at 09:38:49AM +0200, Christian Gmeiner wrote:
> > >> Hi Tom
> > >>
> > >> 2017-06-06 22:04 GMT+02:00 Tom Rini <trini@konsulko.com>:
> > >> > On Tue, Jun 06, 2017 at 01:51:38PM +0200, Christian Gmeiner wrote:
> > >> >
> > >> >> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> > >> >> ---
> > >> >>  include/configs/x86-common.h | 2 +-
> > >> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > >> >>
> > >> >> diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h
> > >> >> index b5ef8b5..9a97714 100644
> > >> >> --- a/include/configs/x86-common.h
> > >> >> +++ b/include/configs/x86-common.h
> > >> >> @@ -56,7 +56,7 @@
> > >> >>   * Serial Configuration
> > >> >>   */
> > >> >>  #define CONFIG_SYS_BAUDRATE_TABLE    {300, 600, 1200, 2400, 4800, \
> > >> >> -                                      9600, 19200, 38400, 115200}
> > >> >> +                                      9600, 19200, 38400, 57600, 115200}
> > >> >>  #define CONFIG_SYS_NS16550_PORT_MAPPED
> > >> >>
> > >> >>  #define CONFIG_CMDLINE_EDITING
> > >> >
> > >> > Can we just use the fall back table instead?  Thanks!
> > >>
> > >> Can you point me to the "fall back table"?
> > >
> > > If one isn't defined the one in <config_fallbacks.h> is used.
> >
>
> The fallback table looks okay and has 57600 as baud rate in it. The problematic
> part is the xf86-common.h which defines CONFIG_SYS_BAUDRATE_TABLE and
> as a result the fallback table plays no role here.
>
> > Can you respin the patch per Tom's suggestion? Thanks!
>
> I think that the current patch is okay as Tom's suggestion does not fly.
>

I believe what Tom asked was to update config_fallbacks.h directly,
and then no need to keep x86-specific one.

Regards,
Bin
Tom Rini Sept. 5, 2018, 3:10 p.m. UTC | #7 
On Wed, Sep 05, 2018 at 12:57:39PM +0800, Bin Meng wrote:
> Hi Christian,
> 
> On Tue, Sep 4, 2018 at 6:07 PM Christian Gmeiner
> <christian.gmeiner@gmail.com> wrote:
> >
> > Hi all,
> >
> > I totally forgot to answer that mail - but as I need this change my
> > motivation is back.
> >
> > Am Do., 22. Juni 2017 um 08:50 Uhr schrieb Bin Meng <bmeng.cn@gmail.com>:
> > >
> > > Hi Christian,
> > >
> > > On Fri, Jun 9, 2017 at 8:58 AM, Tom Rini <trini@konsulko.com> wrote:
> > > > On Thu, Jun 08, 2017 at 09:38:49AM +0200, Christian Gmeiner wrote:
> > > >> Hi Tom
> > > >>
> > > >> 2017-06-06 22:04 GMT+02:00 Tom Rini <trini@konsulko.com>:
> > > >> > On Tue, Jun 06, 2017 at 01:51:38PM +0200, Christian Gmeiner wrote:
> > > >> >
> > > >> >> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> > > >> >> ---
> > > >> >>  include/configs/x86-common.h | 2 +-
> > > >> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >> >>
> > > >> >> diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h
> > > >> >> index b5ef8b5..9a97714 100644
> > > >> >> --- a/include/configs/x86-common.h
> > > >> >> +++ b/include/configs/x86-common.h
> > > >> >> @@ -56,7 +56,7 @@
> > > >> >>   * Serial Configuration
> > > >> >>   */
> > > >> >>  #define CONFIG_SYS_BAUDRATE_TABLE    {300, 600, 1200, 2400, 4800, \
> > > >> >> -                                      9600, 19200, 38400, 115200}
> > > >> >> +                                      9600, 19200, 38400, 57600, 115200}
> > > >> >>  #define CONFIG_SYS_NS16550_PORT_MAPPED
> > > >> >>
> > > >> >>  #define CONFIG_CMDLINE_EDITING
> > > >> >
> > > >> > Can we just use the fall back table instead?  Thanks!
> > > >>
> > > >> Can you point me to the "fall back table"?
> > > >
> > > > If one isn't defined the one in <config_fallbacks.h> is used.
> > >
> >
> > The fallback table looks okay and has 57600 as baud rate in it. The problematic
> > part is the xf86-common.h which defines CONFIG_SYS_BAUDRATE_TABLE and
> > as a result the fallback table plays no role here.
> >
> > > Can you respin the patch per Tom's suggestion? Thanks!
> >
> > I think that the current patch is okay as Tom's suggestion does not fly.
> >
> 
> I believe what Tom asked was to update config_fallbacks.h directly,
> and then no need to keep x86-specific one.

To be extra clear, drop the table from the x86 file and then the default
will be used.
Christian Gmeiner Sept. 6, 2018, 7:42 a.m. UTC | #8 
Am Mi., 5. Sep. 2018 um 17:10 Uhr schrieb Tom Rini <trini@konsulko.com>:
>
> On Wed, Sep 05, 2018 at 12:57:39PM +0800, Bin Meng wrote:
> > Hi Christian,
> >
> > On Tue, Sep 4, 2018 at 6:07 PM Christian Gmeiner
> > <christian.gmeiner@gmail.com> wrote:
> > >
> > > Hi all,
> > >
> > > I totally forgot to answer that mail - but as I need this change my
> > > motivation is back.
> > >
> > > Am Do., 22. Juni 2017 um 08:50 Uhr schrieb Bin Meng <bmeng.cn@gmail.com>:
> > > >
> > > > Hi Christian,
> > > >
> > > > On Fri, Jun 9, 2017 at 8:58 AM, Tom Rini <trini@konsulko.com> wrote:
> > > > > On Thu, Jun 08, 2017 at 09:38:49AM +0200, Christian Gmeiner wrote:
> > > > >> Hi Tom
> > > > >>
> > > > >> 2017-06-06 22:04 GMT+02:00 Tom Rini <trini@konsulko.com>:
> > > > >> > On Tue, Jun 06, 2017 at 01:51:38PM +0200, Christian Gmeiner wrote:
> > > > >> >
> > > > >> >> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> > > > >> >> ---
> > > > >> >>  include/configs/x86-common.h | 2 +-
> > > > >> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >> >>
> > > > >> >> diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h
> > > > >> >> index b5ef8b5..9a97714 100644
> > > > >> >> --- a/include/configs/x86-common.h
> > > > >> >> +++ b/include/configs/x86-common.h
> > > > >> >> @@ -56,7 +56,7 @@
> > > > >> >>   * Serial Configuration
> > > > >> >>   */
> > > > >> >>  #define CONFIG_SYS_BAUDRATE_TABLE    {300, 600, 1200, 2400, 4800, \
> > > > >> >> -                                      9600, 19200, 38400, 115200}
> > > > >> >> +                                      9600, 19200, 38400, 57600, 115200}
> > > > >> >>  #define CONFIG_SYS_NS16550_PORT_MAPPED
> > > > >> >>
> > > > >> >>  #define CONFIG_CMDLINE_EDITING
> > > > >> >
> > > > >> > Can we just use the fall back table instead?  Thanks!
> > > > >>
> > > > >> Can you point me to the "fall back table"?
> > > > >
> > > > > If one isn't defined the one in <config_fallbacks.h> is used.
> > > >
> > >
> > > The fallback table looks okay and has 57600 as baud rate in it. The problematic
> > > part is the xf86-common.h which defines CONFIG_SYS_BAUDRATE_TABLE and
> > > as a result the fallback table plays no role here.
> > >
> > > > Can you respin the patch per Tom's suggestion? Thanks!
> > >
> > > I think that the current patch is okay as Tom's suggestion does not fly.
> > >
> >
> > I believe what Tom asked was to update config_fallbacks.h directly,
> > and then no need to keep x86-specific one.
>
> To be extra clear, drop the table from the x86 file and then the default
> will be used.
>

Got it - thanks...
diff mbox

Patch

diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h
index b5ef8b5..9a97714 100644
--- a/include/configs/x86-common.h
+++ b/include/configs/x86-common.h
@@ -56,7 +56,7 @@ 
  * Serial Configuration
  */
 #define CONFIG_SYS_BAUDRATE_TABLE	{300, 600, 1200, 2400, 4800, \
-					 9600, 19200, 38400, 115200}
+					 9600, 19200, 38400, 57600, 115200}
 #define CONFIG_SYS_NS16550_PORT_MAPPED
 
 #define CONFIG_CMDLINE_EDITING