diff mbox

[U-Boot,RESEND,v3,1/5] MIPS: Make CM GCR base configurable

Message ID 20170512112611.9164-1-daniel.schwierzeck@gmail.com
State Accepted
Commit 939a255a671fb50549848505a4b44369cbe08efd
Delegated to: Daniel Schwierzeck
Headers show

Commit Message

Daniel Schwierzeck May 12, 2017, 11:26 a.m. UTC 
From: Paul Burton <paul.burton@imgtec.com>

Without adding a prompt for CONFIG_MIPS_CM_BASE, Kconfig doesn't allow
defconfigs to set it. Provide the prompt in order to allow for that.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>

---

Changes in v3:
- fix build error if CONFIG_MIPS_CM is not selected

Changes in v2:
- move to menu "General setup"

 arch/mips/Kconfig     | 19 ++++++++++---------
 arch/mips/lib/cache.c |  2 ++
 2 files changed, 12 insertions(+), 9 deletions(-)

Comments

Daniel Schwierzeck May 12, 2017, 9:03 p.m. UTC | #1 
Am 12.05.2017 um 13:26 schrieb Daniel Schwierzeck:
> From: Paul Burton <paul.burton@imgtec.com>
> 
> Without adding a prompt for CONFIG_MIPS_CM_BASE, Kconfig doesn't allow
> defconfigs to set it. Provide the prompt in order to allow for that.
> 
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> ---
> 
> Changes in v3:
> - fix build error if CONFIG_MIPS_CM is not selected
> 
> Changes in v2:
> - move to menu "General setup"
> 
>  arch/mips/Kconfig     | 19 ++++++++++---------
>  arch/mips/lib/cache.c |  2 ++
>  2 files changed, 12 insertions(+), 9 deletions(-)
> 

applied to u-boot-mips/master, thanks.
diff mbox

Patch

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index c97ea4156b..77d1ac65d2 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -221,6 +221,16 @@  config ROM_EXCEPTION_VECTORS
 	  Disable this, if the U-Boot image is booted from DRAM (e.g. by SPL).
 	  In that case the image size will be reduced by 0x500 bytes.
 
+config MIPS_CM_BASE
+	hex "MIPS CM GCR Base Address"
+	depends on MIPS_CM
+	default 0x1fbf8000
+	help
+	  The physical base address at which to map the MIPS Coherence Manager
+	  Global Configuration Registers (GCRs). This should be set such that
+	  the GCRs occupy a region of the physical address space which is
+	  otherwise unused, or at minimum that software doesn't need to access.
+
 endmenu
 
 menu "OS boot interface"
@@ -393,15 +403,6 @@  config MIPS_CM
 	  wish U-Boot to configure it or make use of it to retrieve system
 	  information such as cache configuration.
 
-config MIPS_CM_BASE
-	hex
-	default 0x1fbf8000
-	help
-	  The physical base address at which to map the MIPS Coherence Manager
-	  Global Configuration Registers (GCRs). This should be set such that
-	  the GCRs occupy a region of the physical address space which is
-	  otherwise unused, or at minimum that software doesn't need to access.
-
 endif
 
 endmenu
diff --git a/arch/mips/lib/cache.c b/arch/mips/lib/cache.c
index bd14ba6ea7..91b037f87d 100644
--- a/arch/mips/lib/cache.c
+++ b/arch/mips/lib/cache.c
@@ -7,7 +7,9 @@ 
 
 #include <common.h>
 #include <asm/cacheops.h>
+#ifdef CONFIG_MIPS_L2_CACHE
 #include <asm/cm.h>
+#endif
 #include <asm/mipsregs.h>
 
 DECLARE_GLOBAL_DATA_PTR;