From patchwork Wed May 3 21:11:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 758224 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3wJ9nt25BHz9s03 for ; Thu, 4 May 2017 07:11:45 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 01553C21C31; Wed, 3 May 2017 21:11:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_LOW autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id EECDFC21C25; Wed, 3 May 2017 21:11:37 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 30FACC21C25; Wed, 3 May 2017 21:11:36 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by lists.denx.de (Postfix) with ESMTPS id CF150C21BE5 for ; Wed, 3 May 2017 21:11:35 +0000 (UTC) Received: from LT002.fritz.box ([95.222.184.236]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LufbI-1e5iua1y88-00zlZA; Wed, 03 May 2017 23:11:24 +0200 From: Heinrich Schuchardt To: Tom Rini Date: Wed, 3 May 2017 23:11:19 +0200 Message-Id: <20170503211119.13743-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.11.0 X-Provags-ID: V03:K0:JCBDrOLiGYNhx4yt28I+g5diDu5btPLGbEd/wBUSIoy9Tm3+Br4 T3IQFnCGpdEvm5Xqiogqh723/OIz0fU7v9vPkIx6Uc+3rT7apMKgYdTU/4z4Mcmeue6SNVM 3AU49HVLsuQv4oRMUi+lqpWGlqzQFMcFT8DqKaJitkOa3nn8YO9lwDFhYwgnYJULSfjbWYi 7v5D8Weauox0OTHzLMgmA== X-UI-Out-Filterresults: notjunk:1; V01:K0:deQsxsD/YPM=:OOWV6DDSKzbsWKo3Vhjmsp dhKjszhyJoayM8xvWhhK6h4HgdNUpsuli2ur7+RijDZ2+qw+wfKUmUPfFdfsTeWsahkfdMMeC IXEEwVDcVan79UCY/je7aQRkvm0bsJVh14s+BkEGYUh15zdFxHD5Tq+ASm1RF2fNo5mMeMFdV I5JanCQuSt/0ynh46TAxNouHMGA/4MR9AVP1n5qq0edF6sKHMQLPoYSbTINFX7puv1GCmYy5T fZP64S5itecOYA7Ut5y8HIdXP2/c7Fb0hbZzlA0cqk4anm/n+wJi7HYG3S2XqM6bO6hGpFaez EQB1NpHBm+h4Zq9AKfya9XWNd+RrXPikiw9qWoSzco2DwQiG9YqlPOmwMM1C4aSDoUT03I7Hh dKbs2Pt0cjO4OkjqmBauxkyywmm7bir+diyb9HnBXWIPe9+YSLBGVBzcixi5UoRXujc8H0Ja4 4egKDEwO9WC10X1cSkGTfqOqwxfpybzkxEOPudHYBh/Z0xfhw/BXXGwosIfOMCEjLxVh0XW/4 qjWjiSuI4t3LgtwYP+JewKyfoFhF9aZIvBJZidEimlI0HnjZNAZ3P4y43cmZRFuhCeJ8xJ2Gh QXbtA7l6eQo+vgBD1Cjo4ZX95nbm1eiYPvaSAES61KVLpmctp383VL00v9kwc+h2gW/SaI93t XNvsZlpbPhfrXH5/pC8TVTyTskerwgxTOhtB1wp2j2IZjdKiKmhJ4Babba+rq9uS4+0OkPGMp Xb+lgwVSiHJsiG2n9HrZueUOpvbcOBaw025ukCvXGQhhb4uAfkZVdoNxuXI= Cc: Hans de Goede , Heinrich Schuchardt , u-boot@lists.denx.de, Maxime Ripard , Jagan Teki Subject: [U-Boot] [PATCH 1/1] tools: sunxi: avoid possible null pointer dereference X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" If endptr is NULL we should not dereference it. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt --- tools/sunxi-spl-image-builder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/sunxi-spl-image-builder.c b/tools/sunxi-spl-image-builder.c index d538a38813..0072a64728 100644 --- a/tools/sunxi-spl-image-builder.c +++ b/tools/sunxi-spl-image-builder.c @@ -433,7 +433,7 @@ int main(int argc, char **argv) break; case 'c': info.ecc_strength = strtol(optarg, &endptr, 0); - if (endptr || *endptr == '/') + if (endptr && *endptr == '/') info.ecc_step_size = strtol(endptr + 1, NULL, 0); break; case 'p':