| Message ID | 20161130164702.27372-3-marcel@ziswiler.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Warren |
| Headers | show |
On 30 November 2016 at 09:46, Marcel Ziswiler <marcel@ziswiler.com> wrote: > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > --- > > drivers/mmc/Kconfig | 6 ++++++ > 1 file changed, 6 insertions(+) > Reviewed-by: Simon Glass <sjg@chromium.org> But how about adding more help text? What versions of MMC/SD does it support? What bus speed and width? > diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig > index 24f4b28..19e89ab 100644 > --- a/drivers/mmc/Kconfig > +++ b/drivers/mmc/Kconfig > @@ -95,4 +95,10 @@ config SANDBOX_MMC > improves build coverage for sandbox and makes it easier to detect > MMC build errors with sandbox. > > +config TEGRA_MMC > + bool "Tegra SDHCI aka MMC support" > + depends on DM_MMC && TEGRA > + help > + This selects support for SDHCI on Tegra SoCs. > + > endmenu > -- > 2.9.3 > Regards, Simon
On December 1, 2016 3:20:44 AM GMT+01:00, Simon Glass <sjg@chromium.org> wrote: >On 30 November 2016 at 09:46, Marcel Ziswiler <marcel@ziswiler.com> >wrote: >> From: Marcel Ziswiler <marcel.ziswiler@toradex.com> >> >> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> >> --- >> >> drivers/mmc/Kconfig | 6 ++++++ >> 1 file changed, 6 insertions(+) >> > >Reviewed-by: Simon Glass <sjg@chromium.org> Thanks! >But how about adding more help text? I don't recall others indicating that much more help text to be honest. > What versions of MMC/SD does it support What bus speed and width? Good question. I guess the same as before which is highly SoC specific plus U-Boot won't be doing any higher speed modes requiring voltage switching as far as I know. To be honest I'm not even sure U-Boot's MMC stack would even support any such at all. >> diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig >> index 24f4b28..19e89ab 100644 >> --- a/drivers/mmc/Kconfig >> +++ b/drivers/mmc/Kconfig >> @@ -95,4 +95,10 @@ config SANDBOX_MMC >> improves build coverage for sandbox and makes it easier to >detect >> MMC build errors with sandbox. >> >> +config TEGRA_MMC >> + bool "Tegra SDHCI aka MMC support" >> + depends on DM_MMC && TEGRA >> + help >> + This selects support for SDHCI on Tegra SoCs. >> + >> endmenu >> -- >> 2.9.3 >> > >Regards, >Simon Cheers Marcel
diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig index 24f4b28..19e89ab 100644 --- a/drivers/mmc/Kconfig +++ b/drivers/mmc/Kconfig @@ -95,4 +95,10 @@ config SANDBOX_MMC improves build coverage for sandbox and makes it easier to detect MMC build errors with sandbox. +config TEGRA_MMC + bool "Tegra SDHCI aka MMC support" + depends on DM_MMC && TEGRA + help + This selects support for SDHCI on Tegra SoCs. + endmenu