diff mbox

[U-Boot,RESEND,11/24] r2dplus: select rtl8139 driver in defconfig

Message ID 20161127221536.9577-12-vz@mleia.com
State Accepted
Commit 40166c8d1b3eea4d2f15bf7c274bded2a2036def
Delegated to: Tom Rini
Headers show

Commit Message

Vladimir Zapolskiy Nov. 27, 2016, 10:15 p.m. UTC
CONFIG_RTL8139 was moved to a board defconfig by a commit 86e9dc86b1a2
("net: Move CONFIG_RTL8139 to Kconfig"), however it was done
incorrectly due to a missing CONFIG_NETDEVICES selection, thus
virtually it was just a removal of the driver compilation.

As an unlucky consequence the option was completely removed by a purge
commit adad96e60d0e ("configs: Re-sync HUSH options"), restore the
driver inclusion back.

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
---
 configs/r2dplus_defconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Simon Glass Nov. 30, 2016, 12:33 a.m. UTC | #1
On 27 November 2016 at 15:15, Vladimir Zapolskiy <vz@mleia.com> wrote:
> CONFIG_RTL8139 was moved to a board defconfig by a commit 86e9dc86b1a2
> ("net: Move CONFIG_RTL8139 to Kconfig"), however it was done
> incorrectly due to a missing CONFIG_NETDEVICES selection, thus
> virtually it was just a removal of the driver compilation.
>
> As an unlucky consequence the option was completely removed by a purge
> commit adad96e60d0e ("configs: Re-sync HUSH options"), restore the
> driver inclusion back.
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> ---
>  configs/r2dplus_defconfig | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>
Tom Rini Dec. 4, 2016, 12:36 a.m. UTC | #2
On Mon, Nov 28, 2016 at 12:15:23AM +0200, Vladimir Zapolskiy wrote:

> CONFIG_RTL8139 was moved to a board defconfig by a commit 86e9dc86b1a2
> ("net: Move CONFIG_RTL8139 to Kconfig"), however it was done
> incorrectly due to a missing CONFIG_NETDEVICES selection, thus
> virtually it was just a removal of the driver compilation.
> 
> As an unlucky consequence the option was completely removed by a purge
> commit adad96e60d0e ("configs: Re-sync HUSH options"), restore the
> driver inclusion back.
> 
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/configs/r2dplus_defconfig b/configs/r2dplus_defconfig
index f4dc68e..2637723 100644
--- a/configs/r2dplus_defconfig
+++ b/configs/r2dplus_defconfig
@@ -5,5 +5,7 @@  CONFIG_BOOTDELAY=-1
 CONFIG_CMD_PING=y
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_EXT2=y
+CONFIG_NETDEVICES=y
+CONFIG_RTL8139=y
 CONFIG_PCI=y
 CONFIG_USE_PRIVATE_LIBGCC=y