| Message ID | 20161108163859.14760-3-oliver@schinagl.nl |
|---|---|
| State | Accepted |
| Commit | cbe40e116d12a0bc6022e69e625ffb7140e29a60 |
| Delegated to: | Joe Hershberger |
| Headers | show |
Small nitpick: El 08/11/16 a las 13:38, Olliver Schinagl escribió: > All internal defines in the realtek phy are with a small X, > except MIIM_RTL8211X_CTRL1000T_MASTER. Make this more concistent s/concistent/consistent/ both here and on the subject :) Cheers! Emilio
Crap! I thought I spotted it but wasn't sure :) If there needs to be a v2 i'll fix it; if the v1 is accepted, Joe could hopefully fix that in the message *wink* :) Olliver On 09-11-16 00:17, Emilio López wrote: > Small nitpick: > > El 08/11/16 a las 13:38, Olliver Schinagl escribió: >> All internal defines in the realtek phy are with a small X, >> except MIIM_RTL8211X_CTRL1000T_MASTER. Make this more concistent > s/concistent/consistent/ both here and on the subject :) > > Cheers! > Emilio
On Tue, Nov 8, 2016 at 10:38 AM, Olliver Schinagl <oliver@schinagl.nl> wrote: > All internal defines in the realtek phy are with a small X, > except MIIM_RTL8211X_CTRL1000T_MASTER. Make this more concistent > > Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> Acked-by: Joe Hershberger <joe.hershberger@ni.com> I'll fix up the typo.
Hi oliver@schinagl.nl, https://patchwork.ozlabs.org/patch/692377/ was applied to u-boot-net.git. Thanks! -Joe
diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c index 35b934b..62b8c1e 100644 --- a/drivers/net/phy/realtek.c +++ b/drivers/net/phy/realtek.c @@ -16,7 +16,7 @@ /* RTL8211x 1000BASE-T Control Register */ #define MIIM_RTL8211x_CTRL1000T_MSCE BIT(12); -#define MIIM_RTL8211X_CTRL1000T_MASTER BIT(11); +#define MIIM_RTL8211x_CTRL1000T_MASTER BIT(11); /* RTL8211x PHY Status Register */ #define MIIM_RTL8211x_PHY_STATUS 0x11 @@ -64,7 +64,7 @@ static int rtl8211x_config(struct phy_device *phydev) /* force manual master/slave configuration */ reg |= MIIM_RTL8211x_CTRL1000T_MSCE; /* force master mode */ - reg |= MIIM_RTL8211X_CTRL1000T_MASTER; + reg |= MIIM_RTL8211x_CTRL1000T_MASTER; phy_write(phydev, MDIO_DEVAD_NONE, MII_CTRL1000, reg); #endif /* read interrupt status just to clear it */
All internal defines in the realtek phy are with a small X, except MIIM_RTL8211X_CTRL1000T_MASTER. Make this more concistent Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> --- drivers/net/phy/realtek.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)