diff mbox

[U-Boot,4/6] travis-ci: use buildman -P everywhere

Message ID 20161026170536.2367-4-swarren@wwwdotorg.org
State Accepted
Commit 440d8467a4109e349e9fd3d285ea4292fa77a2f8
Delegated to: Tom Rini
Headers show

Commit Message

Stephen Warren Oct. 26, 2016, 5:05 p.m. UTC
From: Stephen Warren <swarren@nvidia.com>

This places build results into a board-specific directory rather than a
buildman-thread-specific directory. This is required so that we can
access the directory from test.py, and there's no risk of a particular
build's results being over-written by another build performed by the
same thread.

In theory, this can lead to slower builds when building many different
boards in a single buildman thread, since it removes the possibility of
incremental builds between boards. In practice however I didn't notice
longer build times when when enabling this option; if anything build
times decreased although I suspect that's simply due to general
variations in build performance across different machines within the
Travis CI infra-structure.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Heiko Schocher Oct. 27, 2016, 4:22 a.m. UTC | #1
Hello Stephen,

Am 26.10.2016 um 19:05 schrieb Stephen Warren:
> From: Stephen Warren <swarren@nvidia.com>
>
> This places build results into a board-specific directory rather than a
> buildman-thread-specific directory. This is required so that we can
> access the directory from test.py, and there's no risk of a particular
> build's results being over-written by another build performed by the
> same thread.
>
> In theory, this can lead to slower builds when building many different
> boards in a single buildman thread, since it removes the possibility of
> incremental builds between boards. In practice however I didn't notice
> longer build times when when enabling this option; if anything build
> times decreased although I suspect that's simply due to general
> variations in build performance across different machines within the
> Travis CI infra-structure.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
>   .travis.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Thanks!

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko

>
> diff --git a/.travis.yml b/.travis.yml
> index 119dec8df5b2..6e72e0bb233f 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -72,7 +72,7 @@ script:
>    # Exit code 129 means warnings only.
>    - if [[ "${BUILDMAN}" != "" ]]; then
>        set +e;
> -     tools/buildman/buildman ${BUILDMAN};
> +     tools/buildman/buildman -P ${BUILDMAN};
>        ret=$?;
>        if [[ $ret -eq 0 || $ret -eq 129 ]]; then
>          exit 0;
>
Tom Rini Oct. 29, 2016, 5:41 p.m. UTC | #2
On Wed, Oct 26, 2016 at 11:05:34AM -0600, Stephen Warren wrote:

> From: Stephen Warren <swarren@nvidia.com>
> 
> This places build results into a board-specific directory rather than a
> buildman-thread-specific directory. This is required so that we can
> access the directory from test.py, and there's no risk of a particular
> build's results being over-written by another build performed by the
> same thread.
> 
> In theory, this can lead to slower builds when building many different
> boards in a single buildman thread, since it removes the possibility of
> incremental builds between boards. In practice however I didn't notice
> longer build times when when enabling this option; if anything build
> times decreased although I suspect that's simply due to general
> variations in build performance across different machines within the
> Travis CI infra-structure.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> Reviewed-by: Heiko Schocher <hs@denx.de>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/.travis.yml b/.travis.yml
index 119dec8df5b2..6e72e0bb233f 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -72,7 +72,7 @@  script:
  # Exit code 129 means warnings only.
  - if [[ "${BUILDMAN}" != "" ]]; then
      set +e;
-     tools/buildman/buildman ${BUILDMAN};
+     tools/buildman/buildman -P ${BUILDMAN};
      ret=$?;
      if [[ $ret -eq 0 || $ret -eq 129 ]]; then
        exit 0;