diff mbox

[U-Boot] generic board for socfpga

Message ID 20140527125030.GA29898@amd.pavel.ucw.cz
State Not Applicable
Delegated to: Albert ARIBAUD
Headers show

Commit Message

Pavel Machek May 27, 2014, 12:50 p.m. UTC 
Socfpga u-boot works fine with CONFIG_SYS_GENERIC_BOARD, so enable
that option as documentation suggests.

Signed-off-by: Pavel Machek <pavel@denx.de>

Comments

Chin Liang See June 2, 2014, 5:48 a.m. UTC | #1 
Hi Pavel,

On Tue, 2014-05-27 at 14:50 +0200, ZY - pavel wrote:
> Socfpga u-boot works fine with CONFIG_SYS_GENERIC_BOARD, so enable
> that option as documentation suggests.
> 

Yup, it works well for me without modification.

Acked-by: Chin Liang See <clsee@altera.com>

Thanks
Chin Liang

> Signed-off-by: Pavel Machek <pavel@denx.de>
> 
> diff --git a/include/configs/socfpga_cyclone5.h b/include/configs/socfpga_cyclone5.h
> index 2fc16ef..72d77f4 100644
> --- a/include/configs/socfpga_cyclone5.h
> +++ b/include/configs/socfpga_cyclone5.h
> @@ -16,6 +16,8 @@
>  /* Virtual target or real hardware */
>  #define CONFIG_SOCFPGA_VIRTUAL_TARGET
>  
> +#define CONFIG_SYS_GENERIC_BOARD
> +
>  #define CONFIG_ARMV7
>  #define CONFIG_SYS_DCACHE_OFF
>  #undef CONFIG_USE_IRQ
>
Albert ARIBAUD Sept. 9, 2014, 8:45 a.m. UTC | #2 
Hi Pavel,

On Tue, 27 May 2014 14:50:30 +0200, Pavel Machek <pavel@denx.de> wrote:

> 
> Socfpga u-boot works fine with CONFIG_SYS_GENERIC_BOARD, so enable
> that option as documentation suggests.
> 
> Signed-off-by: Pavel Machek <pavel@denx.de>
> 
> diff --git a/include/configs/socfpga_cyclone5.h b/include/configs/socfpga_cyclone5.h
> index 2fc16ef..72d77f4 100644
> --- a/include/configs/socfpga_cyclone5.h
> +++ b/include/configs/socfpga_cyclone5.h
> @@ -16,6 +16,8 @@
>  /* Virtual target or real hardware */
>  #define CONFIG_SOCFPGA_VIRTUAL_TARGET
>  
> +#define CONFIG_SYS_GENERIC_BOARD
> +
>  #define CONFIG_ARMV7
>  #define CONFIG_SYS_DCACHE_OFF
>  #undef CONFIG_USE_IRQ

Sorry, I let this last too long before I reviewed it and now it does
not apply cleanly at all. Can you have a look?

Amicalement,
diff mbox

Patch

diff --git a/include/configs/socfpga_cyclone5.h b/include/configs/socfpga_cyclone5.h
index 2fc16ef..72d77f4 100644
--- a/include/configs/socfpga_cyclone5.h
+++ b/include/configs/socfpga_cyclone5.h
@@ -16,6 +16,8 @@ 
 /* Virtual target or real hardware */
 #define CONFIG_SOCFPGA_VIRTUAL_TARGET
 
+#define CONFIG_SYS_GENERIC_BOARD
+
 #define CONFIG_ARMV7
 #define CONFIG_SYS_DCACHE_OFF
 #undef CONFIG_USE_IRQ