| Message ID | 20110810203310.21204.54944.stgit@shuttle2.etheralp.ch |
|---|---|
| State | Changes Requested |
| Delegated to: | Stefano Babic |
| Headers | show |
On 08/10/2011 10:33 PM, Eric Jarrige wrote: > Add i2c registers for Freescale imx1/L/S > > Signed-off-by: Eric Jarrige <eric.jarrige@armadeus.org> > Cc: Stefano Babic <sbabic@denx.de> > --- > arch/arm/include/asm/arch-imx/imx-regs.h | 23 +++++++++++++++++++++++ > 1 files changed, 23 insertions(+), 0 deletions(-) > Hi Eric, > > +/* > + * I2C module > + */ > +#define IADR __REG(IMX_I2C_BASE + 0x000) /* I2C Address Register */ > +#define IFDR __REG(IMX_I2C_BASE + 0x004) /* I2C Frequency Divider Register*/ > +#define I2CR __REG(IMX_I2C_BASE + 0x008) /* I2C Control Register */ > +#define I2SR __REG(IMX_I2C_BASE + 0x00C) /* I2C Status Register */ > +#define I2DR __REG(IMX_I2C_BASE + 0x010) /* I2C Data I/O Register */ See my comments on your [PATCH 3/9] apf9328: Add Armadeus Project board APF9328. Access to registers must be done via accessors and __REG macro should be removed. Best regards, Stefano Babic
Hi Stefano, On 11 août 2011, at 10:52, Stefano Babic wrote: > On 08/10/2011 10:33 PM, Eric Jarrige wrote: >> Add i2c registers for Freescale imx1/L/S >> >> Signed-off-by: Eric Jarrige <eric.jarrige@armadeus.org> >> Cc: Stefano Babic <sbabic@denx.de> >> --- >> arch/arm/include/asm/arch-imx/imx-regs.h | 23 +++++++++++++++++++++++ >> 1 files changed, 23 insertions(+), 0 deletions(-) >> > > Hi Eric, > >> >> +/* >> + * I2C module >> + */ >> +#define IADR __REG(IMX_I2C_BASE + 0x000) /* I2C Address Register */ >> +#define IFDR __REG(IMX_I2C_BASE + 0x004) /* I2C Frequency Divider Register*/ >> +#define I2CR __REG(IMX_I2C_BASE + 0x008) /* I2C Control Register */ >> +#define I2SR __REG(IMX_I2C_BASE + 0x00C) /* I2C Status Register */ >> +#define I2DR __REG(IMX_I2C_BASE + 0x010) /* I2C Data I/O Register */ > > See my comments on your [PATCH 3/9] apf9328: Add Armadeus Project board > APF9328. Access to registers must be done via accessors and __REG macro > should be removed. Ok, I remove the i2c driver from the apf9328 set of patches change the __REG macro to C struct and submit the i2c driver in a separate set of patches according to your comment in the [PATCH 3/9] Cheers, Eric
Dear Eric Jarrige, In message <20110810203310.21204.54944.stgit@shuttle2.etheralp.ch> you wrote: > Add i2c registers for Freescale imx1/L/S > > Signed-off-by: Eric Jarrige <eric.jarrige@armadeus.org> > Cc: Stefano Babic <sbabic@denx.de> > --- > arch/arm/include/asm/arch-imx/imx-regs.h | 23 +++++++++++++++++++++++ > 1 files changed, 23 insertions(+), 0 deletions(-) Checkpatch says: total: 0 errors, 13 warnings, 27 lines checked Please clean up and resubmit. Thanks. Best regards, Wolfgang Denk
diff --git a/arch/arm/include/asm/arch-imx/imx-regs.h b/arch/arm/include/asm/arch-imx/imx-regs.h index 0c26a36..a7b3404 100644 --- a/arch/arm/include/asm/arch-imx/imx-regs.h +++ b/arch/arm/include/asm/arch-imx/imx-regs.h @@ -638,4 +638,27 @@ extern void imx_gpio_mode(int gpio_mode); #define TSTAT_CAPT (1<<1) /* Capture event */ #define TSTAT_COMP (1) /* Compare event */ +/* + * I2C module + */ +#define IADR __REG(IMX_I2C_BASE + 0x000) /* I2C Address Register */ +#define IFDR __REG(IMX_I2C_BASE + 0x004) /* I2C Frequency Divider Register*/ +#define I2CR __REG(IMX_I2C_BASE + 0x008) /* I2C Control Register */ +#define I2SR __REG(IMX_I2C_BASE + 0x00C) /* I2C Status Register */ +#define I2DR __REG(IMX_I2C_BASE + 0x010) /* I2C Data I/O Register */ +/* I2C Control Register Bit Fields */ +#define I2CR_IEN (1<<7) /* I2C Enable */ +#define I2CR_IIEN (1<<6) /* I2C Interrupt Enable */ +#define I2CR_MSTA (1<<5) /* I2C Master/Slave Mode Select */ +#define I2CR_MTX (1<<4) /* I2C Transmit/Receive Mode Select */ +#define I2CR_TXAK (1<<3) /* I2C Transmit Acknowledge Enable */ +#define I2CR_RSTA (1<<2) /* I2C Repeated START */ +#define I2SR_ICF (1<<7) /* I2C Data Transfer */ +#define I2SR_IAAS (1<<6) /* I2C Addressed As a Slave */ +#define I2SR_IBB (1<<5) /* I2C Bus Busy */ +#define I2SR_IAL (1<<4) /* I2C Arbitration Lost */ +#define I2SR_SRW (1<<2) /* I2C Slave Read/Write */ +#define I2SR_IIF (1<<1) /* I2C interrupt */ +#define I2SR_RXAK (1<<0) /* I2C Received Acknowledge */ + #endif /* _IMX_REGS_H */
Add i2c registers for Freescale imx1/L/S Signed-off-by: Eric Jarrige <eric.jarrige@armadeus.org> Cc: Stefano Babic <sbabic@denx.de> --- arch/arm/include/asm/arch-imx/imx-regs.h | 23 +++++++++++++++++++++++ 1 files changed, 23 insertions(+), 0 deletions(-)